public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [flatpaks/flatpak-runtime] f45: Don't fail on empty dependencies from fedmod resolve-deps
@ 2026-09-11 14:41 Tomas Popela
0 siblings, 0 replies; only message in thread
From: Tomas Popela @ 2026-09-11 14:41 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : flatpaks/flatpak-runtime
Branch : f45
Commit : c6cf3406a69ccbf410f25b6dd874faae47359f29
Author : Tomas Popela <tpopela@redhat.com>
Date : 2022-05-12T09:30:22+02:00
Stats : +3/-0 in 1 file(s)
URL : https://src.fedoraproject.org/flatpaks/flatpak-runtime/c/c6cf3406a69ccbf410f25b6dd874faae47359f29?branch=f45
Log:
Don't fail on empty dependencies from fedmod resolve-deps
The rich dependencies are not at the moment handled by fedmod's
resolve-deps. Which could lead to fedmod failing when asking it for JSON
output and in other cases - reported as [0]. Owen prepared a patch[1] that
just returns an empty dependency in case of rich dependencies, but the
code in generate-runtime-report.py doesn't count with empty value there
so it needs to be adapted.
[0] - https://pagure.io/modularity/fedmod/issue/105
[1] - https://pagure.io/modularity/fedmod/issue/105#comment-795783
---
diff --git a/tools/generate-runtime-report.py b/tools/generate-runtime-report.py
index 1ded093..b589378 100755
--- a/tools/generate-runtime-report.py
+++ b/tools/generate-runtime-report.py
@@ -240,6 +240,9 @@ def add_packages(source, which, resolve_deps=False, only_if_exists=False):
for package in resolved_packages:
for req, providers in package['requires'].items():
+ # boolean dependency that didn't need to be satisfied
+ if len(providers) == 0:
+ continue
provider = nvr_to_name(providers[0])
provider_package = packages.get(provider, None)
if provider_package is None: # filtered out of the resolve-deps output - e.g., fedora-release
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-11 14:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-11 14:41 [flatpaks/flatpak-runtime] f45: Don't fail on empty dependencies from fedmod resolve-deps Tomas Popela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox