public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Tomas Popela <tpopela@redhat.com>
To: git-commits@fedoraproject.org
Subject: [flatpaks/flatpak-runtime] f45: Don't fail on empty dependencies from fedmod resolve-deps
Date: Fri, 11 Sep 2026 14:41:56 GMT [thread overview]
Message-ID: <178913771609.1.10768755825215003664.flatpaks-flatpak-runtime-c6cf3406a69c@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : flatpaks/flatpak-runtime
Branch : f45
Commit : c6cf3406a69ccbf410f25b6dd874faae47359f29
Author : Tomas Popela <tpopela@redhat.com>
Date : 2022-05-12T09:30:22+02:00
Stats : +3/-0 in 1 file(s)
URL : https://src.fedoraproject.org/flatpaks/flatpak-runtime/c/c6cf3406a69ccbf410f25b6dd874faae47359f29?branch=f45
Log:
Don't fail on empty dependencies from fedmod resolve-deps
The rich dependencies are not at the moment handled by fedmod's
resolve-deps. Which could lead to fedmod failing when asking it for JSON
output and in other cases - reported as [0]. Owen prepared a patch[1] that
just returns an empty dependency in case of rich dependencies, but the
code in generate-runtime-report.py doesn't count with empty value there
so it needs to be adapted.
[0] - https://pagure.io/modularity/fedmod/issue/105
[1] - https://pagure.io/modularity/fedmod/issue/105#comment-795783
---
diff --git a/tools/generate-runtime-report.py b/tools/generate-runtime-report.py
index 1ded093..b589378 100755
--- a/tools/generate-runtime-report.py
+++ b/tools/generate-runtime-report.py
@@ -240,6 +240,9 @@ def add_packages(source, which, resolve_deps=False, only_if_exists=False):
for package in resolved_packages:
for req, providers in package['requires'].items():
+ # boolean dependency that didn't need to be satisfied
+ if len(providers) == 0:
+ continue
provider = nvr_to_name(providers[0])
provider_package = packages.get(provider, None)
if provider_package is None: # filtered out of the resolve-deps output - e.g., fedora-release
reply other threads:[~2026-09-11 14:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178913771609.1.10768755825215003664.flatpaks-flatpak-runtime-c6cf3406a69c@fedoraproject.org \
--to=tpopela@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox