public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [tests/selinux] pr775-checkpolicy-revdeps: libselinux/selinux_restorecon-functions: Disable "null as list" test
@ 2026-09-11 13:17 Petr Lautrbach
  0 siblings, 0 replies; only message in thread
From: Petr Lautrbach @ 2026-09-11 13:17 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 2fdc2f8a5c1ee208126ce192565cbf672f86ed70
            Author : Petr Lautrbach <plautrba@redhat.com>
            Date   : 2018-05-31T21:55:55+02:00
            Stats  : +19/-16 in 1 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/2fdc2f8a5c1ee208126ce192565cbf672f86ed70?branch=pr775-checkpolicy-revdeps

            Log:
            libselinux/selinux_restorecon-functions: Disable "null as list" test

selinux_restorecon_set_exclude_list expects
"a pointer containing a NULL terminated list of one or more directories"
therefore this test doesn't make sense now

---
diff --git a/libselinux/selinux_restorecon-functions/runtest.sh b/libselinux/selinux_restorecon-functions/runtest.sh
index 5a51998..1cacacf 100755
--- a/libselinux/selinux_restorecon-functions/runtest.sh
+++ b/libselinux/selinux_restorecon-functions/runtest.sh
@@ -281,22 +281,25 @@ rlJournalStart
         rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"
 
-        # null as list
-        if rlIsFedora ">=26"; then
-            rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 139 "Calling selinux_restorecon_set_exclude_list with null as list"
-        else
-            rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list with null as list"
-
-            rlLogInfo "Checking lgetxattr calls"
-            rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
-
-            rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/afile\\\"\"       strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a/b\\\"\"         strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"
-        fi
+        ### selinux_restorecon_set_exclude_list expects
+        ### "a pointer containing a NULL terminated list of one or more directories"
+        ### therefore this test doesn't make sense now
+        ### # null as list
+        ### if rlIsFedora ">=26"; then
+        ###     rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 139 "Calling selinux_restorecon_set_exclude_list with null as list"
+        ### else
+        ###     rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list with null as list"
+        ### 
+        ###     rlLogInfo "Checking lgetxattr calls"
+        ###     rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        ### 
+        ###     rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/afile\\\"\"       strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a/b\\\"\"         strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"
+        ### fi
 
         # exclude $TmpDir/a
         rlRun "strace -ostrace.out -s 64 ./test_exclude_list $TmpDir/a $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list"

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-11 13:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-11 13:17 [tests/selinux] pr775-checkpolicy-revdeps: libselinux/selinux_restorecon-functions: Disable "null as list" test Petr Lautrbach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox