public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Petr Lautrbach <plautrba@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: libselinux/selinux_restorecon-functions: Disable "null as list" test
Date: Fri, 11 Sep 2026 13:17:16 GMT	[thread overview]
Message-ID: <178913263643.1.14324536973538885826.tests-selinux-2fdc2f8a5c1e@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 2fdc2f8a5c1ee208126ce192565cbf672f86ed70
            Author : Petr Lautrbach <plautrba@redhat.com>
            Date   : 2018-05-31T21:55:55+02:00
            Stats  : +19/-16 in 1 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/2fdc2f8a5c1ee208126ce192565cbf672f86ed70?branch=pr775-checkpolicy-revdeps

            Log:
            libselinux/selinux_restorecon-functions: Disable "null as list" test

selinux_restorecon_set_exclude_list expects
"a pointer containing a NULL terminated list of one or more directories"
therefore this test doesn't make sense now

---
diff --git a/libselinux/selinux_restorecon-functions/runtest.sh b/libselinux/selinux_restorecon-functions/runtest.sh
index 5a51998..1cacacf 100755
--- a/libselinux/selinux_restorecon-functions/runtest.sh
+++ b/libselinux/selinux_restorecon-functions/runtest.sh
@@ -281,22 +281,25 @@ rlJournalStart
         rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"
 
-        # null as list
-        if rlIsFedora ">=26"; then
-            rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 139 "Calling selinux_restorecon_set_exclude_list with null as list"
-        else
-            rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list with null as list"
-
-            rlLogInfo "Checking lgetxattr calls"
-            rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
-
-            rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/afile\\\"\"       strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a/b\\\"\"         strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"
-            rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"
-        fi
+        ### selinux_restorecon_set_exclude_list expects
+        ### "a pointer containing a NULL terminated list of one or more directories"
+        ### therefore this test doesn't make sense now
+        ### # null as list
+        ### if rlIsFedora ">=26"; then
+        ###     rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 139 "Calling selinux_restorecon_set_exclude_list with null as list"
+        ### else
+        ###     rlRun "strace -ostrace.out -s 64 ./test_exclude_list NULL $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list with null as list"
+        ### 
+        ###     rlLogInfo "Checking lgetxattr calls"
+        ###     rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        ### 
+        ###     rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/afile\\\"\"       strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a/b\\\"\"         strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out"
+        ###     rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out"
+        ### fi
 
         # exclude $TmpDir/a
         rlRun "strace -ostrace.out -s 64 ./test_exclude_list $TmpDir/a $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list"

                 reply	other threads:[~2026-09-11 13:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913263643.1.14324536973538885826.tests-selinux-2fdc2f8a5c1e@fedoraproject.org \
    --to=plautrba@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox