public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/glib2] cve-2026-58016-f44: Run tests in %check
@ 2026-08-11 10:38 Michael Catanzaro
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Catanzaro @ 2026-08-11 10:38 UTC (permalink / raw)
  To: git-commits

A new commit has been pushed.

Repo   : rpms/glib2
Branch : cve-2026-58016-f44
Commit : 13ce7f6d350feb011b7aa7af455036e719e2f4f1
Author : Michael Catanzaro <mcatanzaro@redhat.com>
Date   : 2024-04-30T13:24:42-05:00
Stats  : +8/-2 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/glib2/c/13ce7f6d350feb011b7aa7af455036e719e2f4f1?branch=cve-2026-58016-f44

Log:
Run tests in %check

---
diff --git a/glib2.spec b/glib2.spec
index 72d812d..1cd5cb0 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -20,12 +20,10 @@ BuildRequires:  gcc
 BuildRequires:  gcc-c++
 BuildRequires:  gettext
 BuildRequires:  perl-interpreter
-# for sys/inotify.h
 BuildRequires:  glibc-devel
 BuildRequires:  libattr-devel
 BuildRequires:  libselinux-devel
 BuildRequires:  meson
-# for sys/sdt.h
 BuildRequires:  systemtap-sdt-devel
 BuildRequires:  pkgconfig(gi-docgen)
 BuildRequires:  pkgconfig(libelf)
@@ -39,6 +37,11 @@ BuildRequires:  /usr/bin/g-ir-scanner
 BuildRequires:  /usr/bin/marshalparser
 BuildRequires:  /usr/bin/rst2man
 
+# Dependencies for tests
+BuildRequires:  shared-mime-info
+BuildRequires:  /usr/bin/dbus-daemon
+BuildRequires:  /usr/bin/update-desktop-database
+
 # For gnutls-hmac.patch. We now dlopen libgnutls.so.30 so that we can build a
 # static glib2 without depending on a static build of GnuTLS as well. This will
 # ensure we notice if the GnuTLS soname bumps, so that we can update our patch.
@@ -119,6 +122,9 @@ the functionality of the installed glib2 package.
 %install
 %meson_install
 
+%check
+%meson_test
+
 # We need reproducible .pyc files across architectures to support multilib installations
 # https://bugzilla.redhat.com/show_bug.cgi?id=2008912
 # https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Appendix/#_byte_compilation_reproducibility

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [rpms/glib2] cve-2026-58016-f44: Run tests in %check
@ 2026-08-11 10:38 Michael Catanzaro
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Catanzaro @ 2026-08-11 10:38 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/glib2
            Branch : cve-2026-58016-f44
            Commit : 94307d9752aefadcdfe771b76948c521f4e8296d
            Author : Michael Catanzaro <mcatanzaro@redhat.com>
            Date   : 2024-05-07T13:48:43-05:00
            Stats  : +8/-2 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/glib2/c/94307d9752aefadcdfe771b76948c521f4e8296d?branch=cve-2026-58016-f44

            Log:
            Run tests in %check

This time, put %check in the correct place, *after* %install rather than
in the middle of it. Things work a lot better this way....

---
diff --git a/glib2.spec b/glib2.spec
index 72d812d..77dda5f 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -20,12 +20,10 @@ BuildRequires:  gcc
 BuildRequires:  gcc-c++
 BuildRequires:  gettext
 BuildRequires:  perl-interpreter
-# for sys/inotify.h
 BuildRequires:  glibc-devel
 BuildRequires:  libattr-devel
 BuildRequires:  libselinux-devel
 BuildRequires:  meson
-# for sys/sdt.h
 BuildRequires:  systemtap-sdt-devel
 BuildRequires:  pkgconfig(gi-docgen)
 BuildRequires:  pkgconfig(libelf)
@@ -39,6 +37,11 @@ BuildRequires:  /usr/bin/g-ir-scanner
 BuildRequires:  /usr/bin/marshalparser
 BuildRequires:  /usr/bin/rst2man
 
+# Dependencies for tests
+BuildRequires:  shared-mime-info
+BuildRequires:  /usr/bin/dbus-daemon
+BuildRequires:  /usr/bin/update-desktop-database
+
 # For gnutls-hmac.patch. We now dlopen libgnutls.so.30 so that we can build a
 # static glib2 without depending on a static build of GnuTLS as well. This will
 # ensure we notice if the GnuTLS soname bumps, so that we can update our patch.
@@ -156,6 +159,9 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
 %transfiletriggerpostun -- %{_datadir}/glib-2.0/schemas
 glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
 
+%check
+%meson_test
+
 %files -f glib20.lang
 %license LICENSES/LGPL-2.1-or-later.txt
 %doc NEWS README.md

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-11 10:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-11 10:38 [rpms/glib2] cve-2026-58016-f44: Run tests in %check Michael Catanzaro
2026-08-11 10:38 Michael Catanzaro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox