public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michael Catanzaro <mcatanzaro@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/glib2] cve-2026-58016-f44: Run tests in %check
Date: Tue, 11 Aug 2026 10:38:13 GMT	[thread overview]
Message-ID: <178644469339.1.5190386967652855607.rpms-glib2-94307d9752ae@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/glib2
            Branch : cve-2026-58016-f44
            Commit : 94307d9752aefadcdfe771b76948c521f4e8296d
            Author : Michael Catanzaro <mcatanzaro@redhat.com>
            Date   : 2024-05-07T13:48:43-05:00
            Stats  : +8/-2 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/glib2/c/94307d9752aefadcdfe771b76948c521f4e8296d?branch=cve-2026-58016-f44

            Log:
            Run tests in %check

This time, put %check in the correct place, *after* %install rather than
in the middle of it. Things work a lot better this way....

---
diff --git a/glib2.spec b/glib2.spec
index 72d812d..77dda5f 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -20,12 +20,10 @@ BuildRequires:  gcc
 BuildRequires:  gcc-c++
 BuildRequires:  gettext
 BuildRequires:  perl-interpreter
-# for sys/inotify.h
 BuildRequires:  glibc-devel
 BuildRequires:  libattr-devel
 BuildRequires:  libselinux-devel
 BuildRequires:  meson
-# for sys/sdt.h
 BuildRequires:  systemtap-sdt-devel
 BuildRequires:  pkgconfig(gi-docgen)
 BuildRequires:  pkgconfig(libelf)
@@ -39,6 +37,11 @@ BuildRequires:  /usr/bin/g-ir-scanner
 BuildRequires:  /usr/bin/marshalparser
 BuildRequires:  /usr/bin/rst2man
 
+# Dependencies for tests
+BuildRequires:  shared-mime-info
+BuildRequires:  /usr/bin/dbus-daemon
+BuildRequires:  /usr/bin/update-desktop-database
+
 # For gnutls-hmac.patch. We now dlopen libgnutls.so.30 so that we can build a
 # static glib2 without depending on a static build of GnuTLS as well. This will
 # ensure we notice if the GnuTLS soname bumps, so that we can update our patch.
@@ -156,6 +159,9 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
 %transfiletriggerpostun -- %{_datadir}/glib-2.0/schemas
 glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
 
+%check
+%meson_test
+
 %files -f glib20.lang
 %license LICENSES/LGPL-2.1-or-later.txt
 %doc NEWS README.md

             reply	other threads:[~2026-08-11 10:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 10:38 Michael Catanzaro [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-08-11 10:38 [rpms/glib2] cve-2026-58016-f44: Run tests in %check Michael Catanzaro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178644469339.1.5190386967652855607.rpms-glib2-94307d9752ae@fedoraproject.org \
    --to=mcatanzaro@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox