public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/gnome-shell] rawhide: Drop GDM patch for broken PAM config as it's no longer needed
@ 2026-08-03 11:21 Jan Grulich
  0 siblings, 0 replies; only message in thread
From: Jan Grulich @ 2026-08-03 11:21 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/gnome-shell
            Branch : rawhide
            Commit : e9bce716dcecd15f5cd0c1402118faa0ac7b9057
            Author : Jan Grulich <jgrulich@redhat.com>
            Date   : 2026-08-03T13:20:36+02:00
            Stats  : +0/-69 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/gnome-shell/c/e9bce716dcecd15f5cd0c1402118faa0ac7b9057?branch=rawhide

            Log:
            Drop GDM patch for broken PAM config as it's no longer needed

[skip changelog]

---
diff --git a/0001-gdm-Work-around-failing-fingerprint-auth.patch b/0001-gdm-Work-around-failing-fingerprint-auth.patch
deleted file mode 100644
index 3729694..0000000
--- a/0001-gdm-Work-around-failing-fingerprint-auth.patch
+++ /dev/null
@@ -1,64 +0,0 @@
-From 33fc4214bcb2f813cf762fda99ef7f1f1755749b Mon Sep 17 00:00:00 2001
-From: Benjamin Berg <bberg@redhat.com>
-Date: Wed, 28 Apr 2021 16:50:03 +0200
-Subject: [PATCH] gdm: Work around failing fingerprint auth
-
-On Fedora we have the problem that fingerprint auth fails immediately if
-the PAM configuration has not been updated and no prints are enrolled.
-
-So, consider a verification failure within one second to be a service
-failure instead.
----
- js/gdm/util.js | 18 ++++++++++++++++++
- 1 file changed, 18 insertions(+)
-
-diff --git a/js/gdm/util.js b/js/gdm/util.js
-index c45579a22b2b..387a468b64b6 100644
---- a/js/gdm/util.js
-+++ b/js/gdm/util.js
-@@ -113,6 +113,7 @@ export class ShellUserVerifier extends Signals.EventEmitter {
-         this._defaultService = null;
-         this._preemptingService = null;
-         this._fingerprintReaderType = FingerprintReaderType.NONE;
-+        this._fprintStartTime = -1;
- 
-         this._messageQueue = [];
-         this._messageQueueTimeoutId = 0;
-@@ -672,6 +673,10 @@ export class ShellUserVerifier extends Signals.EventEmitter {
-         this._hold.acquire();
-         try {
-             this._activeServices.add(serviceName);
-+
-+            if (serviceName == FINGERPRINT_SERVICE_NAME)
-+                this._fprintStartTime = GLib.get_monotonic_time();
-+
-             if (this._userName) {
-                 await this._userVerifier.call_begin_verification_for_user(
-                     serviceName, this._userName, this._cancellable);
-@@ -766,6 +771,7 @@ export class ShellUserVerifier extends Signals.EventEmitter {
-                 const cancellable = this._cancellable;
-                 this._fingerprintFailedId = GLib.timeout_add_once(GLib.PRIORITY_DEFAULT,
-                     FINGERPRINT_ERROR_TIMEOUT_WAIT, () => {
-+                        log("Generating _verificationFailed!");
-                         this._fingerprintFailedId = 0;
-                         if (!cancellable.is_cancelled())
-                             this._verificationFailed(serviceName, false);
-@@ -838,6 +844,18 @@ export class ShellUserVerifier extends Signals.EventEmitter {
-         if (serviceName === FINGERPRINT_SERVICE_NAME) {
-             if (this._fingerprintFailedId)
-                 GLib.source_remove(this._fingerprintFailedId);
-+
-+            // On Fedora we have the problem that fingerprint auth fails
-+            // immediately if the PAM configuration has not been updated and no
-+            // prints are enrolled.
-+            // So, consider a verification failure within one second to be a service
-+            // failure instead.
-+            if (this._fprintStartTime > GLib.get_monotonic_time() - GLib.USEC_PER_SEC) {
-+                log("Fingerprint service failed almost immediately, considering it unavailable.");
-+                log("Please fix your configuration by running: authselect select --force sssd with-fingerprint with-silent-lastlog");
-+                this._onServiceUnavailable(this._client, serviceName, null);
-+                return;
-+            }
-         }
- 
-         // For Not Listed / enterprise logins, immediately reset

diff --git a/gnome-shell.spec b/gnome-shell.spec
index 980086d..80eb2c4 100644
--- a/gnome-shell.spec
+++ b/gnome-shell.spec
@@ -35,11 +35,6 @@ Source0:        https://download.gnome.org/sources/%{name}/%{gnome_major_version
 # Replace Epiphany with Firefox in the default favourite apps list
 Patch: gnome-shell-favourite-apps-firefox.patch
 
-# Some users might have a broken PAM config, so we really need this
-# downstream patch to stop trying on configuration errors.
-# FIXME: Needs rebase as the code was heavily refactored
-# Patch: 0001-gdm-Work-around-failing-fingerprint-auth.patch
-
 BuildRequires:  pkgconfig(bash-completion)
 BuildRequires:  gcc
 BuildRequires:  meson

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-03 11:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-03 11:21 [rpms/gnome-shell] rawhide: Drop GDM patch for broken PAM config as it's no longer needed Jan Grulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox