public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jan Grulich <jgrulich@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/gnome-shell] rawhide: Drop GDM patch for broken PAM config as it's no longer needed
Date: Mon, 03 Aug 2026 11:21:18 GMT [thread overview]
Message-ID: <178575607866.1.6501354515913931000.rpms-gnome-shell-e9bce716dcec@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/gnome-shell
Branch : rawhide
Commit : e9bce716dcecd15f5cd0c1402118faa0ac7b9057
Author : Jan Grulich <jgrulich@redhat.com>
Date : 2026-08-03T13:20:36+02:00
Stats : +0/-69 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/gnome-shell/c/e9bce716dcecd15f5cd0c1402118faa0ac7b9057?branch=rawhide
Log:
Drop GDM patch for broken PAM config as it's no longer needed
[skip changelog]
---
diff --git a/0001-gdm-Work-around-failing-fingerprint-auth.patch b/0001-gdm-Work-around-failing-fingerprint-auth.patch
deleted file mode 100644
index 3729694..0000000
--- a/0001-gdm-Work-around-failing-fingerprint-auth.patch
+++ /dev/null
@@ -1,64 +0,0 @@
-From 33fc4214bcb2f813cf762fda99ef7f1f1755749b Mon Sep 17 00:00:00 2001
-From: Benjamin Berg <bberg@redhat.com>
-Date: Wed, 28 Apr 2021 16:50:03 +0200
-Subject: [PATCH] gdm: Work around failing fingerprint auth
-
-On Fedora we have the problem that fingerprint auth fails immediately if
-the PAM configuration has not been updated and no prints are enrolled.
-
-So, consider a verification failure within one second to be a service
-failure instead.
----
- js/gdm/util.js | 18 ++++++++++++++++++
- 1 file changed, 18 insertions(+)
-
-diff --git a/js/gdm/util.js b/js/gdm/util.js
-index c45579a22b2b..387a468b64b6 100644
---- a/js/gdm/util.js
-+++ b/js/gdm/util.js
-@@ -113,6 +113,7 @@ export class ShellUserVerifier extends Signals.EventEmitter {
- this._defaultService = null;
- this._preemptingService = null;
- this._fingerprintReaderType = FingerprintReaderType.NONE;
-+ this._fprintStartTime = -1;
-
- this._messageQueue = [];
- this._messageQueueTimeoutId = 0;
-@@ -672,6 +673,10 @@ export class ShellUserVerifier extends Signals.EventEmitter {
- this._hold.acquire();
- try {
- this._activeServices.add(serviceName);
-+
-+ if (serviceName == FINGERPRINT_SERVICE_NAME)
-+ this._fprintStartTime = GLib.get_monotonic_time();
-+
- if (this._userName) {
- await this._userVerifier.call_begin_verification_for_user(
- serviceName, this._userName, this._cancellable);
-@@ -766,6 +771,7 @@ export class ShellUserVerifier extends Signals.EventEmitter {
- const cancellable = this._cancellable;
- this._fingerprintFailedId = GLib.timeout_add_once(GLib.PRIORITY_DEFAULT,
- FINGERPRINT_ERROR_TIMEOUT_WAIT, () => {
-+ log("Generating _verificationFailed!");
- this._fingerprintFailedId = 0;
- if (!cancellable.is_cancelled())
- this._verificationFailed(serviceName, false);
-@@ -838,6 +844,18 @@ export class ShellUserVerifier extends Signals.EventEmitter {
- if (serviceName === FINGERPRINT_SERVICE_NAME) {
- if (this._fingerprintFailedId)
- GLib.source_remove(this._fingerprintFailedId);
-+
-+ // On Fedora we have the problem that fingerprint auth fails
-+ // immediately if the PAM configuration has not been updated and no
-+ // prints are enrolled.
-+ // So, consider a verification failure within one second to be a service
-+ // failure instead.
-+ if (this._fprintStartTime > GLib.get_monotonic_time() - GLib.USEC_PER_SEC) {
-+ log("Fingerprint service failed almost immediately, considering it unavailable.");
-+ log("Please fix your configuration by running: authselect select --force sssd with-fingerprint with-silent-lastlog");
-+ this._onServiceUnavailable(this._client, serviceName, null);
-+ return;
-+ }
- }
-
- // For Not Listed / enterprise logins, immediately reset
diff --git a/gnome-shell.spec b/gnome-shell.spec
index 980086d..80eb2c4 100644
--- a/gnome-shell.spec
+++ b/gnome-shell.spec
@@ -35,11 +35,6 @@ Source0: https://download.gnome.org/sources/%{name}/%{gnome_major_version
# Replace Epiphany with Firefox in the default favourite apps list
Patch: gnome-shell-favourite-apps-firefox.patch
-# Some users might have a broken PAM config, so we really need this
-# downstream patch to stop trying on configuration errors.
-# FIXME: Needs rebase as the code was heavily refactored
-# Patch: 0001-gdm-Work-around-failing-fingerprint-auth.patch
-
BuildRequires: pkgconfig(bash-completion)
BuildRequires: gcc
BuildRequires: meson
reply other threads:[~2026-08-03 11:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178575607866.1.6501354515913931000.rpms-gnome-shell-e9bce716dcec@fedoraproject.org \
--to=jgrulich@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox