public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/cinnamon] rawhide: Add '__provides_exclude' for private libraries
@ 2026-07-28  7:59 Michal Schorm
  0 siblings, 0 replies; only message in thread
From: Michal Schorm @ 2026-07-28  7:59 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/cinnamon
            Branch : rawhide
            Commit : f8a0830b8e56b1856a48bc9cb14c05d73f1fc2e7
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-07-26T18:55:28+02:00
            Stats  : +1/-0 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/cinnamon/c/f8a0830b8e56b1856a48bc9cb14c05d73f1fc2e7?branch=rawhide

            Log:
            Add '__provides_exclude' for private libraries

'libcinnamon.so' and 'libst.so' are private libraries installed
to '%{_libdir}/cinnamon/' (the package-private 'pkglibdir'), not
the system '%{_libdir}/'.

  src/meson.build:   install_dir: pkglibdir  (libcinnamon)
  src/st/meson.build: install_dir: pkglibdir  (libst)

The spec already has '__requires_exclude' to prevent other packages
from acquiring automatic RPM dependencies on these private libs.
However, the matching '__provides_exclude' was missing, so the
cinnamon RPM still advertised RPM Provides for them — allowing
other packages to manually (or accidentally) depend on these
private, unstable libraries.

The original 2012 spec (commit 11a66b8, 2012-07-20, "filter provides
and requires") did filter both provides and requires. When the macros
were later changed from the old '%filter_provides_in' style to the
modern '%global __requires_exclude' style, the provides filter was
dropped and never restored.

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/cinnamon.spec b/cinnamon.spec
index 7bbb4d4..a200c17 100644
--- a/cinnamon.spec
+++ b/cinnamon.spec
@@ -1,4 +1,5 @@
 %global __requires_exclude ^libcinnamon\.so|^libst\.so
+%global __provides_exclude ^libcinnamon\.so|^libst\.so
 
 %global cjs_version 140.0
 %global cinnamon_desktop_version 6.7.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-28  7:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-28  7:59 [rpms/cinnamon] rawhide: Add '__provides_exclude' for private libraries Michal Schorm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox