public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/cinnamon] rawhide: Add '__provides_exclude' for private libraries
Date: Tue, 28 Jul 2026 07:59:06 GMT	[thread overview]
Message-ID: <178522554649.1.3370583500333128223.rpms-cinnamon-f8a0830b8e56@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/cinnamon
            Branch : rawhide
            Commit : f8a0830b8e56b1856a48bc9cb14c05d73f1fc2e7
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-07-26T18:55:28+02:00
            Stats  : +1/-0 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/cinnamon/c/f8a0830b8e56b1856a48bc9cb14c05d73f1fc2e7?branch=rawhide

            Log:
            Add '__provides_exclude' for private libraries

'libcinnamon.so' and 'libst.so' are private libraries installed
to '%{_libdir}/cinnamon/' (the package-private 'pkglibdir'), not
the system '%{_libdir}/'.

  src/meson.build:   install_dir: pkglibdir  (libcinnamon)
  src/st/meson.build: install_dir: pkglibdir  (libst)

The spec already has '__requires_exclude' to prevent other packages
from acquiring automatic RPM dependencies on these private libs.
However, the matching '__provides_exclude' was missing, so the
cinnamon RPM still advertised RPM Provides for them — allowing
other packages to manually (or accidentally) depend on these
private, unstable libraries.

The original 2012 spec (commit 11a66b8, 2012-07-20, "filter provides
and requires") did filter both provides and requires. When the macros
were later changed from the old '%filter_provides_in' style to the
modern '%global __requires_exclude' style, the provides filter was
dropped and never restored.

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/cinnamon.spec b/cinnamon.spec
index 7bbb4d4..a200c17 100644
--- a/cinnamon.spec
+++ b/cinnamon.spec
@@ -1,4 +1,5 @@
 %global __requires_exclude ^libcinnamon\.so|^libst\.so
+%global __provides_exclude ^libcinnamon\.so|^libst\.so
 
 %global cjs_version 140.0
 %global cinnamon_desktop_version 6.7.1

                 reply	other threads:[~2026-07-28  7:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178522554649.1.3370583500333128223.rpms-cinnamon-f8a0830b8e56@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox