public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/InsightToolkit] rawhide: feat: unbundle double conversion
@ 2026-07-23 12:50 Ankur Sinha
0 siblings, 0 replies; only message in thread
From: Ankur Sinha @ 2026-07-23 12:50 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/InsightToolkit
Branch : rawhide
Commit : b2ef2cbee1fb390aa819f0b86ff496d49436ed4a
Author : Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@gmail.com>
Date : 2026-07-16T11:19:24+01:00
Stats : +7/-12 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/InsightToolkit/c/b2ef2cbee1fb390aa819f0b86ff496d49436ed4a?branch=rawhide
Log:
feat: unbundle double conversion
---
diff --git a/InsightToolkit.spec b/InsightToolkit.spec
index e0ece0b..2888b1f 100644
--- a/InsightToolkit.spec
+++ b/InsightToolkit.spec
@@ -15,9 +15,8 @@ Version: %{version_major_minor}.%{version_patch}
Release: 1%{?dist}
# Bundled library licenses:
# Apache-2.0 - ITK core (upstream)
-# BSD-3-Clause - DICOMParser (Copyright.txt), DoubleConversion (LICENSE),
-# GoogleTest (source headers), KWSys (Copyright.txt),
-# MetaIO (License.txt)
+# BSD-3-Clause - DICOMParser (Copyright.txt), GoogleTest (source headers),
+# KWSys (Copyright.txt), MetaIO (License.txt)
# BSD-2-Clause - OpenJPEG (LICENSE)
# MIT - libLBFGS (lbfgs.h header)
# Zlib - NrrdIO (source headers, from Teem library)
@@ -38,8 +37,6 @@ Patch: 0001-remove-vxl-netlib.patch
# DICOMParser, GIFTI, KWSys, MetaIO, Netlib, VNLInstantiation: no version
# info available in ITK source
Provides: bundled(DICOMParser)
-Provides: bundled(double-conversion) = 3.1.6
-# Source: Modules/ThirdParty/DoubleConversion/CMakeLists.txt:10
Provides: bundled(gifticlib) = 1.16
# Source: Modules/ThirdParty/GIFTI/src/gifticlib/gifti_io.c:145
Provides: bundled(kwsys)
@@ -62,6 +59,7 @@ ExcludeArch: %{ix86}
BuildRequires: cmake
BuildRequires: doxygen
+BuildRequires: double-conversion-devel
BuildRequires: fftw-devel
BuildRequires: castxml
BuildRequires: eigen3-devel
@@ -173,12 +171,11 @@ rm -rf Applications/
# Libraries kept (pruned) because they are not available in Fedora or ITK
# has no mechanism to use the system version:
# DICOMParser, GIFTI, KWSys, MetaIO, NrrdIO, Netlib, VNLInstantiation - not in Fedora
-# DoubleConversion - needs source present
-# NIFTI - needs support: https://issues.itk.org/jira/browse/ITK-3349
-# OpenJPEG - needs support: https://issues.itk.org/jira/browse/ITK-3350
+# NIFTI - no ITK_USE_SYSTEM_NIFTI option (bundled nifti_clib)
+# OpenJPEG - no ITK_USE_SYSTEM_OPENJPEG option (bundles OpenJPEG 1.x)
# libLBFGS - in Fedora but ITK has no system option
# GoogleTest - in Fedora but ITK_USE_SYSTEM_GOOGLETEST is OFF
-find Modules/ThirdParty/* \( -name DICOMParser -o -name DoubleConversion -o -name GIFTI -o -name KWSys -o -name MetaIO -o -name NIFTI -o -name NrrdIO -o -name Netlib -o -name OpenJPEG -o -name VNLInstantiation -o -name libLBFGS -o -name GoogleTest \) \
+find Modules/ThirdParty/* \( -name DICOMParser -o -name GIFTI -o -name KWSys -o -name MetaIO -o -name NIFTI -o -name NrrdIO -o -name Netlib -o -name OpenJPEG -o -name VNLInstantiation -o -name libLBFGS -o -name GoogleTest \) \
-prune -o -regextype posix-extended -type f \
-regex ".*\.(h|hxx|hpp|c|cc|cpp|cxx|txx)$" -not -iname "itk*" -print0 | xargs -0 rm -fvr
@@ -215,6 +212,7 @@ extra_cflags=(
-DITK_USE_SYSTEM_LIBRARIES:BOOL=ON \
-DITK_USE_SYSTEM_CASTXML=ON \
-DITK_USE_SYSTEM_DCMTK=ON \
+ -DITK_USE_SYSTEM_DOUBLECONVERSION=ON \
-DITK_USE_SYSTEM_EXPAT=ON \
-DITK_USE_SYSTEM_FFTW=ON \
-DITK_USE_SYSTEM_GDCM=ON \
@@ -243,8 +241,6 @@ extra_cflags=(
# Install bundled library license files (avoid filename collisions)
mkdir -p %{buildroot}%{_defaultlicensedir}/%{name}
-cp -a Modules/ThirdParty/DoubleConversion/src/LICENSE \
- %{buildroot}%{_defaultlicensedir}/%{name}/LICENSE.double-conversion
cp -a Modules/ThirdParty/DICOMParser/src/DICOMParser/Copyright.txt \
%{buildroot}%{_defaultlicensedir}/%{name}/LICENSE.dicomparser
cp -a Modules/ThirdParty/GIFTI/src/gifticlib/LICENSE.gifti \
@@ -275,7 +271,6 @@ cp -ar Examples/* %{buildroot}%{_datadir}/%{name}/examples/
%files
%doc NOTICE README.md
%license LICENSE
-%license %{_defaultlicensedir}/%{name}/LICENSE.double-conversion
%license %{_defaultlicensedir}/%{name}/LICENSE.dicomparser
%license %{_defaultlicensedir}/%{name}/LICENSE.gifti
%license %{_defaultlicensedir}/%{name}/LICENSE.kwsys
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-23 12:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-23 12:50 [rpms/InsightToolkit] rawhide: feat: unbundle double conversion Ankur Sinha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox