public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/InsightToolkit] rawhide: feat: unbundle double conversion
Date: Thu, 23 Jul 2026 12:50:15 GMT	[thread overview]
Message-ID: <178481101598.1.918579927955156664.rpms-InsightToolkit-b2ef2cbee1fb@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/InsightToolkit
Branch : rawhide
Commit : b2ef2cbee1fb390aa819f0b86ff496d49436ed4a
Author : Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@gmail.com>
Date   : 2026-07-16T11:19:24+01:00
Stats  : +7/-12 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/InsightToolkit/c/b2ef2cbee1fb390aa819f0b86ff496d49436ed4a?branch=rawhide

Log:
feat: unbundle double conversion

---
diff --git a/InsightToolkit.spec b/InsightToolkit.spec
index e0ece0b..2888b1f 100644
--- a/InsightToolkit.spec
+++ b/InsightToolkit.spec
@@ -15,9 +15,8 @@ Version:        %{version_major_minor}.%{version_patch}
 Release:        1%{?dist}
 # Bundled library licenses:
 #   Apache-2.0       - ITK core (upstream)
-#   BSD-3-Clause     - DICOMParser (Copyright.txt), DoubleConversion (LICENSE),
-#                      GoogleTest (source headers), KWSys (Copyright.txt),
-#                      MetaIO (License.txt)
+#   BSD-3-Clause     - DICOMParser (Copyright.txt), GoogleTest (source headers),
+#                      KWSys (Copyright.txt), MetaIO (License.txt)
 #   BSD-2-Clause     - OpenJPEG (LICENSE)
 #   MIT              - libLBFGS (lbfgs.h header)
 #   Zlib             - NrrdIO (source headers, from Teem library)
@@ -38,8 +37,6 @@ Patch:         0001-remove-vxl-netlib.patch
 # DICOMParser, GIFTI, KWSys, MetaIO, Netlib, VNLInstantiation: no version
 #   info available in ITK source
 Provides: bundled(DICOMParser)
-Provides: bundled(double-conversion) = 3.1.6
-#   Source: Modules/ThirdParty/DoubleConversion/CMakeLists.txt:10
 Provides: bundled(gifticlib) = 1.16
 #   Source: Modules/ThirdParty/GIFTI/src/gifticlib/gifti_io.c:145
 Provides: bundled(kwsys)
@@ -62,6 +59,7 @@ ExcludeArch: %{ix86}
 
 BuildRequires:  cmake
 BuildRequires:  doxygen
+BuildRequires:  double-conversion-devel
 BuildRequires:  fftw-devel
 BuildRequires:  castxml
 BuildRequires:  eigen3-devel
@@ -173,12 +171,11 @@ rm -rf Applications/
 # Libraries kept (pruned) because they are not available in Fedora or ITK
 # has no mechanism to use the system version:
 #   DICOMParser, GIFTI, KWSys, MetaIO, NrrdIO, Netlib, VNLInstantiation - not in Fedora
-#   DoubleConversion - needs source present
-#   NIFTI - needs support: https://issues.itk.org/jira/browse/ITK-3349
-#   OpenJPEG - needs support: https://issues.itk.org/jira/browse/ITK-3350
+#   NIFTI - no ITK_USE_SYSTEM_NIFTI option (bundled nifti_clib)
+#   OpenJPEG - no ITK_USE_SYSTEM_OPENJPEG option (bundles OpenJPEG 1.x)
 #   libLBFGS - in Fedora but ITK has no system option
 #   GoogleTest - in Fedora but ITK_USE_SYSTEM_GOOGLETEST is OFF
-find Modules/ThirdParty/* \( -name DICOMParser -o -name DoubleConversion -o -name GIFTI -o -name KWSys -o -name MetaIO -o -name NIFTI -o -name NrrdIO -o -name Netlib -o -name OpenJPEG -o -name VNLInstantiation -o -name libLBFGS -o -name GoogleTest \) \
+find Modules/ThirdParty/* \( -name DICOMParser -o -name GIFTI -o -name KWSys -o -name MetaIO -o -name NIFTI -o -name NrrdIO -o -name Netlib -o -name OpenJPEG -o -name VNLInstantiation -o -name libLBFGS -o -name GoogleTest \) \
     -prune -o -regextype posix-extended -type f \
     -regex ".*\.(h|hxx|hpp|c|cc|cpp|cxx|txx)$" -not -iname "itk*" -print0 | xargs -0 rm -fvr
 
@@ -215,6 +212,7 @@ extra_cflags=(
        -DITK_USE_SYSTEM_LIBRARIES:BOOL=ON \
        -DITK_USE_SYSTEM_CASTXML=ON \
        -DITK_USE_SYSTEM_DCMTK=ON \
+       -DITK_USE_SYSTEM_DOUBLECONVERSION=ON \
        -DITK_USE_SYSTEM_EXPAT=ON \
        -DITK_USE_SYSTEM_FFTW=ON \
        -DITK_USE_SYSTEM_GDCM=ON \
@@ -243,8 +241,6 @@ extra_cflags=(
 
 # Install bundled library license files (avoid filename collisions)
 mkdir -p %{buildroot}%{_defaultlicensedir}/%{name}
-cp -a Modules/ThirdParty/DoubleConversion/src/LICENSE \
-   %{buildroot}%{_defaultlicensedir}/%{name}/LICENSE.double-conversion
 cp -a Modules/ThirdParty/DICOMParser/src/DICOMParser/Copyright.txt \
    %{buildroot}%{_defaultlicensedir}/%{name}/LICENSE.dicomparser
 cp -a Modules/ThirdParty/GIFTI/src/gifticlib/LICENSE.gifti \
@@ -275,7 +271,6 @@ cp -ar Examples/* %{buildroot}%{_datadir}/%{name}/examples/
 %files
 %doc NOTICE README.md
 %license LICENSE
-%license %{_defaultlicensedir}/%{name}/LICENSE.double-conversion
 %license %{_defaultlicensedir}/%{name}/LICENSE.dicomparser
 %license %{_defaultlicensedir}/%{name}/LICENSE.gifti
 %license %{_defaultlicensedir}/%{name}/LICENSE.kwsys

                 reply	other threads:[~2026-07-23 12:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178481101598.1.918579927955156664.rpms-InsightToolkit-b2ef2cbee1fb@fedoraproject.org \
    --to=sanjay.ankur@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox