public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/python-carbon] rawhide: Move editing of sources to %prep section
@ 2026-06-13 16:13 
  0 siblings, 0 replies; only message in thread
From:  @ 2026-06-13 16:13 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/python-carbon
            Branch : rawhide
            Commit : 187f642ec523815f1bf37dccc5786859d6b900d6
            Author : Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
            Date   : 2026-06-13T10:29:44+02:00
            Stats  : +2/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/python-carbon/c/187f642ec523815f1bf37dccc5786859d6b900d6?branch=rawhide

            Log:
            Move editing of sources to %prep section

The editing of sources was done partially in %generate_buildrequires.
This works, because the steps are done in order, but conceptually,
sources are supposed to be 'prepared' in %prep, so that at end of %prep
we have the tree in the state in which we'll be trying to work on it.

[skip changelog]

---
diff --git a/python-carbon.spec b/python-carbon.spec
index 71700b8..7646b50 100644
--- a/python-carbon.spec
+++ b/python-carbon.spec
@@ -92,14 +92,13 @@ sed -i -e 's/^import mock/from unittest import mock/' \
        -e 's/^from mock import /from unittest.mock import /' \
     lib/carbon/tests/*.py
 
-%generate_buildrequires
-%pyproject_buildrequires -r
-
 # Create a sysusers.d config file
 cat >python-carbon.sysusers.conf <<EOF
 u carbon - 'Carbon cache daemon' %{_localstatedir}/lib/carbon -
 EOF
 
+%generate_buildrequires
+%pyproject_buildrequires -r
 
 %build
 %pyproject_wheel

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-06-13 16:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-13 16:13 [rpms/python-carbon] rawhide: Move editing of sources to %prep section 

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox