public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/python-carbon] rawhide: Move editing of sources to %prep section
Date: Sat, 13 Jun 2026 16:13:30 GMT	[thread overview]
Message-ID: <178136721099.1.9819841415962987158.rpms-python-carbon-187f642ec523@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/python-carbon
            Branch : rawhide
            Commit : 187f642ec523815f1bf37dccc5786859d6b900d6
            Author : Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
            Date   : 2026-06-13T10:29:44+02:00
            Stats  : +2/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/python-carbon/c/187f642ec523815f1bf37dccc5786859d6b900d6?branch=rawhide

            Log:
            Move editing of sources to %prep section

The editing of sources was done partially in %generate_buildrequires.
This works, because the steps are done in order, but conceptually,
sources are supposed to be 'prepared' in %prep, so that at end of %prep
we have the tree in the state in which we'll be trying to work on it.

[skip changelog]

---
diff --git a/python-carbon.spec b/python-carbon.spec
index 71700b8..7646b50 100644
--- a/python-carbon.spec
+++ b/python-carbon.spec
@@ -92,14 +92,13 @@ sed -i -e 's/^import mock/from unittest import mock/' \
        -e 's/^from mock import /from unittest.mock import /' \
     lib/carbon/tests/*.py
 
-%generate_buildrequires
-%pyproject_buildrequires -r
-
 # Create a sysusers.d config file
 cat >python-carbon.sysusers.conf <<EOF
 u carbon - 'Carbon cache daemon' %{_localstatedir}/lib/carbon -
 EOF
 
+%generate_buildrequires
+%pyproject_buildrequires -r
 
 %build
 %pyproject_wheel

                 reply	other threads:[~2026-06-13 16:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178136721099.1.9819841415962987158.rpms-python-carbon-187f642ec523@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox