public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/python-httpbin] rawhide: Move editing of sources to %prep section
@ 2026-06-13  8:24 
  0 siblings, 0 replies; only message in thread
From:  @ 2026-06-13  8:24 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/python-httpbin
            Branch : rawhide
            Commit : 0438e279670f7ff93c35ac831730ac173d5b0675
            Author : Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
            Date   : 2026-06-13T10:07:19+02:00
            Stats  : +3/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/python-httpbin/c/0438e279670f7ff93c35ac831730ac173d5b0675?branch=rawhide

            Log:
            Move editing of sources to %prep section

The editing of sources was done partially in %generate_buildrequires.
This works, because the steps are done in order, but conceptually,
sources are supposed to be 'prepared' in %prep, so that at end of %prep
we have the tree in the state in which we'll be trying to work on it.
Also, no need to execute those commands more than once.

[skip changelog]

---
diff --git a/python-httpbin.spec b/python-httpbin.spec
index 0196e5d..b701868 100644
--- a/python-httpbin.spec
+++ b/python-httpbin.spec
@@ -53,13 +53,13 @@ BuildRequires:  python3dist(pytest)
 sed -i -e 's/brotlicffi/brotli/' httpbin/filters.py
 sed -i -e 's/brotlicffi/brotli/' pyproject.toml
 
-%generate_buildrequires
-%pyproject_buildrequires
-
 # no need for this to be executable
 # https://github.com/psf/httpbin/pull/22
 chmod ugo-x httpbin/templates/forms-post.html
 
+%generate_buildrequires
+%pyproject_buildrequires
+
 %build
 %pyproject_wheel
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-06-13  8:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-13  8:24 [rpms/python-httpbin] rawhide: Move editing of sources to %prep section 

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox