public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/python-httpbin] rawhide: Move editing of sources to %prep section
Date: Sat, 13 Jun 2026 08:24:40 GMT	[thread overview]
Message-ID: <178133908086.1.9360176270238055950.rpms-python-httpbin-0438e279670f@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/python-httpbin
            Branch : rawhide
            Commit : 0438e279670f7ff93c35ac831730ac173d5b0675
            Author : Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
            Date   : 2026-06-13T10:07:19+02:00
            Stats  : +3/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/python-httpbin/c/0438e279670f7ff93c35ac831730ac173d5b0675?branch=rawhide

            Log:
            Move editing of sources to %prep section

The editing of sources was done partially in %generate_buildrequires.
This works, because the steps are done in order, but conceptually,
sources are supposed to be 'prepared' in %prep, so that at end of %prep
we have the tree in the state in which we'll be trying to work on it.
Also, no need to execute those commands more than once.

[skip changelog]

---
diff --git a/python-httpbin.spec b/python-httpbin.spec
index 0196e5d..b701868 100644
--- a/python-httpbin.spec
+++ b/python-httpbin.spec
@@ -53,13 +53,13 @@ BuildRequires:  python3dist(pytest)
 sed -i -e 's/brotlicffi/brotli/' httpbin/filters.py
 sed -i -e 's/brotlicffi/brotli/' pyproject.toml
 
-%generate_buildrequires
-%pyproject_buildrequires
-
 # no need for this to be executable
 # https://github.com/psf/httpbin/pull/22
 chmod ugo-x httpbin/templates/forms-post.html
 
+%generate_buildrequires
+%pyproject_buildrequires
+
 %build
 %pyproject_wheel
 

                 reply	other threads:[~2026-06-13  8:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178133908086.1.9360176270238055950.rpms-python-httpbin-0438e279670f@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox