public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/rust-freedesktop-icons] f45: Drop benchmark-only dependencies and hide test-only feature
@ 2026-09-25 9:04 Fabio Valentini
0 siblings, 0 replies; only message in thread
From: Fabio Valentini @ 2026-09-25 9:04 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/rust-freedesktop-icons
Branch : f45
Commit : 7633b754983e2a3dfb21e994d47e8f6cb904c7e6
Author : Fabio Valentini <decathorpe@gmail.com>
Date : 2026-09-25T10:52:12+02:00
Stats : +34/-29 in 4 file(s)
URL : https://src.fedoraproject.org/rpms/rust-freedesktop-icons/c/7633b754983e2a3dfb21e994d47e8f6cb904c7e6?branch=f45
Log:
Drop benchmark-only dependencies and hide test-only feature
---
diff --git a/README.md b/README.md
deleted file mode 100644
index 945e9fa..0000000
--- a/README.md
+++ /dev/null
@@ -1,3 +0,0 @@
-# rust-freedesktop-icons
-
-The rust-freedesktop-icons package
diff --git a/freedesktop-icons-fix-metadata.diff b/freedesktop-icons-fix-metadata.diff
index 2b1011b..b2daae5 100644
--- a/freedesktop-icons-fix-metadata.diff
+++ b/freedesktop-icons-fix-metadata.diff
@@ -1,21 +1,26 @@
--- freedesktop-icons-0.4.0/Cargo.toml 1970-01-01T00:00:01+00:00
-+++ freedesktop-icons-0.4.0/Cargo.toml 2025-11-23T10:45:38.009051+00:00
++++ freedesktop-icons-0.4.0/Cargo.toml 2026-09-25T08:49:44.733975+00:00
@@ -47,7 +47,7 @@
path = "benches/tests.rs"
[dependencies.dirs]
-version = "5.0.1"
-+version = ">=5.0.1, <7.0.0"
++version = ">=5.0.1,<7.0.0"
[dependencies.ini_core]
version = "0.2.0"
-@@ -64,9 +64,6 @@
+@@ -64,14 +64,5 @@
[dependencies.xdg]
version = "2.5.2"
-[dev-dependencies.criterion]
-version = "0.5"
-
- [dev-dependencies.gtk4]
- version = "0.9"
-
+-[dev-dependencies.gtk4]
+-version = "0.9"
+-
+-[dev-dependencies.linicon]
+-version = "2.3.0"
+-
+ [dev-dependencies.speculoos]
+ version = "0.11.0"
diff --git a/rust-freedesktop-icons.spec b/rust-freedesktop-icons.spec
index cdf22a4..7711e98 100644
--- a/rust-freedesktop-icons.spec
+++ b/rust-freedesktop-icons.spec
@@ -1,4 +1,4 @@
-# Generated by rust2rpm 27
+# Generated by rust2rpm 28
%bcond check 1
%global debug_package %{nil}
@@ -13,12 +13,16 @@ License: MIT
URL: https://crates.io/crates/freedesktop-icons
Source: %{crates_source}
# Manually created patch for downstream crate metadata changes
-# * Drop unneeded criterion dependency
+# * drop benchmark- or doctest-only dev-dependencies: criterion, gtk4, linicon
# * Allow dirs 6; see “Update dirs dependency to version 6”,
# https://github.com/oknozor/freedesktop-icons/pull/29
Patch: freedesktop-icons-fix-metadata.diff
BuildRequires: cargo-rpm-macros >= 24
+%if %{with check}
+BuildRequires: adwaita-icon-theme
+BuildRequires: hicolor-icon-theme
+%endif
%global _description %{expand:
A Freedesktop Icons lookup crate.}
@@ -51,18 +55,6 @@ use the "default" feature of the "%{crate}" crate.
%files -n %{name}+default-devel
%ghost %{crate_instdir}/Cargo.toml
-%package -n %{name}+local_tests-devel
-Summary: %{summary}
-BuildArch: noarch
-
-%description -n %{name}+local_tests-devel %{_description}
-
-This package contains library source intended for building other packages which
-use the "local_tests" feature of the "%{crate}" crate.
-
-%files -n %{name}+local_tests-devel
-%ghost %{crate_instdir}/Cargo.toml
-
%prep
%autosetup -n %{crate}-%{version} -p1
%cargo_prep
@@ -78,7 +70,7 @@ use the "local_tests" feature of the "%{crate}" crate.
%if %{with check}
%check
-# * Skip broken tests
+# * skip tests that fail due to missing icon themes (Arc) or app icons (blueman)
%{cargo_test -- -- --exact %{shrink:
--skip theme::parse::test::should_get_theme_parents
--skip theme::test::should_get_png_first
diff --git a/rust2rpm.toml b/rust2rpm.toml
index b964d0f..ecc9e3f 100644
--- a/rust2rpm.toml
+++ b/rust2rpm.toml
@@ -1,17 +1,28 @@
[package]
cargo-toml-patch-comments = [
- "Drop unneeded criterion dependency",
+ "drop benchmark- or doctest-only dev-dependencies: criterion, gtk4, linicon",
"""\
Allow dirs 6; see “Update dirs dependency to version 6”, \
https://github.com/oknozor/freedesktop-icons/pull/29\
""",
]
+[features]
+# test-only feature for tests that require the "Papirus" and "Arc" icon themes
+hide = ["local_tests"]
+
+[requires]
+test = [
+ "adwaita-icon-theme",
+ "hicolor-icon-theme",
+]
+
[tests]
skip = [
- "theme::parse::test::should_get_theme_parents",
- "theme::test::should_get_png_first",
- "theme::test::should_get_svg_first",
+ "theme::parse::test::should_get_theme_parents",
+ "theme::test::should_get_png_first",
+ "theme::test::should_get_svg_first",
]
skip-exact = true
-comments = ["Skip broken tests"]
+comments = ["skip tests that fail due to missing icon themes (Arc) or app icons (blueman)"]
+
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-25 9:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-25 9:04 [rpms/rust-freedesktop-icons] f45: Drop benchmark-only dependencies and hide test-only feature Fabio Valentini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox