public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/onnxruntime] rawhide: Disable COMPILE_WARNING_AS_ERROR; fixes RHBZ#2385363
@ 2026-09-22 21:04 Benjamin A. Beasley
0 siblings, 0 replies; only message in thread
From: Benjamin A. Beasley @ 2026-09-22 21:04 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/onnxruntime
Branch : rawhide
Commit : b70b199af09814388f6d64a922a75aa4c3e0a293
Author : Benjamin A. Beasley <code@musicinmybrain.net>
Date : 2026-09-18T06:58:24+01:00
Stats : +44/-66 in 11 file(s)
URL : https://src.fedoraproject.org/rpms/onnxruntime/c/b70b199af09814388f6d64a922a75aa4c3e0a293?branch=rawhide
Log:
Disable COMPILE_WARNING_AS_ERROR; fixes RHBZ#2385363
---
diff --git a/0001-Disable-download-deps.patch b/0001-Disable-download-deps.patch
index 0e1f4bc..3c4d285 100644
--- a/0001-Disable-download-deps.patch
+++ b/0001-Disable-download-deps.patch
@@ -1,4 +1,4 @@
-From 1ce596a3f94a8f7cbd07ea43c67d4a42c156f33f Mon Sep 17 00:00:00 2001
+From 10051c2bb365bc5f634dcebd67036ef019d6d95f Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 19:16:49 -0400
Subject: [PATCH 01/12] Disable download deps
@@ -44,5 +44,5 @@ index be0abc980b..e6ca63a330 100644
include(external/abseil-cpp.cmake)
--
-2.54.0
+2.55.0
diff --git a/0002-System-abseil.patch b/0002-System-abseil.patch
index f8cd407..3118f56 100644
--- a/0002-System-abseil.patch
+++ b/0002-System-abseil.patch
@@ -1,4 +1,4 @@
-From 3b23eb11c77570cdacbbca2744c03944517255a7 Mon Sep 17 00:00:00 2001
+From 87ff9d5aafbde9e4fa252cdafb9cf1063ea9e21c Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 19:18:08 -0400
Subject: [PATCH 02/12] System abseil
@@ -19,5 +19,5 @@ index e6ca63a330..c564f68467 100644
onnxruntime_fetchcontent_declare(
--
-2.54.0
+2.55.0
diff --git a/0003-System-date-and-mp11.patch b/0003-System-date-and-mp11.patch
index 7036e5f..f0940cb 100644
--- a/0003-System-date-and-mp11.patch
+++ b/0003-System-date-and-mp11.patch
@@ -1,4 +1,4 @@
-From 1ddad843d4d7a8783570998f452d99607f8c2443 Mon Sep 17 00:00:00 2001
+From e544a66775c4b53605857dc8385f8540fb4d1d93 Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 19:06:32 -0400
Subject: [PATCH 03/12] System date and mp11
@@ -641,5 +641,5 @@ index eb2d69e162..7b46d1b559 100644
target_include_directories(winml_test_adapter PRIVATE ${winml_adapter_dir})
target_include_directories(winml_test_adapter PRIVATE ${winml_lib_common_dir}/inc)
--
-2.54.0
+2.55.0
diff --git a/0004-System-safeint.patch b/0004-System-safeint.patch
index 610f9ba..8d7a4a3 100644
--- a/0004-System-safeint.patch
+++ b/0004-System-safeint.patch
@@ -1,4 +1,4 @@
-From deadee0082c35e74139984c34ce8276ec1a9f384 Mon Sep 17 00:00:00 2001
+From e932ec1a7281b6f0c5156c4ab1801d8b66152407 Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 19:06:51 -0400
Subject: [PATCH 04/12] System safeint
@@ -44,5 +44,5 @@ index 7062e99f6c..cd2137bbf8 100644
#if defined(__GNUC__)
#include "onnxruntime_config.h"
--
-2.54.0
+2.55.0
diff --git a/0005-System-eigen3.patch b/0005-System-eigen3.patch
index 3b9693d..67f4c33 100644
--- a/0005-System-eigen3.patch
+++ b/0005-System-eigen3.patch
@@ -1,4 +1,4 @@
-From 0d93432389e9b43625fd35204a223c5cce75d7d6 Mon Sep 17 00:00:00 2001
+From 202bf54041ee3fa7214d99e8e81ee349de67417b Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 19:07:10 -0400
Subject: [PATCH 05/12] System eigen3
@@ -24,5 +24,5 @@ index 819df57c7c..a96298824b 100644
if(WIN32)
--
-2.54.0
+2.55.0
diff --git a/0006-System-flatbuffers.patch b/0006-System-flatbuffers.patch
index 9552d2b..4920dad 100644
--- a/0006-System-flatbuffers.patch
+++ b/0006-System-flatbuffers.patch
@@ -1,4 +1,4 @@
-From 9e6b402f1cc65b0cfcb7259fbd951e092e1478cc Mon Sep 17 00:00:00 2001
+From a5c92e63f52023cd61d7c0cc6e127fb650b381ed Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 19:07:31 -0400
Subject: [PATCH 06/12] System flatbuffers
@@ -27,5 +27,5 @@ index a96298824b..9df9304495 100644
endif()
--
-2.54.0
+2.55.0
diff --git a/0007-Do-not-set-COMPILE_WARNING_AS_ERROR.patch b/0007-Do-not-set-COMPILE_WARNING_AS_ERROR.patch
new file mode 100644
index 0000000..712e0ed
--- /dev/null
+++ b/0007-Do-not-set-COMPILE_WARNING_AS_ERROR.patch
@@ -0,0 +1,25 @@
+From c2dd287608af9ee1a0de6cf8f5fc776083152b7b Mon Sep 17 00:00:00 2001
+From: "Benjamin A. Beasley" <code@musicinmybrain.net>
+Date: Fri, 18 Sep 2026 06:54:50 +0100
+Subject: [PATCH 07/12] Do not set COMPILE_WARNING_AS_ERROR
+
+Considering new warnings can appear at any time due to changes in
+dependency and compiler versions, this is too strict for distribution
+packaging. It makes sense for upstream CI.
+
+diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt
+index 83d1751e55..a2b43780af 100644
+--- a/cmake/CMakeLists.txt
++++ b/cmake/CMakeLists.txt
+@@ -1106,7 +1106,7 @@ function(onnxruntime_set_compile_flags target_name)
+ target_compile_definitions(${target_name} PRIVATE USE_KLEIDIAI)
+ endif()
+
+- set_target_properties(${target_name} PROPERTIES COMPILE_WARNING_AS_ERROR ON)
++ set_target_properties(${target_name} PROPERTIES COMPILE_WARNING_AS_ERROR OFF)
+ if (onnxruntime_USE_CUDA)
+ # Suppress a "conversion_function_not_usable" warning in gsl/span
+ target_compile_options(${target_name} PRIVATE "$<$<COMPILE_LANGUAGE:CUDA>:SHELL:-Xcudafe \"--diag_suppress=conversion_function_not_usable\">")
+--
+2.55.0
+
diff --git a/0007-GCC-false-positives.patch b/0007-GCC-false-positives.patch
deleted file mode 100644
index d5aed24..0000000
--- a/0007-GCC-false-positives.patch
+++ /dev/null
@@ -1,47 +0,0 @@
-From 596c3058081eb6218ced020b57bf6a7fe9cf0bfd Mon Sep 17 00:00:00 2001
-From: Diego Herrera <dherrera@redhat.com>
-Date: Sun, 14 Jun 2026 19:07:53 -0400
-Subject: [PATCH 07/12] GCC false positives
-
-
-diff --git a/onnxruntime/core/optimizer/initializer.h b/onnxruntime/core/optimizer/initializer.h
-index 96c2ca41f5..d8b3f2353e 100644
---- a/onnxruntime/core/optimizer/initializer.h
-+++ b/onnxruntime/core/optimizer/initializer.h
-@@ -2,6 +2,7 @@
- // Licensed under the MIT License.
-
- #pragma once
-+#pragma GCC diagnostic ignored "-Wfree-nonheap-object"
-
- #include <algorithm>
- #include <functional>
-diff --git a/onnxruntime/core/optimizer/matmul_nbits_fusion.cc b/onnxruntime/core/optimizer/matmul_nbits_fusion.cc
-index 2739ff96b1..307b91d5fb 100644
---- a/onnxruntime/core/optimizer/matmul_nbits_fusion.cc
-+++ b/onnxruntime/core/optimizer/matmul_nbits_fusion.cc
-@@ -1,6 +1,8 @@
- // Copyright (c) Microsoft Corporation. All rights reserved.
- // Licensed under the MIT License.
-
-+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-+
- #include "core/optimizer/matmul_nbits_fusion.h"
-
- #include "core/common/common.h"
-diff --git a/onnxruntime/test/providers/cpu/ml/zipmap_test.cc b/onnxruntime/test/providers/cpu/ml/zipmap_test.cc
-index e2e8ced73e..bdd3c393f3 100644
---- a/onnxruntime/test/providers/cpu/ml/zipmap_test.cc
-+++ b/onnxruntime/test/providers/cpu/ml/zipmap_test.cc
-@@ -1,6 +1,8 @@
- // Copyright (c) Microsoft Corporation. All rights reserved.
- // Licensed under the MIT License.
-
-+#pragma GCC diagnostic ignored "-Wfree-nonheap-object"
-+
- #include "gtest/gtest.h"
- #include "test/providers/provider_test_utils.h"
- using namespace std;
---
-2.54.0
-
diff --git a/0008-migraphx-Fix-C-20-deprecated-this-capture.patch b/0008-migraphx-Fix-C-20-deprecated-this-capture.patch
index 1f68d39..65e9623 100644
--- a/0008-migraphx-Fix-C-20-deprecated-this-capture.patch
+++ b/0008-migraphx-Fix-C-20-deprecated-this-capture.patch
@@ -1,4 +1,4 @@
-From 02c19022cb64c75a9d8a60ccbae02fd30bc8fa23 Mon Sep 17 00:00:00 2001
+From f028fbaed3f57ff647be7a6057d3e93d0598c8de Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 19:08:31 -0400
Subject: [PATCH 08/12] migraphx Fix C++20 deprecated this capture
@@ -18,5 +18,5 @@ index 8908013a52..86d6b2a2a7 100644
*p = {context->allocate_func, context->release_func, context->allocator_handle, map_progs_[context->node_name],
map_onnx_string_[context->node_name], options, t_, map_input_index_[context->node_name], &mgx_mu_,
--
-2.54.0
+2.55.0
diff --git a/0009-System-dnnl.patch b/0009-System-dnnl.patch
index b66f097..a9f0f22 100644
--- a/0009-System-dnnl.patch
+++ b/0009-System-dnnl.patch
@@ -1,11 +1,11 @@
-From 0052b8a1b5b8c8b67b2c6d91b2eb22fd30248b2b Mon Sep 17 00:00:00 2001
+From 29ed8d75ccdf14c3661f1d282e65961c3d8de552 Mon Sep 17 00:00:00 2001
From: Diego Herrera <dherrera@redhat.com>
Date: Sun, 14 Jun 2026 23:20:26 -0400
Subject: [PATCH 09/12] System dnnl
diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt
-index 83d1751e55..18e5ab0578 100644
+index a2b43780af..6242960eaa 100644
--- a/cmake/CMakeLists.txt
+++ b/cmake/CMakeLists.txt
@@ -1330,7 +1330,7 @@ if (onnxruntime_USE_ACL)
@@ -86,5 +86,5 @@ index 9e3860969c..e4e9733d65 100644
if(WIN32)
set(wide_get_opt_src_dir ${TEST_SRC_DIR}/win_getopt/wide)
--
-2.54.0
+2.55.0
diff --git a/onnxruntime.spec b/onnxruntime.spec
index 7be0a49..f793a8b 100644
--- a/onnxruntime.spec
+++ b/onnxruntime.spec
@@ -61,8 +61,8 @@ Patch: 0004-System-safeint.patch
Patch: 0005-System-eigen3.patch
# Use the system flatbuffers
Patch: 0006-System-flatbuffers.patch
-# Disable gcc -Werrors with false positives
-Patch: 0007-GCC-false-positives.patch
+# Disable gcc -Werror, too strict for downstream packaging
+Patch: 0007-Do-not-set-COMPILE_WARNING_AS_ERROR.patch
# Fix deprecated C++20 feature use in migraphx implementation
Patch: 0008-migraphx-Fix-C-20-deprecated-this-capture.patch
# Use the system onednn lib
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-22 21:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-22 21:04 [rpms/onnxruntime] rawhide: Disable COMPILE_WARNING_AS_ERROR; fixes RHBZ#2385363 Benjamin A. Beasley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox