[tests/selinux] pr775-checkpolicy-revdeps: improve failing tests and add missing nitrate metadata

[tests/selinux] pr775-checkpolicy-revdeps: improve failing tests and add missing nitrate metadata

[Milos Malik]

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 774bd87aac0327ad2e95037bdaa48df1fc7fff37
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2025-01-13T12:59:22+00:00
            Stats  : +14/-2 in 10 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/774bd87aac0327ad2e95037bdaa48df1fc7fff37?branch=pr775-checkpolicy-revdeps

            Log:
            improve failing tests and add missing nitrate metadata

1 test was failing because of a test code issue.
1 test was missing an important test phase.

The number of tests which are missing their nitrate metadata
should be again smaller.

---
diff --git a/libselinux/getpolicyload/main.fmf b/libselinux/getpolicyload/main.fmf
index 9614113..627da13 100644
--- a/libselinux/getpolicyload/main.fmf
+++ b/libselinux/getpolicyload/main.fmf
@@ -20,4 +20,4 @@ adjust:
   - enabled: false
     when: distro < fedora-40
     because: the getpolicyload program is not available there
-
+extra-nitrate: TC#0615981

diff --git a/libsemanage/semanage-root-on-nfs/main.fmf b/libsemanage/semanage-root-on-nfs/main.fmf
index 20e219d..2cd8274 100644
--- a/libsemanage/semanage-root-on-nfs/main.fmf
+++ b/libsemanage/semanage-root-on-nfs/main.fmf
@@ -9,3 +9,4 @@ duration: 10m
 enabled: true
 link:
   - verifies: https://issues.redhat.com/browse/RHEL-60503
+extra-nitrate: TC#0617969

diff --git a/libsepol/self-keyword-in-type-rules/main.fmf b/libsepol/self-keyword-in-type-rules/main.fmf
index f54e8a6..038b5d9 100644
--- a/libsepol/self-keyword-in-type-rules/main.fmf
+++ b/libsepol/self-keyword-in-type-rules/main.fmf
@@ -25,3 +25,4 @@ adjust:
     because: This feature may not be available in F36 and below
 link:
   - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2069718
+extra-nitrate: TC#0613928

diff --git a/policycoreutils/semodule-rebuild-if-modules-changed/main.fmf b/policycoreutils/semodule-rebuild-if-modules-changed/main.fmf
index c2dc056..84f82f2 100644
--- a/policycoreutils/semodule-rebuild-if-modules-changed/main.fmf
+++ b/policycoreutils/semodule-rebuild-if-modules-changed/main.fmf
@@ -28,3 +28,4 @@ link:
   - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2049191
   - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2049193
   - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2173959
+extra-nitrate: TC#0613060

diff --git a/policycoreutils/sepolicy-generate-application/main.fmf b/policycoreutils/sepolicy-generate-application/main.fmf
index 6c587d8..4096a38 100644
--- a/policycoreutils/sepolicy-generate-application/main.fmf
+++ b/policycoreutils/sepolicy-generate-application/main.fmf
@@ -11,3 +11,4 @@ recommend:
   - abrt
 tier: '3'
 enabled: true
+extra-nitrate: TC#0615932

diff --git a/policycoreutils/spaces-in-fcontext-patterns/main.fmf b/policycoreutils/spaces-in-fcontext-patterns/main.fmf
index ad152e7..04ffc0e 100644
--- a/policycoreutils/spaces-in-fcontext-patterns/main.fmf
+++ b/policycoreutils/spaces-in-fcontext-patterns/main.fmf
@@ -35,3 +35,4 @@ adjust:
   - enabled: false
     when: distro == rhel-4, rhel-5, rhel-6, rhel-7
     continue: false
+extra-nitrate: TC#0614100

diff --git a/selinux-policy/gnome-remote-desktop-and-similar/main.fmf b/selinux-policy/gnome-remote-desktop-and-similar/main.fmf
index 79bbc59..07f2c6d 100644
--- a/selinux-policy/gnome-remote-desktop-and-similar/main.fmf
+++ b/selinux-policy/gnome-remote-desktop-and-similar/main.fmf
@@ -39,3 +39,4 @@ adjust:
     continue: false
 extra-summary: /CoreOS/selinux-policy/Regression/gnome-remote-desktop-and-similar
 extra-task: /CoreOS/selinux-policy/Regression/gnome-remote-desktop-and-similar
+extra-nitrate: TC#0617929

diff --git a/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh b/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh
index 9763687..6f3fcdf 100755
--- a/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh
+++ b/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh
@@ -66,6 +66,11 @@ rlJournalStart
     rlPhaseEnd
     fi
 
+    rlPhaseStartTest "RHEL-35877"
+        rlSESearchRule "allow gnome_remote_desktop_t policykit_t : dbus { send_msg } [ ]"
+        rlSESearchRule "allow policykit_t gnome_remote_desktop_t : dbus { send_msg } [ ]"
+    rlPhaseEnd
+
     if [ -f /usr/lib/systemd/system/gnome-remote-desktop.service ] ; then
     rlPhaseStartTest "real scenario"
         rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "start status" 1

diff --git a/selinux-policy/rpm-suppress-stderr/main.fmf b/selinux-policy/rpm-suppress-stderr/main.fmf
index 9ea92b7..cdf1174 100644
--- a/selinux-policy/rpm-suppress-stderr/main.fmf
+++ b/selinux-policy/rpm-suppress-stderr/main.fmf
@@ -15,3 +15,4 @@ adjust:
   - enabled: false
     when: distro == rhel-4, rhel-5, rhel-6, rhel-7, rhel-8
     continue: false
+extra-nitrate: TC#0617968

diff --git a/selinux-policy/rpm-suppress-stderr/test.sh b/selinux-policy/rpm-suppress-stderr/test.sh
index f7432da..9325a66 100755
--- a/selinux-policy/rpm-suppress-stderr/test.sh
+++ b/selinux-policy/rpm-suppress-stderr/test.sh
@@ -43,7 +43,7 @@ rlJournalStart
 	rlRun "fuse-overlayfs -o lowerdir=$tmp/lower/ -o upperdir=$tmp/upper/ -o workdir=$tmp/work/ $tmp/merged/"
 	RPMS=$(ls $tmp/merged/ | grep .rpm | xargs)
 	rlRun "chroot $tmp/merged/ /usr/bin/rpm -i $RPMS 2> error.log"
-	rlAssert0 "error.log should be empty" "test -s error.log"
+	rlAssert0 "error.log should be empty" `stat -c "%s" error.log`
 	rlRun "cat error.log"
 	rlRun "fusermount -u $tmp/merged/"
     rlPhaseEnd