public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [tests/selinux] pr775-checkpolicy-revdeps: Add a test for XFRM refcount underflow
@ 2026-09-11 13:21 Ondrej Mosnacek
  0 siblings, 0 replies; only message in thread
From: Ondrej Mosnacek @ 2026-09-11 13:21 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 586855095d5a64ef4e89a984bfdfccd8db0b2dc9
            Author : Ondrej Mosnacek <omosnace@redhat.com>
            Date   : 2024-03-04T13:40:26+01:00
            Stats  : +94/-0 in 2 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/586855095d5a64ef4e89a984bfdfccd8db0b2dc9?branch=pr775-checkpolicy-revdeps

            Log:
            Add a test for XFRM refcount underflow

Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>

---
diff --git a/kernel/xfrm-refcount-underflow/main.fmf b/kernel/xfrm-refcount-underflow/main.fmf
new file mode 100644
index 0000000..22e2690
--- /dev/null
+++ b/kernel/xfrm-refcount-underflow/main.fmf
@@ -0,0 +1,18 @@
+summary: XFRM refcount underflow test
+description: |
+    Test that allocating and deallocating XFRM state and/or policy
+    structures doesn't lead to selinux_xfrm_refcount imbalance and
+    underflow.
+contact: Ondrej Mosnacek <omosnace@redhat.com>
+component:
+- kernel
+framework: beakerlib
+duration: 15m
+tier: 2
+enabled: true
+adjust:
+    enabled: false
+    when: distro < rhel-7
+    because: RHEL-6 and below are not worth supporting by this test
+link:
+  - verifies: https://issues.redhat.com/browse/RHEL-27751

diff --git a/kernel/xfrm-refcount-underflow/runtest.sh b/kernel/xfrm-refcount-underflow/runtest.sh
new file mode 100755
index 0000000..895a1af
--- /dev/null
+++ b/kernel/xfrm-refcount-underflow/runtest.sh
@@ -0,0 +1,76 @@
+#!/bin/bash
+# vim: dict=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
+# SPDX-License-Identifier: GPLv2
+# Copyright (c) 2024 Red Hat, Inc.
+# Author: Ondrej Mosnacek <omosnace@redhat.com>
+
+# Include Beakerlib environment
+. /usr/share/beakerlib/beakerlib.sh || exit 1
+
+function installDepsYum() {
+    local yum="$1"; shift
+
+    if "$yum" --help | grep -q -- --skip-broken; then
+        "$yum" install -y --skip-broken $*
+    else
+        for req in $*; do
+            if ! rpm -q --quiet --whatprovides "$req"; then
+                "$yum" install -y "$req" || true
+            fi
+        done
+    fi
+}
+
+function installDeps() {
+    if type yum >/dev/null; then
+        installDepsYum yum "$@"
+    elif type dnf >/dev/null; then
+        installDepsYum dnf "$@"
+    fi
+}
+
+rlJournalStart
+    rlPhaseStartSetup
+        # Determine the base kernel package name and version corresponding
+        # to the currently running kernel. Use this information to derive
+        # the correct kernel subpackages to install.
+        if KERNEL_CORE_NVRA="$(rpm -qf "/lib/modules/$(uname -r)/kernel")"; then
+            KERNEL_CORE_NV="${KERNEL_CORE_NVRA%-*}"
+            KERNEL_CORE_N="${KERNEL_CORE_NV%-*}"
+
+            KERNEL_PKG_VRA="${KERNEL_CORE_NVRA#$KERNEL_CORE_N-}"
+            KERNEL_PKG_BASE="${KERNEL_CORE_N%-core}"
+
+            rlLog "Detected kernel package base name '$KERNEL_PKG_BASE' and version-release.arch '$KERNEL_PKG_VRA'"
+            KERNEL_PKGS="$KERNEL_PKG_BASE-devel-$KERNEL_PKG_VRA"
+        else
+            rlLog "Detected non-RPM running kernel - no extra kernel packages will be installed"
+            KERNEL_PKGS=""
+        fi
+
+        rlRun "installDeps systemtap $KERNEL_PKGS" 0 "Install requires"
+    rlPhaseEnd
+
+    rlPhaseStartTest
+        function dump_xfrm_refcount() {
+            local refcount_addr="0x$(grep selinux_xfrm_refcount /proc/kallsyms | cut -f 1 -d ' ')"
+            stap -e "probe begin {
+                printf(\"%i\\n\", atomic_read($refcount_addr))
+                exit()
+            }"
+        }
+        rlRun "dump_xfrm_refcount"
+        rlAssertEquals "Assert that XFRM refcount is zero at the beginning" \
+            "$(dump_xfrm_refcount)" 0
+        rlRun "ip xfrm policy add src 127.0.0.1 dst 127.0.0.1 proto tcp dir out tmpl proto ah mode transport level required" 0 \
+            "Add a dummy XFRM policy entry"
+        rlRun "ip xfrm state add src 127.0.0.1 dst 127.0.0.1 proto ah spi 0x200 auth sha1 0123456789012345" 0 \
+            "Add a dummy XFRM state entry"
+        rlRun "ip xfrm policy flush" 0 "Clear XFRM policy entries"
+        rlRun "ip xfrm state flush" 0 "Clear XFRM state entries"
+        rlRun "dump_xfrm_refcount"
+        rlAssertEquals "Assert that XFRM refcount is still zero" \
+            "$(dump_xfrm_refcount)" 0
+    rlPhaseEnd
+rlJournalPrintText
+rlJournalEnd

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-11 13:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-11 13:21 [tests/selinux] pr775-checkpolicy-revdeps: Add a test for XFRM refcount underflow Ondrej Mosnacek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox