[tests/selinux] pr775-checkpolicy-revdeps: test if ntpd can connect to 4460/tcp port

[tests/selinux] pr775-checkpolicy-revdeps: test if ntpd can connect to 4460/tcp port

[Milos Malik]

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : b7da677d1035b62dd0bb5e5d5423c516e70895af
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2023-11-02T18:30:32+00:00
            Stats  : +201/-0 in 4 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/b7da677d1035b62dd0bb5e5d5423c516e70895af?branch=pr775-checkpolicy-revdeps

            Log:
            test if ntpd can connect to 4460/tcp port

A recently filed BZ report revealed that SELinux prevents the ntpd
service (which belongs to the ntpsec package) from connecting to
the 4460/tcp port when it is configured to use the NTS servers. The
TC reproduces the situation.

In order to support the NTS standart for the ntpd service, I believe
that SELinux policy should allow the action. The TC looks for appropriate
policy rules, port context and file context patterns.

The TC covers BZ#2246805 and RHEL-15085.

---
diff --git a/selinux-policy/ntpsec-and-similar/Makefile b/selinux-policy/ntpsec-and-similar/Makefile
new file mode 100644
index 0000000..e0800fe
--- /dev/null
+++ b/selinux-policy/ntpsec-and-similar/Makefile
@@ -0,0 +1,69 @@
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Makefile of /CoreOS/selinux-policy/Regression/ntpsec-and-similar
+#   Description: SELinux interferes with the ntpsec ntpd service and related programs
+#   Author: Milos Malik <mmalik@redhat.com>
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Copyright (c) 2023 Red Hat, Inc. All rights reserved.
+#
+#   This copyrighted material is made available to anyone wishing
+#   to use, modify, copy, or redistribute it subject to the terms
+#   and conditions of the GNU General Public License version 2.
+#
+#   This program is distributed in the hope that it will be
+#   useful, but WITHOUT ANY WARRANTY; without even the implied
+#   warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+#   PURPOSE. See the GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU General Public
+#   License along with this program; if not, write to the Free
+#   Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+#   Boston, MA 02110-1301, USA.
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+export TEST=/CoreOS/selinux-policy/Regression/ntpsec-and-similar
+export TESTVERSION=1.0
+
+BUILT_FILES=
+
+FILES=$(METADATA) runtest.sh Makefile PURPOSE
+
+.PHONY: all install download clean
+
+run: $(FILES) build
+	./runtest.sh
+
+build: $(BUILT_FILES)
+	chmod a+x runtest.sh
+	chcon -t bin_t runtest.sh
+
+clean:
+	rm -f *~ $(BUILT_FILES)
+
+include /usr/share/rhts/lib/rhts-make.include
+
+$(METADATA): Makefile
+	@echo "Owner:           Milos Malik <mmalik@redhat.com>" > $(METADATA)
+	@echo "Name:            $(TEST)" >> $(METADATA)
+	@echo "TestVersion:     $(TESTVERSION)" >> $(METADATA)
+	@echo "Path:            $(TEST_DIR)" >> $(METADATA)
+	@echo "Description:     SELinux interferes with the ntpsec ntpd service and related programs" >> $(METADATA)
+	@echo "Type:            Regression" >> $(METADATA)
+	@echo "TestTime:        10m" >> $(METADATA)
+	@echo "RunFor:          selinux-policy" >> $(METADATA)
+	@echo "Requires:        audit libselinux libselinux-utils policycoreutils selinux-policy selinux-policy-targeted setools-console ntpsec /usr/sbin/service" >> $(METADATA)
+	@echo "RhtsRequires:    library(selinux-policy/common)" >> $(METADATA)
+	@echo "Environment:     AVC_ERROR=+no_avc_check" >> $(METADATA)
+	@echo "Priority:        Normal" >> $(METADATA)
+	@echo "License:         GPLv2" >> $(METADATA)
+	@echo "Confidential:    no" >> $(METADATA)
+	@echo "Destructive:     no" >> $(METADATA)
+	@echo "Releases:        -RHEL4 -RHEL5 -RHEL6 -RHEL7 -RHEL8 -RHEL9" >> $(METADATA)
+	@echo "Bug:             2246805" >> $(METADATA) # Fedora 38
+	@echo "Bug:             RHEL-15085" >> $(METADATA) # RHEL-9
+
+	rhts-lint $(METADATA)
+

diff --git a/selinux-policy/ntpsec-and-similar/PURPOSE b/selinux-policy/ntpsec-and-similar/PURPOSE
new file mode 100644
index 0000000..d39d82d
--- /dev/null
+++ b/selinux-policy/ntpsec-and-similar/PURPOSE
@@ -0,0 +1,5 @@
+PURPOSE of /CoreOS/selinux-policy/Regression/ntpsec-and-similar
+Author: Milos Malik <mmalik@redhat.com>
+
+SELinux interferes with the ntpsec ntpd service and related program
+

diff --git a/selinux-policy/ntpsec-and-similar/main.fmf b/selinux-policy/ntpsec-and-similar/main.fmf
new file mode 100644
index 0000000..979ea0e
--- /dev/null
+++ b/selinux-policy/ntpsec-and-similar/main.fmf
@@ -0,0 +1,44 @@
+summary: SELinux interferes with the ntpsec ntpd service and related programs
+description: |+
+    SELinux interferes with the ntpsec ntpd service and related programs.
+
+contact: Milos Malik <mmalik@redhat.com>
+component:
+  - selinux-policy
+require:
+  - library(selinux-policy/common)
+recommend:
+  - audit
+  - libselinux
+  - libselinux-utils
+  - policycoreutils
+  - selinux-policy
+  - selinux-policy-targeted
+  - setools-console
+  - ntpsec
+  - /usr/sbin/service
+environment:
+    AVC_ERROR: +no_avc_check
+duration: 10m
+enabled: true
+tag:
+  - NoRHEL4
+  - NoRHEL5
+  - NoRHEL6
+  - NoRHEL7
+  - NoRHEL8
+  - epel
+  - rhel9-epel
+  - targeted
+tier: '3'
+link:
+  - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2246805
+  - verifies: https://issues.redhat.com/browse/RHEL-15085
+adjust:
+  - enabled: false
+    when: distro == rhel-4, rhel-5, rhel-6, rhel-7, rhel-8
+    because: the ntpsec package is not available there
+extra-summary: /CoreOS/selinux-policy/Regression/ntpsec-and-similar
+extra-task: /CoreOS/selinux-policy/Regression/ntpsec-and-similar
+extra-nitrate: TC#0615926
+id: 258f0e8c-141f-473c-b418-d19049c464b2

diff --git a/selinux-policy/ntpsec-and-similar/runtest.sh b/selinux-policy/ntpsec-and-similar/runtest.sh
new file mode 100755
index 0000000..78a64a6
--- /dev/null
+++ b/selinux-policy/ntpsec-and-similar/runtest.sh
@@ -0,0 +1,83 @@
+#!/bin/bash
+# vim: dict=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   runtest.sh of /CoreOS/selinux-policy/Regression/ntpsec-and-similar
+#   Description: SELinux interferes with the ntpsec ntpd service and related programs
+#   Author: Milos Malik <mmalik@redhat.com>
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Copyright (c) 2023 Red Hat, Inc. All rights reserved.
+#
+#   This copyrighted material is made available to anyone wishing
+#   to use, modify, copy, or redistribute it subject to the terms
+#   and conditions of the GNU General Public License version 2.
+#
+#   This program is distributed in the hope that it will be
+#   useful, but WITHOUT ANY WARRANTY; without even the implied
+#   warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+#   PURPOSE. See the GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU General Public
+#   License along with this program; if not, write to the Free
+#   Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+#   Boston, MA 02110-1301, USA.
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+# Include Beaker environment
+. /usr/share/beakerlib/beakerlib.sh || exit 1
+
+PACKAGE="selinux-policy"
+FILE_PATH="/usr/sbin/ntpd"
+FILE_CONTEXT="ntpd_exec_t"
+SERVICE_PACKAGE="ntpsec"
+SERVICE_NAME="ntpd"
+PROCESS_NAME="ntpd"
+PROCESS_CONTEXT="ntpd_t"
+
+rlJournalStart
+    rlPhaseStartSetup
+        rlRun "rlImport 'selinux-policy/common'"
+        rlSESatisfyRequires
+        rlAssertRpm ${PACKAGE}
+        rlAssertRpm ${PACKAGE}-targeted
+        rlAssertRpm ${SERVICE_PACKAGE}
+
+        rlServiceStop ${SERVICE_NAME}
+        rlFileBackup /etc/ntp.conf
+
+        rlSESetEnforce
+        rlSEStatus
+        rlSESetTimestamp
+        sleep 2
+    rlPhaseEnd
+
+    rlPhaseStartTest "bz#2246805 + RHEL-15085"
+        rlSEMatchPathCon "/usr/sbin/ntpd" "ntpd_exec_t"
+        rlSESearchRule "allow ntpd_t ntske_port_t : tcp_socket { name_connect } [ ]"
+        rlSEMatchPortCon tcp 4460 ntske_port_t
+    rlPhaseEnd
+
+    rlPhaseStartTest "real scenario -- standalone service"
+        if ! rlSEDefined ${PROCESS_CONTEXT} ; then
+            # for environments where the SELinux domain does not exist yet
+            PROCESS_CONTEXT="unconfined_service_t"
+        fi
+        rlRun "echo -en '\nserver nts.netnod.se:4460 nts iburst\n' >> /etc/ntp.conf"
+        rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "start status" 1
+        rlRun "restorecon -Rv /etc /var /run -e /var/ARTIFACTS" 0-255
+        rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "restart status stop status" 1
+    rlPhaseEnd
+
+    rlPhaseStartCleanup
+        sleep 2
+        rlSECheckAVC
+
+        rlFileRestore
+        rlServiceRestore ${SERVICE_NAME}
+    rlPhaseEnd
+rlJournalPrintText
+rlJournalEnd
+