public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/uperf] epel10: Fix sendfilev configure glitch with C99 compilers
@ 2026-09-10 15:18 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2026-09-10 15:18 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/uperf
            Branch : epel10
            Commit : e29b9ed40ba8351abae9832f96f9c64630ec65c7
            Author : Florian Weimer <fweimer@redhat.com>
            Date   : 2022-11-25T23:12:15+01:00
            Stats  : +40/-1 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/uperf/c/e29b9ed40ba8351abae9832f96f9c64630ec65c7?branch=epel10

            Log:
            Fix sendfilev configure glitch with C99 compilers

Related to:

  <https://fedoraproject.org/wiki/Changes/PortingToModernC>
  <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>

---
diff --git a/uperf-configure-c99.patch b/uperf-configure-c99.patch
new file mode 100644
index 0000000..144e9be
--- /dev/null
+++ b/uperf-configure-c99.patch
@@ -0,0 +1,32 @@
+Avoid an implicit int in the sendfilev check.  This is harmless
+on Linux, which does not support senfilev, but this patch avoids
+flagging the test as a potential C99 compatibility issue.
+
+Submitted upstream: <https://github.com/uperf/uperf/pull/54>
+
+diff --git a/configure b/configure
+index 570a98c4ee663eef..c240333ae04cf743 100755
+--- a/configure
++++ b/configure
+@@ -4372,7 +4372,7 @@ $as_echo_n "checking sendfilev... " >&6; }
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+ /* end confdefs.h.  */
+ #include <sys/sendfile.h>
+-		main() {int i=sendfilev(1,0, 1, 0);}
++		int main() {int i=sendfilev(1,0, 1, 0);}
+ _ACEOF
+ if ac_fn_c_try_link "$LINENO"; then :
+   { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
+diff --git a/configure.ac b/configure.ac
+index 4bc192934f1daf6e..b2a08df3c3ee402a 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -99,7 +99,7 @@ AC_LINK_IFELSE([AC_LANG_SOURCE[#include <sys/byteorder.h>
+ # Linux 2.6 does not have sendfilev
+ AC_MSG_CHECKING(sendfilev)
+ AC_LINK_IFELSE([AC_LANG_SOURCE[#include <sys/sendfile.h>
+-		main() {int i=sendfilev(1,0, 1, 0);}]],
++		int main() {int i=sendfilev(1,0, 1, 0);}]],
+ 		[AC_MSG_RESULT(yes)
+ 	  	 AC_DEFINE([HAVE_SENDFILEV],[1],[Have sendfilev])
+ 		],

diff --git a/uperf.spec b/uperf.spec
index 0dbc2be..f7d4d54 100644
--- a/uperf.spec
+++ b/uperf.spec
@@ -1,11 +1,12 @@
 Summary:        Network performance tool with modelling and replay support
 Name:           uperf
 Version:        1.0.7
-Release:        7%{?dist}
+Release:        8%{?dist}
 License:        GPLv3
 URL:            http://www.uperf.org/
 Source0:        https://github.com/uperf/uperf/archive/%{version}.tar.gz
 Patch1:         uperf-1.0.6-ssl-crash.patch
+Patch2:         uperf-configure-c99.patch
 BuildRequires: make
 BuildRequires:  gcc
 BuildRequires:  lksctp-tools-devel
@@ -17,11 +18,14 @@ networking patterns.
 %prep
 %setup -q -n %{name}-%{version}
 %patch1 -p1
+%patch2 -p1
 find src -type f -print0 | xargs --null chmod 0644
 find workloads -type f -print0 | xargs --null chmod 0644
 chmod 0644 AUTHORS ChangeLog COPYING README
 
 %build
+# Prevent rebuilding of the configure script (for uperf-configure-c99.patch).
+touch aclocal.m4 Makefile.in config.h.in configure
 %configure           \
     --enable-cpc     \
     --enable-netstat \
@@ -46,6 +50,9 @@ rm -rf %{buildroot}%{_datadir}/*.xml %{buildroot}%{_datadir}/doc
 %{_datadir}/uperf
 
 %changelog
+* Fri Nov 25 2022 Florian Weimer <fweimer@redhat.com> - 1.0.7-8
+- Fix sendfilev configure glitch with C99 compilers
+
 * Sat Jul 23 2022 Fedora Release Engineering <releng@fedoraproject.org> - 1.0.7-7
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-10 15:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 15:18 [rpms/uperf] epel10: Fix sendfilev configure glitch with C99 compilers Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox