public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/wireshark] rawhide: Drop the Categories patch, which adds a deprecated value
@ 2026-09-08 19:28 Peter Lemenkov
0 siblings, 0 replies; only message in thread
From: Peter Lemenkov @ 2026-09-08 19:28 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/wireshark
Branch : rawhide
Commit : 0a1e55a478a455c19f5677256ee6cc6be16a482d
Author : Peter Lemenkov <lemenkov@gmail.com>
Date : 2026-09-08T21:26:46+02:00
Stats : +0/-17 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/wireshark/c/0a1e55a478a455c19f5677256ee6cc6be16a482d?branch=rawhide
Log:
Drop the Categories patch, which adds a deprecated value
The patch added Application to the Categories list in the desktop
file. That value is not in the freedesktop category registry, and
desktop-file-validate reports it:
warning: value "Application;Network;Monitor;Qt;" for key
"Categories" in group "Desktop Entry" contains a deprecated value
"Application"
The %install section runs desktop-file-validate on the installed file,
so that warning has been in every build. It is a warning rather than an
error, which is why it went unnoticed.
Application was a required category back in Desktop Entry Specification
0.9.x, when this patch was written, and it is also what Fedora's old
desktop-file-install --add-category=Application produced. Neither is
current, and modern desktops ignore the value. The entry already says
Type=Application on the line above, so it was redundant even when it
was valid.
Upstream's Categories=Network;Monitor;Qt; is correct as it stands: one
main category and two additional ones, all of them registered, and it
validates clean. Nothing to send upstream here.
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
---
diff --git a/wireshark-0004-Restore-Fedora-specific-groups.patch b/wireshark-0004-Restore-Fedora-specific-groups.patch
deleted file mode 100644
index 53e62dc..0000000
--- a/wireshark-0004-Restore-Fedora-specific-groups.patch
+++ /dev/null
@@ -1,15 +0,0 @@
-From: Peter Lemenkov <lemenkov@gmail.com>
-Date: Fri, 13 Sep 2013 14:36:55 +0400
-Subject: [PATCH] Restore Fedora-specific groups
-
-Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
-diff --git a/resources/freedesktop/org.wireshark.Wireshark.desktop b/resources/freedesktop/org.wireshark.Wireshark.desktop
-index a880a50a33..a25d67d99b 100644
---- a/resources/freedesktop/org.wireshark.Wireshark.desktop
-+++ b/resources/freedesktop/org.wireshark.Wireshark.desktop
-@@ -108,4 +108,4 @@ Terminal=false
- MimeType=application/vnd.tcpdump.pcap;application/x-pcapng;application/x-snoop;application/x-iptrace;application/x-lanalyzer;application/x-nettl;application/x-radcom;application/x-etherpeek;application/x-visualnetworks;application/x-netinstobserver;application/x-5view;application/x-tektronix-rf5;application/x-micropross-mplog;application/x-apple-packetlogger;application/x-endace-erf;application/ipfix;application/x-ixia-vwr;
- # Category entry according to:
- # https://specifications.freedesktop.org/menu-spec/1.0/
--Categories=Network;Monitor;Qt;
-+Categories=Application;Network;Monitor;Qt;
diff --git a/wireshark.spec b/wireshark.spec
index 0e5d38f..9804047 100644
--- a/wireshark.spec
+++ b/wireshark.spec
@@ -22,8 +22,6 @@ Source3: wireshark.sysusers
# Fedora-specific
Patch2: wireshark-0002-Customize-permission-denied-error.patch
# Fedora-specific
-Patch4: wireshark-0004-Restore-Fedora-specific-groups.patch
-# Fedora-specific
Patch5: wireshark-0005-Fix-paths-in-a-wireshark.desktop-file.patch
# Fedora-specific
Patch6: wireshark-0006-Move-tmp-to-var-tmp.patch
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-08 19:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-08 19:28 [rpms/wireshark] rawhide: Drop the Categories patch, which adds a deprecated value Peter Lemenkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox