[rpms/nodejs-undici] f43: Address rpmlint issues

[rpms/nodejs-undici] f43: Address rpmlint issues

[@ 2026-09-08 14:27 UTC (permalink / raw)]

            A new commit has been pushed.

            Repo   : rpms/nodejs-undici
            Branch : f43
            Commit : 90babdc6e92e12d7080be4f953b3b2f6654f57c4
            Author : Jan Staněk <jstanek@redhat.com>
            Date   : 2026-09-08T15:36:33+02:00
            Stats  : +12/-2 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/nodejs-undici/c/90babdc6e92e12d7080be4f953b3b2f6654f57c4?branch=f43

            Log:
            Address rpmlint issues

- Clean up packaging to get rid of unneeded empty files and symlinks
- Filter rpmlint issues that are either expected or not relevant in
  nodejs packaging

---
diff --git a/nodejs-undici.rpmlintrc b/nodejs-undici.rpmlintrc
new file mode 100644
index 0000000..19a7c1b
--- /dev/null
+++ b/nodejs-undici.rpmlintrc
@@ -0,0 +1,4 @@
+# bundled sources from script are expected
+addFilter(r"\binvalid-url Source.: undici-.*-(stripped|nm-prod|nm-dev)\.(tar\.gz|tgz)")
+# all node/npm packages are installed under /usr/lib/node_modules, even if they contain no arch-specific files
+addFilter(r"only-non-binary-in-usr-lib")

diff --git a/nodejs-undici.spec b/nodejs-undici.spec
index b121a24..3d9e052 100644
--- a/nodejs-undici.spec
+++ b/nodejs-undici.spec
@@ -61,10 +61,15 @@ then
 fi
 
 # Link node_modules
-mkdir -p node_modules/.bin/
+mkdir -p node_modules/
 tar -xzf %{S:1}
 ln -srt node_modules/       node_modules_prod/*
-ln -srt node_modules/.bin/  node_modules_prod/.bin
+test ! -d node_modules_prod/.bin || ln -srt node_modules/ node_modules_prod/.bin
+
+# Clean extraneous files we do not need to package
+find . -type f -name '.gitkeep' -size 0 -delete
+# https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json?v=true#hidden-lockfiles
+rm -f node_modules_prod/.package-lock.json
 
 %build
 export WASM_CC=clang
@@ -93,6 +98,7 @@ install -p -Dt %{buildroot}%{nodejs_sitelib}/%{npm_name}/            loader.js
 
 tar -xzf %{S:2}
 ln -fsrt node_modules/      node_modules_dev/*
+test -d node_modules/.bin || mkdir node_modules/.bin
 ln -fsrt node_modules/.bin/ node_modules_dev/.bin/*
 
 # Built-in test run using borp. Some tests are ignored on purpose.