[rpms/ddnet] exclude-empty-files: Update to 18.4 upstream release

[rpms/ddnet] exclude-empty-files: Update to 18.4 upstream release

[Packit]

            A new commit has been pushed.

            Repo   : rpms/ddnet
            Branch : exclude-empty-files
            Commit : ce969a0de3056bb6ba730733f6ed35c6fab2d77a
            Author : Packit <hello@packit.dev>
            Date   : 2024-07-25T13:14:47+01:00
            Stats  : +8/-68 in 4 file(s)
            URL    : https://src.fedoraproject.org/rpms/ddnet/c/ce969a0de3056bb6ba730733f6ed35c6fab2d77a?branch=exclude-empty-files

            Log:
            Update to 18.4 upstream release

- Resolves: rhbz#2298684

Upstream tag: 18.4
Upstream commit: 36825f51

Commit authored by Packit automation (https://packit.dev/)

---
diff --git a/README.packit b/README.packit
index f2be23e..8d4e245 100644
--- a/README.packit
+++ b/README.packit
@@ -1,3 +1,3 @@
 This repository is maintained by packit.
 https://packit.dev/
-The file was generated using packit 0.97.3.post1.dev7+g1954e49a.
+The file was generated using packit 0.99.0.post1.dev18+g4850a935.

diff --git a/ddnet.spec b/ddnet.spec
index 992217d..458c473 100644
--- a/ddnet.spec
+++ b/ddnet.spec
@@ -2,8 +2,8 @@
 %bcond_without ninja_build
 
 Name:           ddnet
-Version:        18.3.1
-Release:        2%{?dist}
+Version:        18.4
+Release:        1%{?dist}
 Summary:        DDraceNetwork, a cooperative racing mod of Teeworlds
 
 # Disabled while can't fix build
@@ -40,7 +40,6 @@ Patch1:         0001-Disabled-network-lookup-test.patch
 # Unbundle md5 and json-parser
 Patch2:         0002-Unbundle-md5_and_json-parser.patch
 Patch3:         0003-format-security.patch
-Patch4:         eab49abce2f67d8578bc87af5f7a4a04a7829449.patch
 
 BuildRequires:  desktop-file-utils
 BuildRequires:  libappstream-glib
@@ -177,6 +176,10 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
 
 
 %changelog
+* Tue Jul 23 2024 Packit <hello@packit.dev> - 18.4-1
+- Update to version 18.4
+- Resolves: rhbz#2298684
+
 * Wed Jul 17 2024 Fedora Release Engineering <releng@fedoraproject.org> - 18.3.1-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild
 

diff --git a/eab49abce2f67d8578bc87af5f7a4a04a7829449.patch b/eab49abce2f67d8578bc87af5f7a4a04a7829449.patch
deleted file mode 100644
index 31b1906..0000000
--- a/eab49abce2f67d8578bc87af5f7a4a04a7829449.patch
+++ /dev/null
@@ -1,63 +0,0 @@
-From 71b3c8a35bcdeb9287df9c7e1801c2021daf5ddb Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Robert=20M=C3=BCller?= <robytemueller@gmail.com>
-Date: Tue, 11 Jun 2024 22:11:50 +0200
-Subject: [PATCH] Force default `char` to be `signed` on all architectures
-
-We assume that `char` is `signed` in various places in the code. In particular, the `Str.StrToInts` test will fail when `char` is not `signed` and names containing special characters will be displayed incorrectly on servers.
-
-Therefore, the compiler flag `-fsigned-char` is set unconditionally instead of only for ARM and ARM64, as we expect `char` to be `signed` on all architectures.
-
-A static assertion is added to ensure at compile time that `char` is `signed` independently from the flag added in `CMakeLists.txt`.
-
-This is necessary at least for ARM, ARM64, PPC, PPC64, and PPC64LE. According to some sources, `char` may also be `unsigned` by default when compiling for Android, although this could not be confirmed with the current Android NDK using Clang.
-
-For the PowerPC architectures, Compiler Explorer can be used to confirm that `char` is not `signed` by default by checking whether the static assertion compiles (see https://godbolt.org/z/9rn5Mrf59) and that the assembly is different with the `-fsigned-char` flag (see https://godbolt.org/z/138zTj3Wa).
-
-Closes #8386.
----
- CMakeLists.txt        | 9 ++++-----
- src/game/gamecore.cpp | 4 ++++
- 2 files changed, 8 insertions(+), 5 deletions(-)
-
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index a10762c3239..71e625e5421 100644
---- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -291,11 +291,10 @@ if(NOT MSVC AND NOT HAIKU)
-     add_cxx_compiler_flag_if_supported(OUR_FLAGS -ffloat-store)
-   endif()
- 
--  # This is needed to get the server to correctly display special characters
--  # on ARM systems.
--  if("${CMAKE_SYSTEM_PROCESSOR}" MATCHES "arm" OR "${CMAKE_SYSTEM_PROCESSOR}" MATCHES "aarch64")
--    add_cxx_compiler_flag_if_supported(OUR_FLAGS -fsigned-char)
--  endif()
-+  # We assume that char is signed in various places in the code. In particular,
-+  # the Str.StrToInts test will fail when char is not signed and names containing
-+  # special characters will be displayed incorrectly on servers.
-+  add_cxx_compiler_flag_if_supported(OUR_FLAGS -fsigned-char)
- 
-   # Don't insert timestamps into PEs to keep the build reproducible.
-   if(TARGET_OS STREQUAL "windows")
-diff --git a/src/game/gamecore.cpp b/src/game/gamecore.cpp
-index fad18b7ac32..0f37382b0f9 100644
---- a/src/game/gamecore.cpp
-+++ b/src/game/gamecore.cpp
-@@ -9,6 +9,8 @@
- #include <base/system.h>
- #include <engine/shared/config.h>
- 
-+#include <limits>
-+
- const char *CTuningParams::ms_apNames[] =
- 	{
- #define MACRO_TUNING_PARAM(Name, ScriptName, Value, Description) #ScriptName,
-@@ -63,6 +65,8 @@ float CTuningParams::GetWeaponFireDelay(int Weapon) const
- 	}
- }
- 
-+static_assert(std::numeric_limits<char>::is_signed, "char must be signed for StrToInts to work correctly");
-+
- void StrToInts(int *pInts, size_t NumInts, const char *pStr)
- {
- 	dbg_assert(NumInts > 0, "StrToInts: NumInts invalid");

diff --git a/sources b/sources
index 06a28e3..ce16f81 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-SHA512 (ddnet-18.3.1.tar.gz) = 5d765c2166e0a31deb21f49719eda0fa25b790543ea1e4c5535a40f72ad3a4b63a8e01c5bcb0222726747703cbeb99e836ab90c6d4e9dd98ba55c3678273a22b
+SHA512 (ddnet-18.4.tar.gz) = 8cf7cb93c8e6f399e2f007f86be1bfee6761cf7e49b1901b90abe904f3f529527f68957c2af8517a96cfb500c6fe10a21e71138a6fc43e7ca5c800024197af31