public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/nss] rawhide: Disable TlsConnectDatagram13.ClientCertCallbackBeforeServerFinished
@ 2026-08-27 17:26 
  0 siblings, 0 replies; only message in thread
From:  @ 2026-08-27 17:26 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/nss
            Branch : rawhide
            Commit : aa340ff62eae5d67740fc245940965f2c9d91bf5
            Author : Krenželok František <fkrenzel@redhat.com>
            Date   : 2026-08-27T13:44:11+02:00
            Stats  : +18/-0 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/nss/c/aa340ff62eae5d67740fc245940965f2c9d91bf5?branch=rawhide

            Log:
            Disable TlsConnectDatagram13.ClientCertCallbackBeforeServerFinished

SplitServerFinished calls Protect() internally to save the Finished
record for later injection.  In DTLS 1.3 this advances the server's
record sequence counter, so subsequent server records (Certificate,
CertificateVerify) arrive at the client with an unexpected sequence
number and are rejected with SSL_ERROR_RX_MALFORMED_HANDSHAKE.  The
TLS stream variant of the same test passes.  Skip the DTLS variant
until the test infrastructure is fixed upstream.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---
diff --git a/nss-3.127-disable-dtls13-clientcert-test.patch b/nss-3.127-disable-dtls13-clientcert-test.patch
new file mode 100644
index 0000000..f7d3d3e
--- /dev/null
+++ b/nss-3.127-disable-dtls13-clientcert-test.patch
@@ -0,0 +1,12 @@
+--- a/gtests/ssl_gtest/ssl_auth_unittest.cc
++++ b/gtests/ssl_gtest/ssl_auth_unittest.cc
+@@ -465,6 +465,9 @@
+ // DTLS variant: Finished is its own record, so SplitServerFinished drops it
+ // entirely (finished_start == 0) and saves it for injection via Inject().
+ TEST_F(TlsConnectDatagram13, ClientCertCallbackBeforeServerFinished) {
++  // SplitServerFinished Protect() call advances the DTLS sequence counter,
++  // causing SSL_ERROR_RX_MALFORMED_HANDSHAKE (upstream test infra bug).
++  GTEST_SKIP();
+   client_->SetupClientAuth(ClientAuthCallbackType::kAsyncDelay, true);
+   server_->RequestClientAuth(true);
+   auto split = MakeTlsFilter<SplitServerFinished>(server_);

diff --git a/nss.spec b/nss.spec
index f6a5343..bb9ea58 100644
--- a/nss.spec
+++ b/nss.spec
@@ -149,6 +149,12 @@ Patch68:          nss-3.123-fix-mldsa-import-regeneration.patch
 # replay the parent's random stream (mozbz#2056509)
 Patch70:          nss-3.125-drbg-reseed-after-fork.patch
 
+# Disable TlsConnectDatagram13.ClientCertCallbackBeforeServerFinished — the
+# SplitServerFinished test filter advances the DTLS sequence counter when
+# saving the Finished record, which causes subsequent server records to be
+# rejected as malformed by the client (upstream test infrastructure bug).
+Patch71:          nss-3.127-disable-dtls13-clientcert-test.patch
+
 Patch100:         nspr-config-pc.patch
 Patch101:         nspr-gcc-atomics.patch
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-27 17:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-27 17:26 [rpms/nss] rawhide: Disable TlsConnectDatagram13.ClientCertCallbackBeforeServerFinished 

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox