public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/tree-sitter] rawhide: Two small fixes for chain-build.sh (dedup + Pagure error check)
@ 2026-08-27 15:03 Dainard, Samuel
0 siblings, 0 replies; only message in thread
From: Dainard, Samuel @ 2026-08-27 15:03 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/tree-sitter
Branch : rawhide
Commit : 91a158fab421d94a08c9b6cfd1b4c92c64ab4b76
Author : Dainard, Samuel <sdainard@amazon.com>
Date : 2026-08-27T15:59:56+01:00
Stats : +3/-2 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/tree-sitter/c/91a158fab421d94a08c9b6cfd1b4c92c64ab4b76?branch=rawhide
Log:
Two small fixes for chain-build.sh (dedup + Pagure error check)
1. Dependent list isn't deduplicated. dnf repoquery --qf='%{source_name}\n'
prints one line per binary package, so a source package that ships several
binaries linking libtree-sitter shows up multiple times and gets
cloned/bumped/built repeatedly. Piping the grep through sort -u fixes it.
2. Pagure error-response check never fires. In if [[ $response == "{*" ]]
the whole pattern is quoted, so * is literal and it only matches the exact
string {*. A real error object like {"error":"..."} slips past and gets
treated as a PR URL. Quoting just the brace — "{"* — restores the intended
"starts with {" glob.
---
diff --git a/chain-build.sh b/chain-build.sh
index ae54fbe..a05aa14 100755
--- a/chain-build.sh
+++ b/chain-build.sh
@@ -160,7 +160,8 @@ mapfile -t packages < <(
--releasever="${branch#f}" \
--whatrequires='libtree-sitter.so.*' \
--qf='%{source_name}\n' \
- | grep -v '^tree-sitter$'
+ | grep -v '^tree-sitter$' \
+ | sort -u
)
# Create a new side tag (or re-use the existing one, if this script
@@ -256,7 +257,7 @@ Relates to https://bugzilla.redhat.com/show_bug.cgi?id=${bugs[0]}.
"https://src.fedoraproject.org/api/0/rpms/$package/pull-request/new" \
| jq '.full_url // .'
)
- if [[ $response == "{*" ]]; then
+ if [[ $response == "{"* ]]; then
echo "Could not find pull request URL in Pagure response"
echo "$response"
exit 2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-27 15:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-27 15:03 [rpms/tree-sitter] rawhide: Two small fixes for chain-build.sh (dedup + Pagure error check) Dainard, Samuel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox