public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/petsc] rawhide: Install petsc/mpiuni headers for the --with-mpi=0 builds
@ 2026-08-27  9:30 Ali Erdinc Koroglu
  0 siblings, 0 replies; only message in thread
From: Ali Erdinc Koroglu @ 2026-08-27  9:30 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/petsc
            Branch : rawhide
            Commit : 74fbb5950c2a48e5ba43fd01ba16094629562b21
            Author : Ali Erdinc Koroglu <ali.koroglu@oss.qualcomm.com>
            Date   : 2026-08-26T15:49:19+03:00
            Stats  : +2/-0 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/petsc/c/74fbb5950c2a48e5ba43fd01ba16094629562b21?branch=rawhide

            Log:
            Install petsc/mpiuni headers for the --with-mpi=0 builds

Upstream installs the mpiuni headers exactly when the build uses MPIUni
(config/install.py, installIncludes):

    if not self.mpi.usingMPIUni:
      exclude.append('mpiuni')

This spec hand-copies the include tree rather than using upstream's
install target, and currently has that rule inverted: mpiuni is copied
into the two --with-mpi=1 flavours, which never use it, and omitted from
the two --with-mpi=0 flavours, which require it.

The result is that petscsys.h's

    #include <petsc/mpiuni/mpi.h>

cannot be satisfied, so no package can include a PETSc header against
petsc-devel or petsc64-devel. Seen as an FTBFS in getdp-3.6.0-17.fc46.

---
diff --git a/petsc.spec b/petsc.spec
index a1469bb..f571045 100644
--- a/petsc.spec
+++ b/petsc.spec
@@ -806,6 +806,7 @@ install -pm 644 include/petsc/finclude/*.h %{buildroot}%{_includedir}/%{name}/fi
 install -pm 644 %{_arch}/include/*.mod %{buildroot}%{_fmoddir}/%{name}/
 install -pm 644 include/*.h %{buildroot}%{_includedir}/%{name}/
 cp -a include/petsc/private %{buildroot}%{_includedir}/%{name}/
+cp -a include/petsc/mpiuni %{buildroot}%{_includedir}/%{name}/
 
 cp -a %{_arch}/lib/pkgconfig %{buildroot}%{_libdir}/
 sed -e 's|${prefix}/lib|${prefix}/%{_lib}|g' -i %{buildroot}%{_libdir}/pkgconfig/PETSc.pc
@@ -843,6 +844,7 @@ install -pm 644 include/petsc/finclude/*.h %{buildroot}%{_includedir}/%{name}64/
 install -pm 644 %{_arch}/include/*.mod %{buildroot}%{_fmoddir}/%{name}64/
 install -pm 644 include/*.h %{buildroot}%{_includedir}/%{name}64/
 cp -a include/petsc/private %{buildroot}%{_includedir}/%{name}64/
+cp -a include/petsc/mpiuni %{buildroot}%{_includedir}/%{name}64/
 
 cp -p %{_arch}/lib/pkgconfig/PETSc.pc %{buildroot}%{_libdir}/pkgconfig/PETSc64.pc
 cp -p %{_arch}/lib/pkgconfig/PETSc.pc %{buildroot}%{_libdir}/pkgconfig/petsc64.pc

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-27  9:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-27  9:30 [rpms/petsc] rawhide: Install petsc/mpiuni headers for the --with-mpi=0 builds Ali Erdinc Koroglu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox