[rpms/glib2] cve-2026-58016-f44: Fix CVE-2019-12450 (#1719142)

[rpms/glib2] cve-2026-58016-f44: Fix CVE-2019-12450 (#1719142)

[David King]

A new commit has been pushed.

Repo   : rpms/glib2
Branch : cve-2026-58016-f44
Commit : e81b0cb6f753ea70dcb613a1e59fc875f8affe36
Author : David King <amigadave@amigadave.com>
Date   : 2019-06-11T09:04:42+01:00
Stats  : +59/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/glib2/c/e81b0cb6f753ea70dcb613a1e59fc875f8affe36?branch=cve-2026-58016-f44

Log:
Fix CVE-2019-12450 (#1719142)

---
diff --git a/CVE-2019-12450.patch b/CVE-2019-12450.patch
new file mode 100644
index 0000000..6c514e1
--- /dev/null
+++ b/CVE-2019-12450.patch
@@ -0,0 +1,53 @@
+From d8f8f4d637ce43f8699ba94c9b7648beda0ca174 Mon Sep 17 00:00:00 2001
+From: Ondrej Holy <oholy@redhat.com>
+Date: Thu, 23 May 2019 10:41:53 +0200
+Subject: [PATCH] gfile: Limit access to files when copying
+
+file_copy_fallback creates new files with default permissions and
+set the correct permissions after the operation is finished. This
+might cause that the files can be accessible by more users during
+the operation than expected. Use G_FILE_CREATE_PRIVATE for the new
+files to limit access to those files.
+---
+ gio/gfile.c | 11 ++++++-----
+ 1 file changed, 6 insertions(+), 5 deletions(-)
+
+diff --git a/gio/gfile.c b/gio/gfile.c
+index 24b136d80..74b58047c 100644
+--- a/gio/gfile.c
++++ b/gio/gfile.c
+@@ -3284,12 +3284,12 @@ file_copy_fallback (GFile                  *source,
+         out = (GOutputStream*)_g_local_file_output_stream_replace (_g_local_file_get_filename (G_LOCAL_FILE (destination)),
+                                                                    FALSE, NULL,
+                                                                    flags & G_FILE_COPY_BACKUP,
+-                                                                   G_FILE_CREATE_REPLACE_DESTINATION,
+-                                                                   info,
++                                                                   G_FILE_CREATE_REPLACE_DESTINATION |
++                                                                   G_FILE_CREATE_PRIVATE, info,
+                                                                    cancellable, error);
+       else
+         out = (GOutputStream*)_g_local_file_output_stream_create (_g_local_file_get_filename (G_LOCAL_FILE (destination)),
+-                                                                  FALSE, 0, info,
++                                                                  FALSE, G_FILE_CREATE_PRIVATE, info,
+                                                                   cancellable, error);
+     }
+   else if (flags & G_FILE_COPY_OVERWRITE)
+@@ -3297,12 +3297,13 @@ file_copy_fallback (GFile                  *source,
+       out = (GOutputStream *)g_file_replace (destination,
+                                              NULL,
+                                              flags & G_FILE_COPY_BACKUP,
+-                                             G_FILE_CREATE_REPLACE_DESTINATION,
++                                             G_FILE_CREATE_REPLACE_DESTINATION |
++                                             G_FILE_CREATE_PRIVATE,
+                                              cancellable, error);
+     }
+   else
+     {
+-      out = (GOutputStream *)g_file_create (destination, 0, cancellable, error);
++      out = (GOutputStream *)g_file_create (destination, G_FILE_CREATE_PRIVATE, cancellable, error);
+     }
+ 
+   if (!out)
+-- 
+2.21.0
+

diff --git a/glib2.spec b/glib2.spec
index eff1491..5ad76d7 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -2,12 +2,14 @@
 
 Name: glib2
 Version: 2.61.1
-Release: 1%{?dist}
+Release: 2%{?dist}
 Summary: A library of handy utility functions
 
 License: LGPLv2+
 URL: http://www.gtk.org
 Source0: http://download.gnome.org/sources/glib/2.61/glib-%{version}.tar.xz
+# https://bugzilla.redhat.com/show_bug.cgi?id=1719142
+Patch0:  CVE-2019-12450.patch
 
 BuildRequires: chrpath
 BuildRequires: gcc
@@ -219,6 +221,9 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
 %{_datadir}/installed-tests
 
 %changelog
+* Tue Jun 11 2019 David King <amigadave@amigadave.com> - 2.61.1-2
+- Fix CVE-2019-12450 (#1719142)
+
 * Fri May 24 2019 Kalev Lember <klember@redhat.com> - 2.61.1-1
 - Update to 2.61.1