[rpms/glib2] cve-2026-58016-f44: Backport patches for gmain wakeup for qemu

[rpms/glib2] cve-2026-58016-f44: Backport patches for gmain wakeup for qemu

[Colin Walters]

          A new commit has been pushed.

          Repo   : rpms/glib2
          Branch : cve-2026-58016-f44
          Commit : 05d466c2f3a17a858c689a7b1046e6082860c5d0
          Author : Colin Walters <walters@verbum.org>
          Date   : 2017-04-11T12:06:05-04:00
          Stats  : +138/-1 in 2 file(s)
          URL    : https://src.fedoraproject.org/rpms/glib2/c/05d466c2f3a17a858c689a7b1046e6082860c5d0?branch=cve-2026-58016-f44

          Log:
          Backport patches for gmain wakeup for qemu
See: https://bugzilla.gnome.org/show_bug.cgi?id=761102

---
diff --git a/glib2.spec b/glib2.spec
index a59dbcd..5418749 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -5,13 +5,16 @@
 
 Name: glib2
 Version: 2.52.1
-Release: 2%{?dist}
+Release: 3%{?dist}
 Summary: A library of handy utility functions
 
 License: LGPLv2+
 URL: http://www.gtk.org
 Source0: http://download.gnome.org/sources/glib/2.52/glib-%{version}.tar.xz
 
+# https://bugzilla.gnome.org/show_bug.cgi?id=761102
+Patch0: gmain-wakeup.patch
+
 BuildRequires: chrpath
 BuildRequires: gettext
 BuildRequires: perl-generators
@@ -229,6 +232,10 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
 %{_datadir}/installed-tests
 
 %changelog
+* Tue Apr 11 2017 Colin Walters <walters@verbum.org> - 2.52.1-3
+- Backport patches for gmain wakeup for qemu
+  See: https://bugzilla.gnome.org/show_bug.cgi?id=761102
+
 * Tue Apr 11 2017 Colin Walters <walters@verbum.org> - 2.52.1-2
 - Explictly remove PCRE sources
 - Related: https://bugzilla.redhat.com/show_bug.cgi?id=1324770

diff --git a/gmain-wakeup.patch b/gmain-wakeup.patch
new file mode 100644
index 0000000..f7a3aa6
--- /dev/null
+++ b/gmain-wakeup.patch
@@ -0,0 +1,130 @@
+From d26e8979891d549214c955104529177576cd9de0 Mon Sep 17 00:00:00 2001
+From: Colin Walters <walters@verbum.org>
+Date: Fri, 31 Mar 2017 16:19:58 -0400
+Subject: [PATCH 1/2] main: Create a helper function for "owner wakeup"
+ optimization
+
+The original patch really should have introduced a helper - among
+other things it deserves a code comment.  We're likely to make
+further changes too, so it's obviously better to only do it in one
+place.
+
+See: https://bugzilla.gnome.org/show_bug.cgi?id=761102
+---
+ glib/gmain.c | 28 +++++++++++++++++++---------
+ 1 file changed, 19 insertions(+), 9 deletions(-)
+
+diff --git a/glib/gmain.c b/glib/gmain.c
+index 4f90574..88b57fd 100644
+--- a/glib/gmain.c
++++ b/glib/gmain.c
+@@ -1118,6 +1118,19 @@ source_remove_from_context (GSource      *source,
+     }
+ }
+ 
++/* See https://bugzilla.gnome.org/show_bug.cgi?id=761102 for
++ * the introduction of this.
++ *
++ * The main optimization is to avoid waking up the main
++ * context if a change is made by the current owner.
++ */
++static void
++conditional_wakeup (GMainContext *context)
++{
++  if (context->owner && context->owner != G_THREAD_SELF)
++    g_wakeup_signal (context->wakeup);
++}
++
+ static guint
+ g_source_attach_unlocked (GSource      *source,
+                           GMainContext *context,
+@@ -1164,8 +1177,8 @@ g_source_attach_unlocked (GSource      *source,
+   /* If another thread has acquired the context, wake it up since it
+    * might be in poll() right now.
+    */
+-  if (do_wakeup && context->owner && context->owner != G_THREAD_SELF)
+-    g_wakeup_signal (context->wakeup);
++  if (do_wakeup)
++    conditional_wakeup (context);
+ 
+   return source->source_id;
+ }
+@@ -1839,8 +1852,7 @@ g_source_set_ready_time (GSource *source,
+     {
+       /* Quite likely that we need to change the timeout on the poll */
+       if (!SOURCE_BLOCKED (source))
+-        if (context->owner && context->owner != G_THREAD_SELF)
+-          g_wakeup_signal (context->wakeup);
++        conditional_wakeup (context);
+       UNLOCK_CONTEXT (context);
+     }
+ }
+@@ -4352,8 +4364,7 @@ g_main_context_add_poll_unlocked (GMainContext *context,
+   context->poll_changed = TRUE;
+ 
+   /* Now wake up the main loop if it is waiting in the poll() */
+-  if (context->owner && context->owner != G_THREAD_SELF)
+-    g_wakeup_signal (context->wakeup);
++  conditional_wakeup (context);
+ }
+ 
+ /**
+@@ -4411,10 +4422,9 @@ g_main_context_remove_poll_unlocked (GMainContext *context,
+     }
+ 
+   context->poll_changed = TRUE;
+-  
++
+   /* Now wake up the main loop if it is waiting in the poll() */
+-  if (context->owner && context->owner != G_THREAD_SELF)
+-    g_wakeup_signal (context->wakeup);
++  conditional_wakeup (context);
+ }
+ 
+ /**
+-- 
+2.9.3
+
+
+From c4b3fd1487dad9dece67453cef4954b07dd3bdc1 Mon Sep 17 00:00:00 2001
+From: Paolo Bonzini <bonzini@gnu.org>
+Date: Mon, 3 Apr 2017 13:32:32 -0400
+Subject: [PATCH 2/2] gmain: Signal wakeups if context has never been acquired
+ as well
+
+Should address backwards compatibility with how qemu is using
+`GMainContext`.
+
+See https://bugzilla.gnome.org/show_bug.cgi?id=761102#c14
+
+Input-into-keyboard-by: Colin Walters <walters@verbum.org>
+---
+ glib/gmain.c | 12 +++++++++++-
+ 1 file changed, 11 insertions(+), 1 deletion(-)
+
+diff --git a/glib/gmain.c b/glib/gmain.c
+index 88b57fd..f390c46 100644
+--- a/glib/gmain.c
++++ b/glib/gmain.c
+@@ -1127,7 +1127,17 @@ source_remove_from_context (GSource      *source,
+ static void
+ conditional_wakeup (GMainContext *context)
+ {
+-  if (context->owner && context->owner != G_THREAD_SELF)
++  /* We want to signal wakeups in two cases:
++   *  1 When the context is owned by another thread
++   *  2 When the context owner is NULL (two subcases)
++   *   2a Possible if the context has never been acquired
++   *   2b Or if the context has no current owner
++   *
++   * At least case 2a) is necessary to ensure backwards compatibility with
++   * qemu's use of GMainContext.
++   * https://bugzilla.gnome.org/show_bug.cgi?id=761102#c14
++   */
++  if (context->owner != G_THREAD_SELF)
+     g_wakeup_signal (context->wakeup);
+ }
+ 
+-- 
+2.9.3
+