[rpms/glib2] cve-2026-58016-f44: Fix banshee getting selected as the default movie player

[rpms/glib2] cve-2026-58016-f44: Fix banshee getting selected as the default movie player

[Bastien Nocera]

A new commit has been pushed.

Repo   : rpms/glib2
Branch : cve-2026-58016-f44
Commit : 1759e582c50e094a9d2abddb3e2d5daa6e2965d9
Author : Bastien Nocera <hadess@hadess.net>
Date   : 2014-09-04T19:57:15+02:00
Stats  : +40/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/glib2/c/1759e582c50e094a9d2abddb3e2d5daa6e2965d9?branch=cve-2026-58016-f44

Log:
Fix banshee getting selected as the default movie player

---
diff --git a/broken-default-apps.patch b/broken-default-apps.patch
new file mode 100644
index 0000000..db4df1e
--- /dev/null
+++ b/broken-default-apps.patch
@@ -0,0 +1,33 @@
+From 450fea253095c7dd8a6293af8f86ea9b81ad46b2 Mon Sep 17 00:00:00 2001
+From: Ryan Lortie <desrt@desrt.ca>
+Date: Thu, 4 Sep 2014 13:17:27 -0400
+Subject: [PATCH] GDesktopAppInfo: fix default app logic
+
+We use "tweaks" structures to track how a particular directory impacts
+the list of added, removed and default applications.  We maintain this
+set of tweaks for each directory, in a hash table, keyed by unaliased
+mime type name, in order to facilitate fast lookups.
+
+A typo in the logic for creating and maintaining the uniqueness of these
+structures was causing the default app to be selected incorrectly from
+time to time.  Fix that.
+---
+ gio/gdesktopappinfo.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gio/gdesktopappinfo.c b/gio/gdesktopappinfo.c
+index 1d38d4a..ddec690 100644
+--- a/gio/gdesktopappinfo.c
++++ b/gio/gdesktopappinfo.c
+@@ -641,7 +641,7 @@ desktop_file_dir_unindexed_get_tweaks (DesktopFileDir *dir,
+   gchar *unaliased_type;
+ 
+   unaliased_type = _g_unix_content_type_unalias (mime_type);
+-  tweaks = g_hash_table_lookup (dir->mime_tweaks, mime_type);
++  tweaks = g_hash_table_lookup (dir->mime_tweaks, unaliased_type);
+ 
+   if (tweaks == NULL)
+     {
+-- 
+1.9.3
+

diff --git a/glib2.spec b/glib2.spec
index e204701..f6957cb 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -3,7 +3,7 @@
 Summary: A library of handy utility functions
 Name: glib2
 Version: 2.41.4
-Release: 1%{?dist}
+Release: 2%{?dist}
 License: LGPLv2+
 Group: System Environment/Libraries
 URL: http://www.gtk.org
@@ -30,6 +30,8 @@ BuildRequires: chrpath
 # required for GIO content-type support
 Requires: shared-mime-info
 
+Patch0: broken-default-apps.patch
+
 %description
 GLib is the low-level core library that forms the basis for projects
 such as GTK+ and GNOME. It provides data structure handling for C,
@@ -81,6 +83,7 @@ the functionality of the installed glib2 package.
 
 %prep
 %setup -q -n glib-%{version}
+%patch0 -p1
 
 %build
 # Support builds of both git snapshots and tarballs packed with autogoo
@@ -219,6 +222,9 @@ gio-querymodules-%{__isa_bits} %{_libdir}/gio/modules
 %{_datadir}/installed-tests
 
 %changelog
+* Thu Sep 04 2014 Bastien Nocera <bnocera@redhat.com> 2.41.4-2
+- Fix banshee getting selected as the default movie player
+
 * Tue Sep 02 2014 Kalev Lember <kalevlember@gmail.com> - 2.41.4-1
 - Update to 2.41.4