[rpms/fedora-release] f45: Enable rpm-ostree repo-refresh for all active local users

[rpms/fedora-release] f45: Enable rpm-ostree repo-refresh for all active local users

[Allison Karlitskaya]

            A new commit has been pushed.

            Repo   : rpms/fedora-release
            Branch : f45
            Commit : 55758b13ffbe79c3edddb5ba644fddd194fa7617
            Author : Allison Karlitskaya <allison.karlitskaya@redhat.com>
            Date   : 2021-01-19T05:58:27+01:00
            Stats  : +10/-2 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/fedora-release/c/55758b13ffbe79c3edddb5ba644fddd194fa7617?branch=f45

            Log:
            Enable rpm-ostree repo-refresh for all active local users

gnome-software attempts to refresh the rpm-ostree repository in order to check
if updates are available, in order to notify the user.  This happens
regularly in the bakground, including when the the settings for
automatic download and installation of updates are disabled.

The refresh requires the org.projectatomic.rpmostree1.repo-refresh
polkit action to be permitted, which is currently only the case for
users in the wheel group who are logged in locally.

The result is that logging in to a normal user account (ie: not in
'wheel') results in a polkit dialog immediately being presented, and
then at regular intervals thereafter.

Because a simple refresh is a fairly harmless operation, and because
knowing about the availability of updates is useful, allow it for all
users who are logged in locally.

---
diff --git a/fedora-release.spec b/fedora-release.spec
index ca3a0e3..aed1b78 100644
--- a/fedora-release.spec
+++ b/fedora-release.spec
@@ -50,7 +50,7 @@
 Summary:        Fedora release files
 Name:           fedora-release
 Version:        34
-Release:        0.10%{?eln:.eln%{eln}}
+Release:        0.11%{?eln:.eln%{eln}}
 License:        MIT
 URL:            https://fedoraproject.org/
 
@@ -1216,6 +1216,10 @@ ln -s %{_swidtagdir} %{buildroot}%{_sysconfdir}/swid/swidtags.d/fedoraproject.or
 
 
 %changelog
+* Tue Jan 19 2021 Allison Karlitskaya <allison.karlitskaya@redhat.com> - 34-0.11
+- Enable rpm-ostree repo-refresh for all active local users
+- https://github.com/fedora-silverblue/issue-tracker/issues/55
+
 * Tue Dec 15 2020 Mohan Boddu <mboddu@bhujji.com> - 34-0.10
 - Enable pipewire-pulse socket-activated user service (ngompa)
 - Fixing changelog

diff --git a/org.projectatomic.rpmostree1.rules b/org.projectatomic.rpmostree1.rules
index 75ae406..ec13edb 100644
--- a/org.projectatomic.rpmostree1.rules
+++ b/org.projectatomic.rpmostree1.rules
@@ -1,4 +1,9 @@
 polkit.addRule(function(action, subject) {
+    if (action.id == "org.projectatomic.rpmostree1.repo-refresh" &&
+        subject.active == true && subject.local == true) {
+            return polkit.Result.YES;
+    }
+
     if ((action.id == "org.projectatomic.rpmostree1.install-uninstall-packages" ||
          action.id == "org.projectatomic.rpmostree1.install-local-packages" ||
          action.id == "org.projectatomic.rpmostree1.override" ||
@@ -10,7 +15,6 @@ polkit.addRule(function(action, subject) {
          action.id == "org.projectatomic.rpmostree1.reload-daemon" ||
          action.id == "org.projectatomic.rpmostree1.cancel" ||
          action.id == "org.projectatomic.rpmostree1.cleanup" ||
-         action.id == "org.projectatomic.rpmostree1.repo-refresh" ||
          action.id == "org.projectatomic.rpmostree1.client-management") &&
         subject.active == true &&
         subject.local == true &&