public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/chromium] epel9-next: - Update to 143.0.7499.109
@ 2026-08-07 16:08 Than Ngo
  0 siblings, 0 replies; only message in thread
From: Than Ngo @ 2026-08-07 16:08 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/chromium
            Branch : epel9-next
            Commit : 6196c5742999b91e3dedf1a6038616ecd0e78e46
            Author : Than Ngo <than@redhat.com>
            Date   : 2025-12-11T10:08:45+01:00
            Stats  : +40/-149 in 4 file(s)
            URL    : https://src.fedoraproject.org/rpms/chromium/c/6196c5742999b91e3dedf1a6038616ecd0e78e46?branch=epel9-next

            Log:
            - Update to 143.0.7499.109
  * High: Under coordination
  * Medium CVE-2025-14372: Use after free in Password Manager
  * Medium CVE-2025-14373: Inappropriate implementation in Toolbar
- Workaround problem of auto dark mode inverting images and making them unreadable

---
diff --git a/chromium-141-revert-remove-darkmode-image-policy.patch b/chromium-141-revert-remove-darkmode-image-policy.patch
deleted file mode 100644
index 45891d5..0000000
--- a/chromium-141-revert-remove-darkmode-image-policy.patch
+++ /dev/null
@@ -1,145 +0,0 @@
-Revert it due to incorrect display of links on startpage
-
-commit 8e24867a503c142393388f117df94bb9b7c4b597
-Author: Prashant Nevase <pnevase@microsoft.com>
-Date:   Mon Aug 18 10:26:18 2025 -0700
-
-    Remove dark mode kFilterNone image policy.
-    
-    This cl removes DarkModeImagePolicy::kFilterNone and virtual tests
-    related to it. DarkModeImagePolicy::kFilterSmart is used as default.
-    
-    Bug: 429404798
-    Change-Id: I5983aa8bca9ed4da110130f8bc49a184c7d339dc
-    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6810968
-    Commit-Queue: Prashant Nevase <pnevase@microsoft.com>
-    Reviewed-by: Philip Rogers <pdr@chromium.org>
-    Cr-Commit-Position: refs/heads/main@{#1502799}
-
-diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
-index d4ed3585d95..62f30a3103c 100644
---- a/chrome/browser/about_flags.cc
-+++ b/chrome/browser/about_flags.cc
-@@ -813,19 +813,16 @@ const FeatureEntry::Choice kSafetyHubUnifiedPasswordsModuleChoices[] = {
- #if !BUILDFLAG(IS_CHROMEOS)
- const FeatureEntry::FeatureParam kForceDark_SimpleHsl[] = {
-     {"inversion_method", "hsl_based"},
--    {"image_behavior", "none"},
-     {"foreground_lightness_threshold", "150"},
-     {"background_lightness_threshold", "205"}};
- 
- const FeatureEntry::FeatureParam kForceDark_SimpleCielab[] = {
-     {"inversion_method", "cielab_based"},
--    {"image_behavior", "none"},
-     {"foreground_lightness_threshold", "150"},
-     {"background_lightness_threshold", "205"}};
- 
- const FeatureEntry::FeatureParam kForceDark_SimpleRgb[] = {
-     {"inversion_method", "rgb_based"},
--    {"image_behavior", "none"},
-     {"foreground_lightness_threshold", "150"},
-     {"background_lightness_threshold", "205"}};
- 
-@@ -839,7 +836,6 @@ const FeatureEntry::FeatureParam kForceDark_SelectiveImageInversion[] = {
- 
- const FeatureEntry::FeatureParam kForceDark_SelectiveElementInversion[] = {
-     {"inversion_method", "cielab_based"},
--    {"image_behavior", "none"},
-     {"foreground_lightness_threshold", "150"},
-     {"background_lightness_threshold", "205"}};
- 
-diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc
-index 14409e52162..0af032f4dbf 100644
---- a/third_party/blink/common/features.cc
-+++ b/third_party/blink/common/features.cc
-@@ -1036,7 +1036,6 @@ const base::FeatureParam<ForceDarkImageBehavior>::Option
-     forcedark_image_behavior_options[] = {
-         {ForceDarkImageBehavior::kUseBlinkSettings,
-          "use_blink_settings_for_images"},
--        {ForceDarkImageBehavior::kInvertNone, "none"},
-         {ForceDarkImageBehavior::kInvertSelectively, "selective"}};
- 
- BASE_FEATURE_ENUM_PARAM(ForceDarkImageBehavior,
-diff --git a/third_party/blink/public/common/forcedark/forcedark_switches.h b/third_party/blink/public/common/forcedark/forcedark_switches.h
-index 9661628ce5c..ad606effc28 100644
---- a/third_party/blink/public/common/forcedark/forcedark_switches.h
-+++ b/third_party/blink/public/common/forcedark/forcedark_switches.h
-@@ -31,9 +31,6 @@ enum class ForceDarkImageBehavior {
-   // Same as ForceDarkInversionMethod::kUseBlinkSettings above.
-   kUseBlinkSettings,
- 
--  // Do not invert any images.
--  kInvertNone,
--
-   // Invert only some images. Images that act as icons or text should be
-   // inverted, but photos, avatars, etc. should not be.
-   kInvertSelectively
-diff --git a/third_party/blink/renderer/platform/graphics/dark_mode_filter.cc b/third_party/blink/renderer/platform/graphics/dark_mode_filter.cc
-index 1929af787b7..7cb0924924a 100644
---- a/third_party/blink/renderer/platform/graphics/dark_mode_filter.cc
-+++ b/third_party/blink/renderer/platform/graphics/dark_mode_filter.cc
-@@ -205,7 +205,6 @@ void DarkModeFilter::ApplyFilterToImage(Image* image,
-                                         const SkRect& src) {
-   DCHECK(image);
-   DCHECK(flags);
--  DCHECK_NE(GetDarkModeImagePolicy(), DarkModeImagePolicy::kFilterNone);
- 
-   // Raster-side dark mode path - Just set the dark mode on flags and dark
-   // mode will be applied at compositor side during rasterization.
-@@ -224,10 +223,6 @@ void DarkModeFilter::ApplyFilterToImage(Image* image,
- }
- 
- bool DarkModeFilter::ShouldApplyFilterToImage(ImageType type) const {
--  DarkModeImagePolicy image_policy = GetDarkModeImagePolicy();
--  if (image_policy == DarkModeImagePolicy::kFilterNone)
--    return false;
--
-   // kIcon: Do not consider images being drawn into bigger rect as these
-   // images are not meant for icons or representing smaller widgets. These
-   // images are considered as photos which should be untouched.
-@@ -241,7 +236,6 @@ bool DarkModeFilter::ShouldApplyFilterToImage(ImageType type) const {
- sk_sp<cc::ColorFilter> DarkModeFilter::GenerateImageFilter(
-     const SkPixmap& pixmap,
-     const SkIRect& src) const {
--  DCHECK(immutable_.settings.image_policy == DarkModeImagePolicy::kFilterSmart);
-   DCHECK(immutable_.image_filter);
- 
-   return (immutable_.image_classifier->Classify(pixmap, src) ==
-diff --git a/third_party/blink/renderer/platform/graphics/dark_mode_settings.h b/third_party/blink/renderer/platform/graphics/dark_mode_settings.h
-index 19b3796f457..bce2653148a 100644
---- a/third_party/blink/renderer/platform/graphics/dark_mode_settings.h
-+++ b/third_party/blink/renderer/platform/graphics/dark_mode_settings.h
-@@ -21,10 +21,9 @@ enum class DarkModeInversionAlgorithm {
- // This enum will be removed soon to make dark mode simpler.
- enum class DarkModeImagePolicy {
-   kFilterSmart,  // Apply dark-mode based on image content.
--  kFilterNone,   // Never apply dark-mode filter to any images.
- 
-   kFirst = kFilterSmart,  // First enum value.
--  kLast = kFilterNone,    // Last enum value.
-+  kLast = kFilterSmart,   // Last enum value.
- };
- 
- enum class DarkModeImageClassifierPolicy {
-@@ -45,7 +44,7 @@ struct DarkModeSettings {
-   DarkModeInversionAlgorithm mode =
-       DarkModeInversionAlgorithm::kInvertLightnessLAB;
-   float contrast = 0.0;                 // Valid range from -1.0 to 1.0
--  DarkModeImagePolicy image_policy = DarkModeImagePolicy::kFilterNone;
-+  DarkModeImagePolicy image_policy = DarkModeImagePolicy::kFilterSmart;
-   DarkModeImageClassifierPolicy image_classifier_policy =
-       DarkModeImageClassifierPolicy::kNumColorsWithMlFallback;
- 
-diff --git a/third_party/blink/renderer/platform/graphics/dark_mode_settings_builder.cc b/third_party/blink/renderer/platform/graphics/dark_mode_settings_builder.cc
-index 61498c0a809..318652cb2f2 100644
---- a/third_party/blink/renderer/platform/graphics/dark_mode_settings_builder.cc
-+++ b/third_party/blink/renderer/platform/graphics/dark_mode_settings_builder.cc
-@@ -115,8 +115,6 @@ DarkModeImagePolicy GetImagePolicy(const SwitchParams& switch_params) {
-     case ForceDarkImageBehavior::kUseBlinkSettings:
-       return GetIntegerSwitchParamValue<DarkModeImagePolicy>(
-           switch_params, "ImagePolicy", kDefaultDarkModeImagePolicy);
--    case ForceDarkImageBehavior::kInvertNone:
--      return DarkModeImagePolicy::kFilterNone;
-     case ForceDarkImageBehavior::kInvertSelectively:
-       return DarkModeImagePolicy::kFilterSmart;
-   }

diff --git a/chromium-143-autodarkmode-workaround.patch b/chromium-143-autodarkmode-workaround.patch
new file mode 100644
index 0000000..5bd4f87
--- /dev/null
+++ b/chromium-143-autodarkmode-workaround.patch
@@ -0,0 +1,26 @@
+Workaround auto darkmode issue, image are not inverted correctly in darkmode
+
+diff -up chromium-143.0.7499.40/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc.than chromium-143.0.7499.40/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc
+--- chromium-143.0.7499.40/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc.than	2025-12-09 12:28:52.592092242 +0100
++++ chromium-143.0.7499.40/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc	2025-12-09 12:42:57.776716951 +0100
+@@ -276,16 +276,20 @@ DarkModeResult DarkModeImageClassifier::
+   float high_color_count_threshold =
+       kHighColorCountThreshold[features.is_colorful];
+ 
++#if 0
+   // Very few colors means it's not a photo, apply the filter.
+   if (features.color_buckets_ratio < low_color_count_threshold)
+     return DarkModeResult::kApplyFilter;
++#endif
+ 
+   // Too many colors means it's probably photorealistic, do not apply it.
+   if (features.color_buckets_ratio > high_color_count_threshold)
+     return DarkModeResult::kDoNotApplyFilter;
+ 
++#if 0
+   // In-between, decision tree cannot give a precise result.
+   return DarkModeResult::kNotClassified;
++#endif
+ }
+ 
+ }  // namespace blink

diff --git a/chromium.spec b/chromium.spec
index b7a26c3..987331a 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -248,8 +248,8 @@
 %endif
 
 Name:	chromium
-Version: 143.0.7499.40
-Release: 2%{?dist}
+Version: 143.0.7499.109
+Release: 1%{?dist}
 Summary: A WebKit (Blink) powered web browser that Google doesn't want you to use
 Url: http://www.chromium.org/Home
 License: BSD-3-Clause AND LGPL-2.1-or-later AND Apache-2.0 AND IJG AND MIT AND GPL-2.0-or-later AND ISC AND OpenSSL AND (MPL-1.1 OR GPL-2.0-only OR LGPL-2.0-only)
@@ -274,6 +274,9 @@ Patch22: chromium-131-fix-qt-ui.pach
 #  needs //third_party/libpng:libpng_for_testonly(//build/toolchain/linux/unbundle:default)
 Patch23: chromium-143-revert-libpng_for_testonly.patch
 
+# Get around the problem of auto darkmode webcontent inverting and making them unreadable
+Patch30: chromium-143-autodarkmode-workaround.patch
+
 # Disable tests on remoting build
 Patch82: chromium-98.0.4758.102-remoting-no-tests.patch
 
@@ -995,7 +998,7 @@ Qt6 UI for chromium.
 %endif
 
 %patch -P23 -p1 -R -b .revert-libpng_for_testonly
-
+%patch -P30 -p1 -b .autodarkmode-workaround
 %patch -P82 -p1 -b .remoting-no-tests
 
 %if ! %{bundlebrotli}
@@ -1780,6 +1783,13 @@ fi
 %endif
 
 %changelog
+* Thu Dec 11 2025 Than Ngo <than@redhat.com> - 143.0.7499.109-1
+- Update to 143.0.7499.109
+  * High: Under coordination
+  * Medium CVE-2025-14372: Use after free in Password Manager
+  * Medium CVE-2025-14373: Inappropriate implementation in Toolbar
+- Workaround problem of auto dark mode inverting images and making them unreadable
+
 * Tue Dec 09 2025 LuK1337 <priv.luk@gmail.com> - 143.0.7499.40-2
 - Backport Wayland Omnibox bug fix from upstream
 

diff --git a/sources b/sources
index f3053ba..d53ee0f 100644
--- a/sources
+++ b/sources
@@ -1,2 +1,2 @@
 SHA512 (node-v22.14.0-stripped.tar.gz) = affddb541009c6d378049c2d7845b981335d9e7aa387efcc472e5efb621c345cd58ca69778a394f7e4ebbb5e4b1a115a389838ef1b6458ef5e98f2071b166e15
-SHA512 (chromium-143.0.7499.40-clean.tar.xz) = 482721d372000d05a3e86c91f231c5ee206389890a19ad210e99de1ed86ccbb4dd155f461f98daf8648b6c9a6eeec3c9b4ae17e192bd816ead561a77174bd00c
+SHA512 (chromium-143.0.7499.109-clean.tar.xz) = 353e4334516821ac491c01d4104c469ba280d3acf6d11dd1c44db0f7baad4127bbbb7c60fd750e9d6e931b311f2ee52e0fb9760bbb2e04d9b90925c0f48daab4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-07 16:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-07 16:08 [rpms/chromium] epel9-next: - Update to 143.0.7499.109 Than Ngo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox