public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/chromium] epel9-next: Backport Wayland Omnibox bug fix from upstream
@ 2026-08-07 16:08 LuK1337
  0 siblings, 0 replies; only message in thread
From: LuK1337 @ 2026-08-07 16:08 UTC (permalink / raw)
  To: git-commits

A new commit has been pushed.

Repo   : rpms/chromium
Branch : epel9-next
Commit : 538383ec0040335d67647a1affba04afc73a520a
Author : LuK1337 <priv.luk@gmail.com>
Date   : 2025-12-09T18:28:09+01:00
Stats  : +101/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/chromium/c/538383ec0040335d67647a1affba04afc73a520a?branch=epel9-next

Log:
Backport Wayland Omnibox bug fix from upstream

---
diff --git a/chromium-143-omnibox-next-Improve-cutout-mouse-handling-for-Wayla.patch b/chromium-143-omnibox-next-Improve-cutout-mouse-handling-for-Wayla.patch
new file mode 100644
index 0000000..0f4b452
--- /dev/null
+++ b/chromium-143-omnibox-next-Improve-cutout-mouse-handling-for-Wayla.patch
@@ -0,0 +1,94 @@
+From 88e4cfe5112964f9ee82926539821790c1041832 Mon Sep 17 00:00:00 2001
+From: Aviv Kiss <avivkiss@google.com>
+Date: Tue, 09 Dec 2025 09:27:11 -0800
+Subject: [PATCH] [omnibox][next] Improve cutout mouse handling for Wayland users.
+
+Partial revert of https://crrev.com/c/7151889 maintaining
+`forward_mouse_events_` while reverting the event/lifecycle changes that
+caused b:465871759.
+
+https://crrev.com/c/7151889 introduced a bug impacting Linux users with
+Wayland windowing that results in the Omnibox ignoring click events.
+Weirdly this bug doesn't seem to reproduce when the WebUI dropdown popup
+is enabled although I'm not sure why.
+
+Keren explains why this bug is happening in
+https://crrev.com/c/7240486/6/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc#b373
+on this change. Keren also suggested a simpler version of this fix that
+is the version of this change that is submitted. The suggestion is to
+revert back to the state prior to https://crrev.com/c/7151889 while
+maintaining the `forward_mouse_events_` bool that allows the composebox
+to opt out of forwarding.
+
+While drafting https://crrev.com/c/7151889 I recall testing this
+approach and composebox mouse events being forwarded to the Omnibox
+anyways. Either I didn't test what I thought I tested or perhaps I ran
+into a build caching issue with Cider/Cog/Chrome. Since this seems to
+work now I've updated the change to use the simpler approach.
+
+Bug: b:465871759
+Change-Id: Ib1ebc2ef5cb6d3bd6a00be5b59eb4b635d30c531
+Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7240486
+Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
+Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
+Auto-Submit: Aviv Kiss <avivkiss@google.com>
+Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
+Cr-Commit-Position: refs/heads/main@{#1556206}
+---
+
+diff --git a/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc b/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
+index 119d5fd..feb71623 100644
+--- a/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
++++ b/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
+@@ -17,7 +17,6 @@
+ #include "chrome/browser/ui/views/frame/browser_view.h"
+ #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
+ #include "chrome/browser/ui/views/omnibox/omnibox_aim_popup_webui_content.h"
+-#include "components/omnibox/common/omnibox_features.h"
+ #include "ui/base/cursor/cursor.h"
+ #include "ui/base/metadata/metadata_header_macros.h"
+ #include "ui/base/metadata/metadata_impl_macros.h"
+@@ -356,24 +355,16 @@
+   contents_->SetBoundsRect(results_bounds);
+ }
+ 
+-void RoundedOmniboxResultsFrame::VisibilityChanged(View* starting_from,
+-                                                   bool is_visible) {
+-  views::View::VisibilityChanged(starting_from, is_visible);
++void RoundedOmniboxResultsFrame::AddedToWidget() {
+ #if defined(USE_AURA)
+   if (!forward_mouse_events_) {
+     return;
+   }
+-
+-  if (is_visible) {
+-    // Use a ui::EventTargeter that allows mouse and touch events in the top
+-    // portion of the Widget to pass through to the omnibox beneath it.
+-    auto results_targeter = std::make_unique<aura::WindowTargeter>();
+-    results_targeter->SetInsets(GetContentInsets());
+-    GetWidget()->GetNativeWindow()->SetEventTargeter(
+-        std::move(results_targeter));
+-  } else {
+-    GetWidget()->GetNativeWindow()->SetEventTargeter(nullptr);
+-  }
++  // Use a ui::EventTargeter that allows mouse and touch events in the top
++  // portion of the Widget to pass through to the omnibox beneath it.
++  auto results_targeter = std::make_unique<aura::WindowTargeter>();
++  results_targeter->SetInsets(GetContentInsets());
++  GetWidget()->GetNativeWindow()->SetEventTargeter(std::move(results_targeter));
+ #endif  // USE_AURA
+ }
+ 
+diff --git a/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h b/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h
+index d83435dc..529703f 100644
+--- a/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h
++++ b/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h
+@@ -51,7 +51,7 @@
+ 
+   // views::View:
+   void Layout(PassKey) override;
+-  void VisibilityChanged(View* starting_from, bool is_visible) override;
++  void AddedToWidget() override;
+ #if !defined(USE_AURA)
+   void OnMouseMoved(const ui::MouseEvent& event) override;
+   void OnMouseEvent(ui::MouseEvent* event) override;

diff --git a/chromium.spec b/chromium.spec
index af92db3..b7a26c3 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -249,7 +249,7 @@
 
 Name:	chromium
 Version: 143.0.7499.40
-Release: 1%{?dist}
+Release: 2%{?dist}
 Summary: A WebKit (Blink) powered web browser that Google doesn't want you to use
 Url: http://www.chromium.org/Home
 License: BSD-3-Clause AND LGPL-2.1-or-later AND Apache-2.0 AND IJG AND MIT AND GPL-2.0-or-later AND ISC AND OpenSSL AND (MPL-1.1 OR GPL-2.0-only OR LGPL-2.0-only)
@@ -470,6 +470,8 @@ Patch511: 0002-Fix-Missing-OPENSSL_NO_ENGINE-Guard.patch
 # Fix Wayland URI DnD issues
 Patch1001: chromium-142-Add-ExtractData-support-for-text-uri-list.patch
 Patch1002: chromium-142-Update-pointer-position-during-draggin.patch
+# Fix Wayland Omnibox issue
+Patch1003: chromium-143-omnibox-next-Improve-cutout-mouse-handling-for-Wayla.patch
 
 # Use chromium-latest.py to generate clean tarball from released build tarballs, found here:
 # http://build.chromium.org/buildbot/official/
@@ -1140,6 +1142,7 @@ Qt6 UI for chromium.
 # Upstream patches
 %patch -P1001 -p1 -b .Add-ExtractData-support-for-text-uri-list.patch
 %patch -P1002 -p1 -b .Update-pointer-position-during-draggin.patch
+%patch -P1003 -p1 -b .Improve-cutout-mouse-handling-for-Wayla.patch
 
 # Change shebang in all relevant files in this directory and all subdirectories
 # See `man find` for how the `-exec command {} +` syntax works
@@ -1777,6 +1780,9 @@ fi
 %endif
 
 %changelog
+* Tue Dec 09 2025 LuK1337 <priv.luk@gmail.com> - 143.0.7499.40-2
+- Backport Wayland Omnibox bug fix from upstream
+
 * Tue Dec 02 2025 Than Ngo <than@redhat.com> - 143.0.7499.40-1
 - Update to 143.0.7499.40
   * High CVE-2025-13630: Type Confusion in V8

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-07 16:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-07 16:08 [rpms/chromium] epel9-next: Backport Wayland Omnibox bug fix from upstream LuK1337

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox