public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/chromium] epel9-next: * Fix FTBFS - ld.lld: error: unable to find library -latomic
@ 2026-08-07 16:07 Than Ngo
  0 siblings, 0 replies; only message in thread
From: Than Ngo @ 2026-08-07 16:07 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/chromium
            Branch : epel9-next
            Commit : c183b6d1001297f84aa6e3342488a29c5e4410c9
            Author : Than Ngo <than@redhat.com>
            Date   : 2025-05-16T23:46:39+02:00
            Stats  : +6/-31 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/chromium/c/c183b6d1001297f84aa6e3342488a29c5e4410c9?branch=epel9-next

            Log:
            * Fix FTBFS - ld.lld: error: unable to find library -latomic
  Add BR gcc-toolset-14-libatomic-devel for clang-19.x on el9 to fix FTBFS

  ld.lld: error: unable to find library -latomic

* Fix condition for el8 build due to old clang/rust

---
diff --git a/chromium-136-el9-bindgen-cli-build-error.patch b/chromium-136-el9-bindgen-cli-build-error.patch
deleted file mode 100644
index caa196e..0000000
--- a/chromium-136-el9-bindgen-cli-build-error.patch
+++ /dev/null
@@ -1,22 +0,0 @@
-bindgen generates rust codes that cannot be compiled with rust-1.79.0 on EPEL9
-  https://github.com/rust-lang/rust-bindgen/issues/3052
-
-Add Workaround for this build error on el9
-
-error: extern block cannot be declared unsafe
- --> ../../third_party/crabbyavif/src/sys/dav1d-sys/src/../../../../../../out/Release/gen/third_party/crabbyavif/crabbyavif_dav1d_sys/dav1d_bindgen.rs:3:18605
-
-Signed-off-by: Than Ngo <than@redhat.com>
-
-diff -up chromium-136.0.7103.92/build/rust/run_bindgen.py.than chromium-136.0.7103.92/build/rust/run_bindgen.py
---- chromium-136.0.7103.92/build/rust/run_bindgen.py.than	2025-05-08 14:09:50.268246973 +0200
-+++ chromium-136.0.7103.92/build/rust/run_bindgen.py	2025-05-08 14:46:22.421719175 +0200
-@@ -68,7 +68,7 @@ def main():
-     # TODO(danakj): We need to point bindgen to
-     # //third_party/rust-toolchain/bin/rustfmt.
-     genargs.append('--no-rustfmt-bindings')
--    genargs += ['--rust-target', 'nightly']
-+    genargs += ['--rust-target', '1.79']
- 
-     if args.depfile:
-       depfile = stack.enter_context(action_helpers.atomic_output(args.depfile))

diff --git a/chromium.spec b/chromium.spec
index af19149..e23b58f 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -290,9 +290,6 @@ Patch91: chromium-108-system-opus.patch
 # patch for Failed NodeJS version check
 Patch92: chromium-136-checkversion-nodejs.patch
 
-# Fix FTBFS caused by bindgen-cli-0.71, rust-1.79.0 on EL9
-Patch93: chromium-136-el9-bindgen-cli-build-error.patch
-
 # system ffmpeg
 # need for old ffmpeg 5.x on epel9
 Patch129: chromium-125-ffmpeg-5.x-reordered_opaque.patch
@@ -324,7 +321,7 @@ Patch306: chromium-127-el8-ifunc-header.patch
 
 # workaround for build error due to old atk version on el8
 Patch307: chromium-134-el8-atk-compiler-error.patch
-# Fix build errors due to old clang18 in el 8/9 and f40
+# Fix build errors due to old clang18 in el8
 Patch308: chromium-136-unsupport-clang-flags.patch
 Patch309: chromium-132-el8-unsupport-rustc-flags.patch
 Patch310: chromium-132-el8-clang18-build-error.patch
@@ -336,7 +333,8 @@ Patch312: chromium-123-fstack-protector-strong.patch
 # build error stdarch_arm_crc32
 Patch313: chromium-133-rust-crc32fast.patch
 
-# build error error[E0599]: no method named `is_none_or` found for enum `Option` in the current scope
+# old rust version causes build error on el8:
+# error[E0599]: no method named `is_none_or` found for enum `Option` in the current scope
 Patch314: chromium-136-rust-skrifa-build-error.patch
 
 # build error: libadler2 not found, rust-1.86 or newer replaces adler with adler2
@@ -503,7 +501,7 @@ BuildRequires: llvm
 BuildRequires: lld
 
 %if 0%{?rhel} && 0%{?rhel} <= 9
-BuildRequires: gcc-toolset-13-libatomic-devel
+BuildRequires: gcc-toolset-14-libatomic-devel
 %endif
 
 BuildRequires: rustc
@@ -1012,7 +1010,6 @@ Qt6 UI for chromium.
 %endif
 
 %patch -P92 -p1 -b .nodejs-checkversion
-%patch -P93 -p1 -b .bindgen-cli-build-error
 
 %if ! %{bundleffmpegfree}
 %if 0%{?rhel} == 9
@@ -1043,7 +1040,7 @@ Qt6 UI for chromium.
 %endif
 %patch -P307 -p1 -b .el8-atk-compiler-error
 %endif
-%if 0%{?rhel} == 8 || 0%{?rhel} == 9 || 0%{?fedora} == 40
+%if 0%{?rhel} == 8
 %patch -P308 -p1 -b .unsupport-clang-flags
 %patch -P309 -p1 -b .el8-unsupport-rustc-flags
 %patch -P310 -p1 -b .el8-clang18-build-error
@@ -1061,7 +1058,7 @@ Qt6 UI for chromium.
 %endif
 %endif
 
-%if 0%{?rhel} == 8 || 0%{?rhel} == 9 || 0%{?fedora} == 40
+%if 0%{?rhel} == 8
 %patch -P314 -p1 -b .rust-skrifa-build-error
 %endif
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-07 16:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-07 16:07 [rpms/chromium] epel9-next: * Fix FTBFS - ld.lld: error: unable to find library -latomic Than Ngo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox