[rpms/abrt] update-2.17.9-f44: fixed crash function detection

[rpms/abrt] update-2.17.9-f44: fixed crash function detection

[@ 2026-08-03 11:03 UTC (permalink / raw)]

A new commit has been pushed.

Repo   : rpms/abrt
Branch : update-2.17.9-f44
Commit : 6b692ce5426f035a8b0ff3d3bdd2ca46695916cd
Author : Karel Klíč <kklic@fedoraproject.org>
Date   : 2010-04-30T08:28:35+00:00
Stats  : +34/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/abrt/c/6b692ce5426f035a8b0ff3d3bdd2ca46695916cd?branch=update-2.17.9-f44

Log:
fixed crash function detection

---
diff --git a/abrt-1.0.9-crash-function-detect.patch b/abrt-1.0.9-crash-function-detect.patch
new file mode 100644
index 0000000..0b5667a
--- /dev/null
+++ b/abrt-1.0.9-crash-function-detect.patch
@@ -0,0 +1,28 @@
+commit f05c9b25335c84c7b5861fce80fd941ec81212f3
+Author: Karel Klic <kklic@redhat.com>
+Date:   Thu Apr 15 12:12:59 2010 +0200
+
+    Crash function is now detected even for threads without an abort frame.
+
+diff --git a/lib/Plugins/CCpp.cpp b/lib/Plugins/CCpp.cpp
+index 9bdcda9..cf25c73 100644
+--- a/lib/Plugins/CCpp.cpp
++++ b/lib/Plugins/CCpp.cpp
+@@ -761,13 +761,12 @@ void CAnalyzerCCpp::CreateReport(const char *pDebugDumpDir, int force)
+         /* Get the function name from the crash frame. */
+         if (crash_thread)
+         {
++            struct frame *crash_frame = crash_thread->frames;
+             struct frame *abort_frame = thread_find_abort_frame(crash_thread);
+             if (abort_frame)
+-            {
+-                struct frame *crash_frame = abort_frame->next;
+-                if (crash_frame && crash_frame->function && 0 != strcmp(crash_frame->function, "??"))
+-                    dd.SaveText(FILENAME_CRASH_FUNCTION, crash_frame->function);
+-            }
++                crash_frame = abort_frame->next;
++            if (crash_frame && crash_frame->function && 0 != strcmp(crash_frame->function, "??"))
++                dd.SaveText(FILENAME_CRASH_FUNCTION, crash_frame->function);
+         }
+ 
+         backtrace_free(backtrace);

diff --git a/abrt.spec b/abrt.spec
index 7d22840..8c802c0 100644
--- a/abrt.spec
+++ b/abrt.spec
@@ -11,7 +11,7 @@
 %if 0%{?_buildid}
 %define pkg_release 0.%{?_buildid}%{?dist}
 %else
-%define pkg_release 2%{?dist}
+%define pkg_release 3%{?dist}
 %endif
 
 Summary: Automatic bug detection and reporting tool
@@ -27,6 +27,7 @@ Patch0: abrt-1.0.9-hideprefs.patch
 Patch1: abrt-localizedyum.patch
 Patch2: abrt-1.0.9-better-bz-summary.patch
 Patch3: abrt-1.0.9-ignore_user_scripts.patch
+Patch4: abrt-1.0.9-crash-function-detect.patch
 BuildRequires: dbus-devel
 BuildRequires: gtk2-devel
 BuildRequires: curl-devel
@@ -242,6 +243,7 @@ Virtual package to make easy default installation on desktop environments.
 %patch1 -p1 -b .localizedyum
 %patch2 -p1 -b .better_bz
 %patch3 -p1 -b .ingore_unp_scripts
+%patch4 -p1 -b .crash_function_detect
 
 %build
 %configure
@@ -463,6 +465,9 @@ fi
 %defattr(-,root,root,-)
 
 %changelog
+* Fri Apr 30 2010 Karel Klic <kklic@redhat.com> 1.0.9-3
+- fixed crash function detection (a part of duplication detection)
+
 * Wed Apr 15 2010 Jiri Moskovcak <jmoskovc@redhat.com> 1.0.9-2
 - fixed problem with localized yum messages rhbz#581804
 - better bugzilla summary (napjkovs@redhat.com)