[rpms/abrt] update-2.17.8: don't allow sending unusable backtrace, versioned libreport deps

[rpms/abrt] update-2.17.8: don't allow sending unusable backtrace, versioned libreport deps

[Jiri Moskovcak]

A new commit has been pushed.

Repo   : rpms/abrt
Branch : update-2.17.8
Commit : a4fa2d6195a30cbf3e3048231b8a157169ae612f
Author : Jiri Moskovcak <jmoskovc@redhat.com>
Date   : 2011-04-21T18:27:28+02:00
Stats  : +28/-2 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/abrt/c/a4fa2d6195a30cbf3e3048231b8a157169ae612f?branch=update-2.17.8

Log:
don't allow sending unusable backtrace, versioned libreport deps

---
diff --git a/abrt.spec b/abrt.spec
index d4a3afc..2b55811 100644
--- a/abrt.spec
+++ b/abrt.spec
@@ -16,7 +16,7 @@
 %if "0%{?_buildid}" != "0"
 %define pkg_release 0.%{?_buildid}%{?dist}
 %else
-%define pkg_release 1%{?dist}
+%define pkg_release 2%{?dist}
 %endif
 
 Summary: Automatic bug detection and reporting tool
@@ -32,6 +32,7 @@ Source2: abrt-ccpp.init
 Patch0: remove_libreport_python.patch
 Patch1: blacklist.patch
 Patch2: allow_bz_for_koops.patch
+Patch3: low_bt_rating.patch
 BuildRequires: dbus-devel
 BuildRequires: gtk2-devel
 BuildRequires: curl-devel
@@ -61,7 +62,7 @@ Requires: systemd-units
 %endif
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Requires: %{name}-libs = %{version}-%{release}
-Requires: libreport
+Requires: libreport = %{version}-%{release}
 Requires(pre): shadow-utils
 Obsoletes: abrt-plugin-sqlite3 > 0.0.1
 # required for transition from 1.1.13, can be removed after some time
@@ -268,6 +269,7 @@ generation service over a network using HTTP protocol.
 %patch0 -p1 -b .libreport_py
 %patch1 -p1 -b .blacklist
 %patch2 -p1 -b bz_for_oops
+%patch3 -p1 -b low_rating
 
 %build
 autoconf
@@ -592,6 +594,10 @@ fi
 %{_infodir}/abrt-retrace-server*
 
 %changelog
+* Thu Apr 21 2011 Jiri Moskovcak <jmoskovc@redhat.com> 2.0.1-2
+- don't allow reporting of backtrace with rating = 0 rhbz#672023
+- use versioned deps on libreport
+
 * Wed Apr 20 2011 Jiri Moskovcak <jmoskovc@redhat.com> 2.0.1-1
 - updated to 2.0.1
 - updated translation

diff --git a/low_bt_rating.patch b/low_bt_rating.patch
new file mode 100644
index 0000000..537aa9b
--- /dev/null
+++ b/low_bt_rating.patch
@@ -0,0 +1,20 @@
+commit 884c0aed054302cb1cbb71c2b21c12df92a7e6e4
+Author: Karel Klic <kklic@redhat.com>
+Date:   Thu Apr 21 08:59:38 2011 +0200
+
+    Do not allow to submit backtraces with rating 0 (or some other unexpected rating).
+
+diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
+index 44dc11b..0a57f04 100644
+--- a/src/gui-wizard-gtk/wizard.c
++++ b/src/gui-wizard-gtk/wizard.c
+@@ -1005,8 +1005,7 @@ static void check_backtrace_and_allow_send(void) //TODO: rename, this checks rat
+                 add_warning(_("The backtrace is incomplete, please make sure you provide the steps to reproduce."));
+                 warn = true;
+                 break;
+-            case '2':
+-            case '1':
++            default:
+                 //FIXME: see CreporterAssistant: 394 for ideas
+                 add_warning(_("Reporting disabled because the backtrace is unusable."));
+                 send = false;