public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/cinnamon] rawhide: Add missing BuildRequires: 'xcomposite', 'xext', 'atk-bridge-2.0'
@ 2026-07-28 7:59 Michal Schorm
0 siblings, 0 replies; only message in thread
From: Michal Schorm @ 2026-07-28 7:59 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/cinnamon
Branch : rawhide
Commit : 3ef4e0f89080fc833d9dd63a2cba4744081deff5
Author : Michal Schorm <mschorm@redhat.com>
Date : 2026-07-26T19:23:27+02:00
Stats : +3/-0 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/cinnamon/c/3ef4e0f89080fc833d9dd63a2cba4744081deff5?branch=rawhide
Log:
Add missing BuildRequires: 'xcomposite', 'xext', 'atk-bridge-2.0'
The upstream 'meson.build' explicitly requires all three via
'dependency()' calls:
meson.build:36: atk = dependency('atk-bridge-2.0')
meson.build:56: xcomposite = dependency('xcomposite')
meson.build:57: xext = dependency('xext')
'xext' is additionally used in a compile check:
meson.build:160: if cc.has_header('X11/extensions/shape.h',
dependencies: [X11, xext])
These were not listed in the spec's BuildRequires despite being
direct meson 'dependency()' calls. Builds succeeded because they
are pulled in transitively (via 'pkgconfig(libmuffin-0)' and
'pkgconfig(gtk+-3.0)'), but Fedora Packaging Guidelines require
direct build dependencies to be listed explicitly — transitive
availability is not guaranteed across rebuilds.
Co-Authored-By: Claude AI <noreply@anthropic.com>
---
diff --git a/cinnamon.spec b/cinnamon.spec
index d814d2b..04450bc 100644
--- a/cinnamon.spec
+++ b/cinnamon.spec
@@ -50,6 +50,9 @@ BuildRequires: pkgconfig(dbus-1)
BuildRequires: pkgconfig(gtk+-3.0)
BuildRequires: pkgconfig(libxml-2.0)
BuildRequires: pkgconfig(x11)
+BuildRequires: pkgconfig(xcomposite)
+BuildRequires: pkgconfig(xext)
+BuildRequires: pkgconfig(atk-bridge-2.0)
# for screencast recorder functionality
BuildRequires: pkgconfig(gstreamer-1.0)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-28 7:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-28 7:59 [rpms/cinnamon] rawhide: Add missing BuildRequires: 'xcomposite', 'xext', 'atk-bridge-2.0' Michal Schorm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox