public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/cjs] rawhide: Add missing BuildRequires: 'pkgconfig(cairo)' and 'pkgconfig(libffi)'
@ 2026-07-25 23:18 Michal Schorm
  0 siblings, 0 replies; only message in thread
From: Michal Schorm @ 2026-07-25 23:18 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/cjs
            Branch : rawhide
            Commit : 554079ca2c5d758a9340d52576c841dd67b82828
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-07-26T00:50:11+02:00
            Stats  : +2/-0 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/cjs/c/554079ca2c5d758a9340d52576c841dd67b82828?branch=rawhide

            Log:
            Add missing BuildRequires: 'pkgconfig(cairo)' and 'pkgconfig(libffi)'

Both are explicitly checked by 'meson.build' lines 172-173:
  ffi = dependency('libffi', fallback: ['libffi', 'ffi_dep'])
  cairo = dependency('cairo', fallback: ['cairo', 'libcairo_dep'])
https://github.com/linuxmint/cjs/blob/140.0/meson.build#L172-L173

The spec already had 'pkgconfig(cairo-gobject)' but not plain
'pkgconfig(cairo)'. Without explicit BuildRequires, both
dependencies are satisfied only transitively.

Linux Mint 'debian/control' lines 13-14 list both 'libcairo2-dev' and
'libffi-dev' explicitly.
https://github.com/linuxmint/cjs/blob/140.0/debian/control#L13-L14

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/cjs.spec b/cjs.spec
index 1d47f33..91c5366 100644
--- a/cjs.spec
+++ b/cjs.spec
@@ -17,11 +17,13 @@ ExcludeArch:   %{ix86}
 BuildRequires: gcc-c++
 BuildRequires: gettext
 BuildRequires: meson
+BuildRequires: pkgconfig(cairo)
 BuildRequires: pkgconfig(cairo-gobject)
 BuildRequires: pkgconfig(gio-2.0) >= %{glib2_version}
 BuildRequires: pkgconfig(girepository-2.0) >= %{glib2_version}
 BuildRequires: pkgconfig(gobject-introspection-1.0)
 BuildRequires: pkgconfig(gtk+-3.0) >= %{gtk3_version}
+BuildRequires: pkgconfig(libffi)
 BuildRequires: pkgconfig(mozjs-140) >= %{mozjs140_version}
 BuildRequires: pkgconfig(readline)
 BuildRequires: pkgconfig(sysprof-capture-4)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-25 23:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-25 23:18 [rpms/cjs] rawhide: Add missing BuildRequires: 'pkgconfig(cairo)' and 'pkgconfig(libffi)' Michal Schorm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox