public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/coturn] main: Add patch to build successfully using hiredis < 1.1.0 on RHEL 9
@ 2026-07-24 11:59 Robert Scheck
  0 siblings, 0 replies; only message in thread
From: Robert Scheck @ 2026-07-24 11:59 UTC (permalink / raw)
  To: git-commits

A new commit has been pushed.

Repo   : rpms/coturn
Branch : main
Commit : 093626f2a2936ce7bb4b3fbd0f0e5a75d6001e47
Author : Robert Scheck <robert@fedoraproject.org>
Date   : 2026-07-24T13:45:23+02:00
Stats  : +50/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/coturn/c/093626f2a2936ce7bb4b3fbd0f0e5a75d6001e47?branch=main

Log:
Add patch to build successfully using hiredis < 1.1.0 on RHEL 9

---
diff --git a/coturn-4.15.0-hiredis-legacy.patch b/coturn-4.15.0-hiredis-legacy.patch
new file mode 100644
index 0000000..235a82a
--- /dev/null
+++ b/coturn-4.15.0-hiredis-legacy.patch
@@ -0,0 +1,48 @@
+From bacb09dcb6bc3579a5d34ac1177ec5edb3416dc1 Mon Sep 17 00:00:00 2001
+From: Robert Scheck <robert@fedoraproject.org>
+Date: Fri, 24 Jul 2026 13:40:19 +0200
+Subject: [PATCH] Restore support for hiredis < 1.1.0 (for AlmaLinux/RHEL/Rocky
+ Linux 9)
+
+Conditionalize changes from commit 273f2e8 to support building using
+hiredis < 1.1.0 in AlmaLinux/RHEL/Rocky Linux 9.
+---
+ src/apps/relay/dbdrivers/dbd_redis.c | 18 ++++++++++++++++++
+ 1 file changed, 18 insertions(+)
+
+diff --git a/src/apps/relay/dbdrivers/dbd_redis.c b/src/apps/relay/dbdrivers/dbd_redis.c
+index 0a5967916..473adac26 100644
+--- a/src/apps/relay/dbdrivers/dbd_redis.c
++++ b/src/apps/relay/dbdrivers/dbd_redis.c
+@@ -65,6 +65,9 @@ static redisSSLContext *redis_create_ssl_ctx(Ryconninfo *co) {
+   (void)pthread_once(&openssl_once, redis_init_openssl_once);
+ 
+   redisSSLContextError ssl_error = REDIS_SSL_CTX_NONE;
++
++#if defined(HIREDIS_MAJOR) && (HIREDIS_MAJOR > 1 || (HIREDIS_MAJOR == 1 && HIREDIS_MINOR >= 1))
++  /* hiredis >= 1.1.0: options-struct SSL API, supports verify_mode. */
+   redisSSLOptions opt = {0};
+   opt.cacert_filename = co->tls_ca;
+   opt.capath = co->tls_capath;
+@@ -74,6 +77,21 @@ static redisSSLContext *redis_create_ssl_ctx(Ryconninfo *co) {
+   opt.verify_mode = co->tls_verify ? REDIS_SSL_VERIFY_PEER : REDIS_SSL_VERIFY_NONE;
+ 
+   redisSSLContext *ssl_ctx = redisCreateSSLContextWithOptions(&opt, &ssl_error);
++#else
++  /* hiredis < 1.1.0: legacy positional-args SSL API. There is no verify_mode
++     knob here -- verification behavior is fixed by the library based on
++     whether a CA/capath is supplied. Warn if the connection string asked for
++     verify=none, since we cannot honor that on this hiredis version. */
++  if (!co->tls_verify) {
++    TURN_LOG_FUNC(TURN_LOG_LEVEL_WARNING,
++                  "Redis TLS: verify=none requested but this hiredis version has no verify-mode "
++                  "control; server certificate will still be verified if a CA is configured\n");
++  }
++
++  redisSSLContext *ssl_ctx = redisCreateSSLContext(co->tls_ca, co->tls_capath, co->tls_cert, co->tls_key,
++                                                   co->tls_sni ? co->tls_sni : co->host, &ssl_error);
++#endif
++
+   if (!ssl_ctx) {
+     TURN_LOG_FUNC(TURN_LOG_LEVEL_ERROR, "Redis TLS: cannot create SSL context: %s\n",
+                   redisSSLContextGetError(ssl_error));

diff --git a/coturn.spec b/coturn.spec
index 8b9de61..4dbcc15 100644
--- a/coturn.spec
+++ b/coturn.spec
@@ -11,6 +11,7 @@ Source2:        coturn.tmpfilesd
 Source3:        coturn.logrotate
 Source4:        coturn.sysusersd
 Patch0:         https://github.com/coturn/coturn/raw/refs/tags/%{version}/patches/openssl-1.1.1/0001-restore-openssl-1.1.1-support.patch#/coturn-4.14.0-openssl-1.1.patch
+Patch1:         https://github.com/coturn/coturn/pull/2001.patch#/coturn-4.15.0-hiredis-legacy.patch
 BuildRequires:  gcc
 BuildRequires:  hiredis-devel
 BuildRequires:  libevent-devel >= 2.0.0
@@ -229,6 +230,7 @@ ldd %{buildroot}%{_bindir}/turnserver | grep -q libsystemd.so
 %changelog
 * Fri Jul 24 2026 Robert Scheck <robert@fedoraproject.org> - 4.15.0-1
 - Upgrade to 4.15.0 (#2506022)
+- Add patch to build successfully using hiredis < 1.1.0 on RHEL 9
 
 * Wed Jul 15 2026 Fedora Release Engineering <releng@fedoraproject.org> - 4.14.0-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_45_Mass_Rebuild

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-24 11:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-24 11:59 [rpms/coturn] main: Add patch to build successfully using hiredis < 1.1.0 on RHEL 9 Robert Scheck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox