public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/transmission] epel10: Make compatible with CMake 4.0
@ 2026-07-20 20:37 Otto Liljalaakso
  0 siblings, 0 replies; only message in thread
From: Otto Liljalaakso @ 2026-07-20 20:37 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/transmission
            Branch : epel10
            Commit : b87171519fc74e76cb86c9338d8531a08128eec6
            Author : Otto Liljalaakso <otto.liljalaakso@iki.fi>
            Date   : 2025-04-26T12:01:49+03:00
            Stats  : +85/-1 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/transmission/c/b87171519fc74e76cb86c9338d8531a08128eec6?branch=epel10

            Log:
            Make compatible with CMake 4.0

Folder third-party/ contains many projects with varying values for
cmake_minimum_version(). Some have less than 3.5, which is the minimum
supported by CMake 4.0. Update those to 3.12, the value used by the
main makefile.

---
diff --git a/0002-Make-compatible-with-CMake-4.0.patch b/0002-Make-compatible-with-CMake-4.0.patch
new file mode 100644
index 0000000..803afcb
--- /dev/null
+++ b/0002-Make-compatible-with-CMake-4.0.patch
@@ -0,0 +1,79 @@
+From 0734bcb88eaf5c744166bb472d727b8f188a6aad Mon Sep 17 00:00:00 2001
+From: Otto Liljalaakso <otto.liljalaakso@iki.fi>
+Date: Fri, 25 Apr 2025 22:13:43 +0300
+Subject: [PATCH] Make compatible with CMake 4.0
+
+Folder third-party/ contains many projects with varying values for
+cmake_minimum_version(). Some have less than 3.5, which is the minimum
+supported by CMake 4.0. Update those to 3.12, the value used by the
+main makefile.
+
+diff --git transmission-4.0.6/third-party/dht/CMakeLists.txt transmission-4.0.6/third-party/dht/CMakeLists.txt
+index 6d4aa99..f4d8ac2 100644
+--- transmission-4.0.6/third-party/dht/CMakeLists.txt
++++ transmission-4.0.6/third-party/dht/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 2.8)
++cmake_minimum_required(VERSION 3.12)
+ project(dht C)
+ 
+ add_library(${PROJECT_NAME} STATIC
+diff --git transmission-4.0.6/third-party/rapidjson/CMakeLists.txt transmission-4.0.6/third-party/rapidjson/CMakeLists.txt
+index 6033415..987ba9c 100644
+--- transmission-4.0.6/third-party/rapidjson/CMakeLists.txt
++++ transmission-4.0.6/third-party/rapidjson/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12)
++CMAKE_MINIMUM_REQUIRED(VERSION 3.12)
+ if(POLICY CMP0025)
+   # detect Apple's Clang
+   cmake_policy(SET CMP0025 NEW)
+diff --git transmission-4.0.6/third-party/rapidjson/example/CMakeLists.txt transmission-4.0.6/third-party/rapidjson/example/CMakeLists.txt
+index 9f53c9a..53f94b1 100644
+--- transmission-4.0.6/third-party/rapidjson/example/CMakeLists.txt
++++ transmission-4.0.6/third-party/rapidjson/example/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 2.8)
++cmake_minimum_required(VERSION 3.12)
+ 
+ if(POLICY CMP0054)
+   cmake_policy(SET CMP0054 NEW)
+diff --git transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/CMakeLists.txt transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/CMakeLists.txt
+index f8a97fa..b6b6903 100644
+--- transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/CMakeLists.txt
++++ transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 2.6.4)
++cmake_minimum_required(VERSION 3.12)
+ 
+ if (POLICY CMP0048)
+   cmake_policy(SET CMP0048 NEW)
+diff --git transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googlemock/CMakeLists.txt transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googlemock/CMakeLists.txt
+index bac2e3b..d4b2607 100644
+--- transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googlemock/CMakeLists.txt
++++ transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googlemock/CMakeLists.txt
+@@ -43,7 +43,7 @@ else()
+   cmake_policy(SET CMP0048 NEW)
+   project(gmock VERSION 1.9.0 LANGUAGES CXX C)
+ endif()
+-cmake_minimum_required(VERSION 2.6.4)
++cmake_minimum_required(VERSION 3.12)
+ 
+ if (COMMAND set_up_hermetic_build)
+   set_up_hermetic_build()
+diff --git transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googletest/CMakeLists.txt transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googletest/CMakeLists.txt
+index b09c46e..68f5d4d 100644
+--- transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googletest/CMakeLists.txt
++++ transmission-4.0.6/third-party/rapidjson/thirdparty/gtest/googletest/CMakeLists.txt
+@@ -50,7 +50,7 @@ else()
+   cmake_policy(SET CMP0048 NEW)
+   project(gtest VERSION 1.9.0 LANGUAGES CXX C)
+ endif()
+-cmake_minimum_required(VERSION 2.6.4)
++cmake_minimum_required(VERSION 3.12)
+ 
+ if (POLICY CMP0063) # Visibility
+   cmake_policy(SET CMP0063 NEW)
+-- 
+2.49.0
+

diff --git a/transmission.spec b/transmission.spec
index 250a3e8..129eb95 100644
--- a/transmission.spec
+++ b/transmission.spec
@@ -1,6 +1,6 @@
 Name:           transmission
 Version:        4.0.6
-Release:        7%{?dist}
+Release:        8%{?dist}
 Summary:        A lightweight GTK+ BitTorrent client
 # See COPYING. This licensing situation is... special.
 License:        MIT and GPL-2.0-only
@@ -13,6 +13,8 @@ Source1:        https://raw.githubusercontent.com/gnome-design-team/gnome-icons/
 # https://github.com/transmission/transmission/pull/847
 Patch0:         0001-gtk-use-com.transmissionbt.Transmission.-D-Bus-names.patch
 Patch1:         %{name}-miniupnp228.patch
+# Proposed upstream: https://github.com/transmission/transmission/issues/7567
+Patch2:         0002-Make-compatible-with-CMake-4.0.patch
 
 
 BuildRequires:  make
@@ -197,6 +199,9 @@ install -m0644 -D transmission.sysusers.conf %{buildroot}%{_sysusersdir}/transmi
 %doc %{_mandir}/man1/transmission-qt.*
 
 %changelog
+* Sat Apr 26 2025 Otto Liljalaakso <otto.liljalaakso@iki.fi> - 4.0.6-8
+- Make compatible with CMake 4.0
+
 * Wed Apr 16 2025 Simone Caronni <negativo17@gmail.com> - 4.0.6-7
 - Rebuild for updated miniupnpc.
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-20 20:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-20 20:37 [rpms/transmission] epel10: Make compatible with CMake 4.0 Otto Liljalaakso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox