public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/vlc] epel9-next: Avoid "stale plugin cache" warnings in flatpaks
@ 2026-07-20 18:06 Yaakov Selkowitz
0 siblings, 0 replies; only message in thread
From: Yaakov Selkowitz @ 2026-07-20 18:06 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/vlc
Branch : epel9-next
Commit : a3d726f79ef716618e444526e757498d1807ce18
Author : Yaakov Selkowitz <yselkowi@redhat.com>
Date : 2025-01-10T00:58:48-05:00
Stats : +25/-0 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/vlc/c/a3d726f79ef716618e444526e757498d1807ce18?branch=epel9-next
Log:
Avoid "stale plugin cache" warnings in flatpaks
flatpak (and ostree) report an st_mtime of 0 (or 1 in past versions)
for all files it controls, which does not match the real time recorded
when installing the plugins in the mock buildroot. Therefore, check
this only when it appears to be real.
---
diff --git a/flatpak-cache.patch b/flatpak-cache.patch
new file mode 100644
index 0000000..3b04eab
--- /dev/null
+++ b/flatpak-cache.patch
@@ -0,0 +1,23 @@
+Based on the Flathub patch but only skip the mtime test when in an ostree
+(different versions have used 0 or 1 as the mtime for all files).
+
+https://github.com/flathub/org.videolan.VLC/blob/master/vlc-ignore-time-for-cache.patch
+
+diff --git a/src/modules/bank.c b/src/modules/bank.c
+index 2e67a0d07e..ab2915fbb7 100644
+--- a/src/modules/bank.c
++++ b/src/modules/bank.c
+@@ -275,7 +275,8 @@ static int AllocatePluginFile (module_bank_t *bank, const char *abspath,
+ plugin = vlc_cache_lookup(&bank->cache, relpath);
+
+ if (plugin != NULL
+- && (plugin->mtime != (int64_t)st->st_mtime
++ && (((int64_t)st->st_mtime > (int64_t)1
++ && plugin->mtime != (int64_t)st->st_mtime)
+ || plugin->size != (uint64_t)st->st_size))
+ {
+ msg_Err(bank->obj, "stale plugins cache: modified %s",
+ plugin->abspath);
+--
+2.21.0
+
diff --git a/vlc.spec b/vlc.spec
index 2dcf017..b694009 100644
--- a/vlc.spec
+++ b/vlc.spec
@@ -65,6 +65,8 @@ Patch: lua-math.patch
Patch: freerdp2.patch
# fix build with live555-2024.11.28
Patch: live555.patch
+# avoid "stale plugin cache" warnings in flatpaks
+Patch: flatpak-cache.patch
%{load:%{S:1}}
%global __provides_exclude_from ^%{vlc_plugindir}/.*$
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-20 18:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-20 18:06 [rpms/vlc] epel9-next: Avoid "stale plugin cache" warnings in flatpaks Yaakov Selkowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox