public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/hipblas] rawhide: Fix test building on epel
@ 2026-07-10 12:59 Tom Rix
  0 siblings, 0 replies; only message in thread
From: Tom Rix @ 2026-07-10 12:59 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/hipblas
            Branch : rawhide
            Commit : d6d5392dcf2798cc709f745b5dce2738652c7448
            Author : Tom Rix <Tom.Rix@amd.com>
            Date   : 2026-07-10T05:58:51-07:00
            Stats  : +10/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/hipblas/c/d6d5392dcf2798cc709f745b5dce2738652c7448?branch=rawhide

            Log:
            Fix test building on epel

Signed-off-by: Tom Rix <Tom.Rix@amd.com>

---
diff --git a/hipblas.spec b/hipblas.spec
index d79ed92..8b553e4 100644
--- a/hipblas.spec
+++ b/hipblas.spec
@@ -127,6 +127,11 @@ BuildRequires:  gtest-devel
 BuildRequires:  cblas-devel
 BuildRequires:  lapack-devel
 %else
+# On RHEL, this error
+#        ld.lld: error: undefined symbol: _gfortran_transfer_character_write
+#        >>> referenced by xerbla.f.o:(xerbla_) in archive /usr/lib64/libblas64.a
+# but also hipblas/clients/include/cblas_interface.h has a hardcoded dependence on cblas_ functions
+%global blas_static OFF
 BuildRequires:  blas-static
 BuildRequires:  lapack-static
 BuildRequires:  python3-pyyaml
@@ -191,8 +196,11 @@ sed -i -e 's@find_package(Git REQUIRED)@#find_package(Git REQUIRED)@' library/CM
 # LINK_BLIS
 #   ON: use AOCL BLIS
 #   OFF: use lapack, cblas
+#
+# It can be painful figuring out where your blas library is, add this to the command line
+#    --debug-find-pkg=BLAS --debug-trycompile
 %cmake \
-    -DAMDGPU_TARGETS=%{rocm_gpu_list_default} \
+    -DBLA_STATIC=%blas_static \
     -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \
     -DBUILD_CLIENTS_BENCHMARKS=%{build_test} \
     -DBUILD_CLIENTS_TESTS=%{build_test} \
@@ -211,6 +219,7 @@ sed -i -e 's@find_package(Git REQUIRED)@#find_package(Git REQUIRED)@' library/CM
     -DCMAKE_PREFIX_PATH=%{rocmllvm_cmakedir}/.. \
     -DCMAKE_SKIP_RPATH=%{skip_install_rpath} \
     -DCMAKE_SKIP_INSTALL_RPATH=%{skip_install_rpath} \
+    -DGPU_TARGETS=%{rocm_gpu_list_default} \
     -DROCM_SYMLINK_LIBS=OFF \
     -DHIP_PLATFORM=amd \
     -DLINK_BLIS=OFF

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-10 12:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-10 12:59 [rpms/hipblas] rawhide: Fix test building on epel Tom Rix

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox