public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/llvm] rawhide: Use LLD on RHEL 8 as well
@ 2026-07-06 12:40 Nikita Popov
  0 siblings, 0 replies; only message in thread
From: Nikita Popov @ 2026-07-06 12:40 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/llvm
            Branch : rawhide
            Commit : 3173df92c12a01e84c454456648cc57385e6ff7c
            Author : Nikita Popov <npopov@redhat.com>
            Date   : 2026-07-06T12:39:09+00:00
            Stats  : +2/-6 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/llvm/c/3173df92c12a01e84c454456648cc57385e6ff7c?branch=rawhide

            Log:
            Use LLD on RHEL 8 as well

Currently we use LLD everywhere except RHEL 8. Originally we started
using LLD because it was necessary for PGO, and we don't use PGO on
RHEL 8.

I'm proposing to enable use of LLD everywhere. In particular, this
avoids a linker error on rhel-8-s390x:

> (.text._ZNSt23_Sp_counted_ptr_inplaceINSt10filesystem7__cxx1116filesystem_error5_ImplESaIS3_ELN9__gnu_cxx12_Lock_policyE2EE14_M_get_deleterERKSt9type_info[_ZNSt23_Sp_counted_ptr_inplaceINSt10filesystem7__cxx1116filesystem_error5_ImplESaIS3_ELN9__gnu_cxx12_Lock_policyE2EE14_M_get_deleterERKSt9type_info]+0x18): misaligned symbol `_ZTSSt19_Sp_make_shared_tag' (0xbc735) for relocation R_390_PC32DBL

This is due to a bug in the binutils version used by gcc-toolset-15.
The issue does not occur when using LLD.

---
diff --git a/llvm.spec b/llvm.spec
index 5226aba..49badbd 100644
--- a/llvm.spec
+++ b/llvm.spec
@@ -232,13 +232,9 @@ end
 %endif
 %endif
 
-
-%if 0%{?rhel} == 8
-# RHEL8 still builds with gcc + ld.bfd.
-%bcond_with use_lld
-%else
+# Use LLD instead of the system linker by default.
+# This is required if PGO is enabled.
 %bcond_without use_lld
-%endif
 
 %if %{with pgo} && %{without use_lld}
 %{error:PGO requires --with=lld}

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-06 12:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-06 12:40 [rpms/llvm] rawhide: Use LLD on RHEL 8 as well Nikita Popov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox