[rpms/gdb] gdb-17.2-rebase-f44: Remove 'set/show build-id-core-load' setting from GDB

[rpms/gdb] gdb-17.2-rebase-f44: Remove 'set/show build-id-core-load' setting from GDB

[Andrew Burgess]

            A new commit has been pushed.

            Repo   : rpms/gdb
            Branch : gdb-17.2-rebase-f44
            Commit : bbf9637235751b56c5b425c17d1cee5db135c743
            Author : Andrew Burgess <aburgess@redhat.com>
            Date   : 2024-12-11T12:49:57+00:00
            Stats  : +9/-77 in 5 file(s)
            URL    : https://src.fedoraproject.org/rpms/gdb/c/bbf9637235751b56c5b425c17d1cee5db135c743?branch=gdb-17.2-rebase-f44

            Log:
            Remove 'set/show build-id-core-load' setting from GDB

This commit drops the gdb-add-deprecated-settings-py-script.patch
file, and removes the 'set/show build-id-core-load' setting from GDB.

The 'set/show build-id-core-load' setting has had no effect since
commit:

  commit a5d2c85367e544d4464d783b2a70325288c0e6c7
  Date:   Tue Feb 4 15:06:34 2020 -0500

      Rebase to FSF GDB 9.0.90.20200203 (9.1pre).

This could potentially impact users who have scripts that still try to
change this setting, but the fix is to simply stop referencing the
setting, the setting itself has no purpose any more.

---
diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include
index a88f36d..a142066 100644
--- a/_gdb.spec.Patch.include
+++ b/_gdb.spec.Patch.include
@@ -104,13 +104,9 @@ Patch017: gdb-backport-buildid-related-changes.patch
 # RPMs to install when GDB finds an objfile with no debug info.
 Patch018: gdb-add-rpm-suggestion-script.patch
 
-# Not a backport.  Add a new script which defines a setting which is
-# deprecated, but we don't want to remove it from Fedora GDB just yet.
-Patch019: gdb-add-deprecated-settings-py-script.patch
-
 # Tests and test updates related to the rpm suggestion feature.
-Patch020: gdb-6.6-buildid-locate-tests.patch
+Patch019: gdb-6.6-buildid-locate-tests.patch
 
 
-Patch021: gdb-catchpoint-re-set.patch
+Patch020: gdb-catchpoint-re-set.patch
 

diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include
index 2799cc4..bde25b1 100644
--- a/_gdb.spec.patch.include
+++ b/_gdb.spec.patch.include
@@ -18,4 +18,3 @@
 %patch -p1 -P018
 %patch -p1 -P019
 %patch -p1 -P020
-%patch -p1 -P021

diff --git a/_patch_order b/_patch_order
index 12e002d..05d2721 100644
--- a/_patch_order
+++ b/_patch_order
@@ -16,6 +16,5 @@ gdb-add-index.patch
 gdb-remove-qnx-neutrino-support.patch
 gdb-backport-buildid-related-changes.patch
 gdb-add-rpm-suggestion-script.patch
-gdb-add-deprecated-settings-py-script.patch
 gdb-6.6-buildid-locate-tests.patch
 gdb-catchpoint-re-set.patch

diff --git a/gdb-add-deprecated-settings-py-script.patch b/gdb-add-deprecated-settings-py-script.patch
deleted file mode 100644
index dee2eaf..0000000
--- a/gdb-add-deprecated-settings-py-script.patch
+++ /dev/null
@@ -1,68 +0,0 @@
-From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
-From: Andrew Burgess <aburgess@redhat.com>
-Date: Tue, 19 Nov 2024 13:56:56 +0000
-Subject: gdb-add-deprecated-settings-py-script.patch
-
-;; Not a backport.  Add a new script which defines a setting which is
-;; deprecated, but we don't want to remove it from Fedora GDB just yet.
-
-gdb: add script which defines a deprecated settings
-
-The build-id-core-load setting has not been useful since 2020, but its
-not clear when it will be OK to remove this from GDB.
-
-Rather than defining this setting in C++ code, lets just create it
-using this Python script, this helps keep the Fedora stuff out of core
-GDB.
-
-diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in
---- a/gdb/data-directory/Makefile.in
-+++ b/gdb/data-directory/Makefile.in
-@@ -86,6 +86,7 @@ PYTHON_FILE_LIST = \
- 	gdb/unwinder.py \
- 	gdb/xmethod.py \
- 	gdb/command/__init__.py \
-+	gdb/command/deprecated-settings.py \
- 	gdb/command/explore.py \
- 	gdb/command/frame_filters.py \
- 	gdb/command/missing_files.py \
-diff --git a/gdb/python/lib/gdb/command/deprecated-settings.py b/gdb/python/lib/gdb/command/deprecated-settings.py
-new file mode 100644
---- /dev/null
-+++ b/gdb/python/lib/gdb/command/deprecated-settings.py
-@@ -0,0 +1,35 @@
-+import gdb
-+
-+# This setting was added to Fedora GDB back in 2007.  It controlled
-+# whether GDB would use the build-id extracted from a core file to
-+# auto-load the executable if the user had not already loaded an
-+# executable.
-+#
-+# In 2020 this setting was effectively deprecated as the only use of
-+# the setting's value was removed.  After this GDB would always
-+# auto-load an executable based on the build-id if no executable was
-+# already loaded.
-+#
-+# For now we maintain this setting for backward compatibility reasons.
-+
-+class build_id_core_load(gdb.Parameter):
-+    """This setting is deprecated.  Changing it will have no effect.
-+    This is maintained only for backwards compatibility.
-+
-+    When opening a core-file, and no executable is loaded, GDB will
-+    always try to auto-load a suitable executable using the build-id
-+    extracted from the core file (if a suitable build-id can be
-+    found)."""
-+
-+    def __init__(self):
-+        self.set_doc = "This setting is deprecated and has no effect."
-+        self.show_doc = "This setting is deprecated and has no effect."
-+        self.value = True
-+
-+        super().__init__("build-id-core-load", gdb.COMMAND_DATA, gdb.PARAM_BOOLEAN)
-+    def validate(self):
-+        return True
-+    def get_set_string(self):
-+        raise gdb.GdbError("The 'build-id-core-load' setting is deprecated.")
-+
-+build_id_core_load()

diff --git a/gdb.spec b/gdb.spec
index 65f950e..2230fd6 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -45,7 +45,7 @@ Version: 15.2
 
 # The release always contains a leading reserved number, start it at 1.
 # `upstream' is not a part of `name' to stay fully rpm dependencies compatible for the testing.
-Release: 4%{?dist}
+Release: 5%{?dist}
 
 License: GPL-3.0-or-later AND BSD-3-Clause AND FSFAP AND LGPL-2.1-or-later AND GPL-2.0-or-later AND LGPL-2.0-or-later AND LicenseRef-Fedora-Public-Domain AND GFDL-1.3-or-later AND LGPL-2.0-or-later WITH GCC-exception-2.0 AND GPL-3.0-or-later WITH GCC-exception-3.1 AND GPL-2.0-or-later WITH GNU-compiler-exception
 # Do not provide URL for snapshots as the file lasts there only for 2 days.
@@ -928,6 +928,12 @@ fi
 # endif scl
 
 %changelog
+* Wed Dec 11 2024 Andrew Burgess <aburgess@redhat.com>
+- Remove gdb-add-deprecated-settings-py-script.patch.  This REMOVES
+  the 'set/show build-id-core-load' setting from GDB.  This setting
+  has had no effect on GDB since commit a5d2c85367e544d446 back in
+  2020.  Lets finally drop this setting.
+
 * Tue Dec 10 2024 Andrew Burgess <aburgess@redhat.com>
 - Remove
   gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch,