[rpms/gdb] gdb-17.2-rebase-f44: remove gdb-container-rh-pkg.patch

[rpms/gdb] gdb-17.2-rebase-f44: remove gdb-container-rh-pkg.patch

[Andrew Burgess]

            A new commit has been pushed.

            Repo   : rpms/gdb
            Branch : gdb-17.2-rebase-f44
            Commit : 202496635c6053c9d4067ff5bf260542b02bfe03
            Author : Andrew Burgess <aburgess@redhat.com>
            Date   : 2024-03-19T15:30:41+00:00
            Stats  : +28/-58 in 5 file(s)
            URL    : https://src.fedoraproject.org/rpms/gdb/c/202496635c6053c9d4067ff5bf260542b02bfe03?branch=gdb-17.2-rebase-f44

            Log:
            remove gdb-container-rh-pkg.patch

Remove gdb-container-rh-pkg.patch.  This patch added a warning if the
gdbserver doesn't support the qXfer:exec-file:read packet, that is,
the packet which allows GDB to read the executable from the gdbserver.

The warning text is:

  Remote gdbserver does not support determining executable automatically.
  RHEL <=6.8 and <=7.2 versions of gdbserver do not support such automatic executable detection.
  The following versions of gdbserver support it:
    - Upstream version of gdbserver (unsupported) 7.10 or later
    - Red Hat Developer Toolset (DTS) version of gdbserver from DTS 4.0 or later (only on x86_64)
    - RHEL-7.3 versions of gdbserver (on any architecture)

Clearly the concern here is a user using RHEL 6.8 or earlier, or RHEL
7.2 or earlier.  However, it is my understanding that all of these
versions of RHEL are no longer supported.

As such I think we should drop this patch.  For Fedora this is a
non-issue, any gdbserver of a similar vintage will support the
required packets, and the warning (which talks about RHEL) doesn't
make much sense for Fedora anyway.

For RHEL our expectation is that customers will use a supported
version of gdbserver, and any supported gdbserver should now support
the required packets.

If there are issues that crop up due to this warning being removed
then we might consider upstreaming a more general warning, something
like:

  Remote target doesn't support reading the executable.

But there are lots of optional features we don't warn about, so I'd
only propose doing that if we get lots of confused users
complaining (which I'm not expecting).

---
diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include
index 86b711f..aad0a91 100644
--- a/_gdb.spec.Patch.include
+++ b/_gdb.spec.Patch.include
@@ -130,13 +130,9 @@ Patch030: gdb-fedora-libncursesw.patch
 #=fedoratest
 Patch031: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
 
-# Add messages suggesting more recent RHEL gdbserver (RH BZ 1321114).
-#=fedora
-Patch032: gdb-container-rh-pkg.patch
-
 # [dts+el7] [x86*] Bundle linux_perf.h for libipt (RH BZ 1256513).
 #=fedora
-Patch033: gdb-linux_perf-bundle.patch
+Patch032: gdb-linux_perf-bundle.patch
 
 # Update gdb-add-index.sh such that, when the GDB environment
 # variable is not set, the script is smarter than just looking for
@@ -150,72 +146,72 @@ Patch033: gdb-linux_perf-bundle.patch
 #   https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot
 #
 #=fedora
-Patch034: gdb-add-index.patch
+Patch033: gdb-add-index.patch
 
 # Back-port upstream commit 1f0fab7ff86 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch035: gdb-rhbz2232086-refactor-selftest-support.patch
+Patch034: gdb-rhbz2232086-refactor-selftest-support.patch
 
 # Back-port upstream commit aa19bc1d259 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch036: gdb-rhbz-2232086-reduce-size-of-gdb-index.patch
+Patch035: gdb-rhbz-2232086-reduce-size-of-gdb-index.patch
 
 # Back-port upstream commit acc117b57f7 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch037: gdb-rhbz-2232086-cpp-ify-mapped-symtab.patch
+Patch036: gdb-rhbz-2232086-cpp-ify-mapped-symtab.patch
 
 # Back-port upstream commit aff250145af as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch038: gdb-rhbz-2232086-generate-gdb-index-consistently.patch
+Patch037: gdb-rhbz-2232086-generate-gdb-index-consistently.patch
 
 # Back-port upstream commit 3644f41dc80 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch039: gdb-rhbz-2232086-generate-dwarf-5-index-consistently.patch
+Patch038: gdb-rhbz-2232086-generate-dwarf-5-index-consistently.patch
 
 
-Patch040: gdb-rhbz2250652-gdbpy_gil.patch
+Patch039: gdb-rhbz2250652-gdbpy_gil.patch
 
 
-Patch041: gdb-rhbz2250652-avoid-PyOS_ReadlineTState.patch
+Patch040: gdb-rhbz2250652-avoid-PyOS_ReadlineTState.patch
 
 
-Patch042: gdb-ftbs-swapped-calloc-args.patch
+Patch041: gdb-ftbs-swapped-calloc-args.patch
 
 # Backport upstream workaround for GCC 14 problem which cause assertion
 # failures in GDB.
-Patch043: gdb-rhbz2261580-intrusive_list-assertion-fix.patch
+Patch042: gdb-rhbz2261580-intrusive_list-assertion-fix.patch
 
 # Backport upstream commit 7628a997f27.
-Patch044: gdb-sync-coffread-with-elfread.patch
+Patch043: gdb-sync-coffread-with-elfread.patch
 
 # Backport upstream commit 27807da5849.
-Patch045: gdb-merge-debug-symbol-lookup.patch
+Patch044: gdb-merge-debug-symbol-lookup.patch
 
 # Backport upstream commit 6234ba17598.
-Patch046: gdb-refactor-find-and-add-separate-symbol-file.patch
+Patch045: gdb-refactor-find-and-add-separate-symbol-file.patch
 
 # Backport upstream commit 661d98a3331.
-Patch047: gdb-add-missing-debug-ext-lang-hook.patch
+Patch046: gdb-add-missing-debug-ext-lang-hook.patch
 
 # Backport upstream commit 8f6c452b5a4.
-Patch048: gdb-add-missing-debug-info-python-hook.patch
+Patch047: gdb-add-missing-debug-info-python-hook.patch
 
 # Backport upstream commit 7db795bc67a.
-Patch049: gdb-remove-use-of-py-isascii
+Patch048: gdb-remove-use-of-py-isascii
 
 # Backport upstream commit 1146d27749f.
-Patch050: gdb-remove-path-in-test-name.patch
+Patch049: gdb-remove-path-in-test-name.patch
 
 # Backport upstream commit e8c3dafa5f5.
-Patch051: gdb-do-not-import-py-curses-ascii-module.patch
+Patch050: gdb-do-not-import-py-curses-ascii-module.patch
 
 # Backport upstream commit dd5516bf98f.
-Patch052: gdb-reformat-missing-debug-py-file.patch
+Patch051: gdb-reformat-missing-debug-py-file.patch
 
 # Backport upstream commit 7d21600b31fe.
-Patch053: gdb-handle-no-python-gdb-module.patch
+Patch052: gdb-handle-no-python-gdb-module.patch
 
 # Not a backport.  Add a new script which hooks into GDB and suggests
 # RPMs to install when GDB finds an objfile with no debug info.
-Patch054: gdb-add-rpm-suggestion-script.patch
+Patch053: gdb-add-rpm-suggestion-script.patch
 

diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include
index c9558ed..8ec13e9 100644
--- a/_gdb.spec.patch.include
+++ b/_gdb.spec.patch.include
@@ -51,4 +51,3 @@
 %patch -p1 -P051
 %patch -p1 -P052
 %patch -p1 -P053
-%patch -p1 -P054

diff --git a/_patch_order b/_patch_order
index f6a8ba3..8644d5b 100644
--- a/_patch_order
+++ b/_patch_order
@@ -29,7 +29,6 @@ gdb-rhbz1149205-catch-syscall-after-fork-test.patch
 gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
 gdb-fedora-libncursesw.patch
 gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
-gdb-container-rh-pkg.patch
 gdb-linux_perf-bundle.patch
 gdb-add-index.patch
 gdb-rhbz2232086-refactor-selftest-support.patch

diff --git a/gdb-container-rh-pkg.patch b/gdb-container-rh-pkg.patch
deleted file mode 100644
index 7107e5d..0000000
--- a/gdb-container-rh-pkg.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
-From: Fedora GDB patches <invalid@email.com>
-Date: Fri, 27 Oct 2017 21:07:50 +0200
-Subject: gdb-container-rh-pkg.patch
-
-;; Add messages suggesting more recent RHEL gdbserver (RH BZ 1321114).
-;;=fedora
-
-diff --git a/gdb/remote.c b/gdb/remote.c
---- a/gdb/remote.c
-+++ b/gdb/remote.c
-@@ -14742,7 +14742,17 @@ remote_target::pid_to_exec_file (int pid)
-   char *annex = NULL;
- 
-   if (m_features.packet_support (PACKET_qXfer_exec_file) != PACKET_ENABLE)
--    return NULL;
-+    {
-+      warning (_("Remote gdbserver does not support determining executable "
-+		 "automatically.\n"
-+"RHEL <=6.8 and <=7.2 versions of gdbserver do not support such automatic executable detection.\n"
-+"The following versions of gdbserver support it:\n"
-+"- Upstream version of gdbserver (unsupported) 7.10 or later\n"
-+"- Red Hat Developer Toolset (DTS) version of gdbserver from DTS 4.0 or later (only on x86_64)\n"
-+"- RHEL-7.3 versions of gdbserver (on any architecture)"
-+));
-+      return NULL;
-+    }
- 
-   inferior *inf = find_inferior_pid (this, pid);
-   if (inf == NULL)

diff --git a/gdb.spec b/gdb.spec
index 5b47fae..a5ceae7 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -1250,6 +1250,12 @@ fi
 %endif
 
 %changelog
+* Tue Mar 19 2024 Andrew Burgess <aburgess@redhat.com>
+- Drop gdb-container-rh-pkg.patch.  This patch gave a warning when
+  connecting to very old gdbserver.  The warning mentioned specific
+  RHEL versions, all of which are no longer supported.  As such the
+  warning seems pointless.
+
 * Mon Mar 18 2024 Andrew Burgess <aburgess@redhat.com>
 - Drop gdb-6.3-attach-see-vdso-test.patch, this is a test only patch.
   Upstream commit 93eb6c64ec4a6ea includes a similar test, and will be