[rpms/gdb] gdb-17.2-rebase-f44: remove gdb-6.7-testsuite-stable-results.patch

[rpms/gdb] gdb-17.2-rebase-f44: remove gdb-6.7-testsuite-stable-results.patch

[Guinevere Larsen]

            A new commit has been pushed.

            Repo   : rpms/gdb
            Branch : gdb-17.2-rebase-f44
            Commit : 9a4f6d6e4ccf53f60678afd237b7aa0cb1c10aed
            Author : Guinevere Larsen <blarsen@redhat.com>
            Date   : 2023-08-09T09:31:00+02:00
            Stats  : +36/-142 in 5 file(s)
            URL    : https://src.fedoraproject.org/rpms/gdb/c/9a4f6d6e4ccf53f60678afd237b7aa0cb1c10aed?branch=gdb-17.2-rebase-f44

            Log:
            remove gdb-6.7-testsuite-stable-results.patch

That patch only changed gdb.base/fileio.{c|exp} tests, supposedly to
make them work better when running the test as root. However, that test
only increased the number of fails by 20

---
diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include
index 38901e1..5764017 100644
--- a/_gdb.spec.Patch.include
+++ b/_gdb.spec.Patch.include
@@ -60,121 +60,117 @@ Patch014: gdb-6.6-buildid-locate-rpm.patch
 #=fedoratest
 Patch015: gdb-6.7-ppc-clobbered-registers-O2-test.patch
 
-# Testsuite fixes for more stable/comparable results.
-#=fedoratest
-Patch016: gdb-6.7-testsuite-stable-results.patch
-
 # Test ia64 memory leaks of the code using libunwind.
 #=fedoratest
-Patch017: gdb-6.5-ia64-libunwind-leak-test.patch
+Patch016: gdb-6.5-ia64-libunwind-leak-test.patch
 
 # Test hiding unexpected breakpoints on intentional step commands.
 #=fedoratest
-Patch018: gdb-6.5-missed-trap-on-step-test.patch
+Patch017: gdb-6.5-missed-trap-on-step-test.patch
 
 # Test gcore memory and time requirements for large inferiors.
 #=fedoratest
-Patch019: gdb-6.5-gcore-buffer-limit-test.patch
+Patch018: gdb-6.5-gcore-buffer-limit-test.patch
 
 # Test GCORE for shmid 0 shared memory mappings.
 #=fedoratest: But it is broken anyway, sometimes the case being tested is not reproducible.
-Patch020: gdb-6.3-mapping-zero-inode-test.patch
+Patch019: gdb-6.3-mapping-zero-inode-test.patch
 
 # Test a crash on libraries missing the .text section.
 #=fedoratest
-Patch021: gdb-6.5-section-num-fixup-test.patch
+Patch020: gdb-6.5-section-num-fixup-test.patch
 
 # Fix resolving of variables at locations lists in prelinked libs (BZ 466901).
 #=fedoratest
-Patch022: gdb-6.8-bz466901-backtrace-full-prelinked.patch
+Patch021: gdb-6.8-bz466901-backtrace-full-prelinked.patch
 
 # New test for step-resume breakpoint placed in multiple threads at once.
 #=fedoratest
-Patch023: gdb-simultaneous-step-resume-breakpoint-test.patch
+Patch022: gdb-simultaneous-step-resume-breakpoint-test.patch
 
 # Fix GNU/Linux core open: Can't read pathname for load map: Input/output error.
 # Fix regression of undisplayed missing shared libraries caused by a fix for.
 #=fedoratest: It should be in glibc: libc-alpha: <20091004161706.GA27450@.*>
-Patch024: gdb-core-open-vdso-warning.patch
+Patch023: gdb-core-open-vdso-warning.patch
 
 # Fix follow-exec for C++ programs (bugreported by Martin Stransky).
 #=fedoratest
-Patch025: gdb-archer-next-over-throw-cxx-exec.patch
+Patch024: gdb-archer-next-over-throw-cxx-exec.patch
 
 # Workaround librpm BZ 643031 due to its unexpected exit() calls (BZ 642879).
 #=push+jan
-Patch026: gdb-6.6-buildid-locate-rpm-librpm-workaround.patch
+Patch025: gdb-6.6-buildid-locate-rpm-librpm-workaround.patch
 
 # [delayed-symfile] Test a backtrace regression on CFIs without DIE (BZ 614604).
 #=fedoratest
-Patch027: gdb-test-bt-cfi-without-die.patch
+Patch026: gdb-test-bt-cfi-without-die.patch
 
 # Verify GDB Python built-in function gdb.solib_address exists (BZ # 634108).
 #=fedoratest
-Patch028: gdb-bz634108-solib_address.patch
+Patch027: gdb-bz634108-solib_address.patch
 
 # [archer-tromey-delayed-symfile] New test gdb.dwarf2/dw2-aranges.exp.
 #=fedoratest
-Patch029: gdb-test-dw2-aranges.patch
+Patch028: gdb-test-dw2-aranges.patch
 
 # Workaround PR libc/14166 for inferior calls of strstr.
 #=fedoratest: Compatibility with RHELs (unchecked which ones).
-Patch030: gdb-glibc-strstr-workaround.patch
+Patch029: gdb-glibc-strstr-workaround.patch
 
 # Testcase for `Setting solib-absolute-prefix breaks vDSO' (BZ 818343).
 #=fedoratest
-Patch031: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
+Patch030: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
 
 # Import regression test for `gdb/findvar.c:417: internal-error:
 # read_var_value: Assertion `frame' failed.' (RH BZ 947564) from RHEL 6.5.
 #=fedoratest
-Patch032: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch
+Patch031: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch
 
 # Fix 'memory leak in infpy_read_memory()' (RH BZ 1007614)
 #=fedoratest
-Patch033: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch
+Patch032: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch
 
 # Fix 'gdb gives highly misleading error when debuginfo pkg is present,
 # but not corresponding binary pkg' (RH BZ 981154).
 #=push+jan
-Patch034: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
+Patch033: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
 
 # Testcase for '[SAP] Recursive dlopen causes SAP HANA installer to
 # crash.' (RH BZ 1156192).
 #=fedoratest
-Patch035: gdb-rhbz1156192-recursive-dlopen-test.patch
+Patch034: gdb-rhbz1156192-recursive-dlopen-test.patch
 
 # Fix '`catch syscall' doesn't work for parent after `fork' is called'
 # (Philippe Waroquiers, RH BZ 1149205).
 #=fedoratest
-Patch036: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
+Patch035: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
 
 # Fix 'backport GDB 7.4 fix to RHEL 6.6 GDB' [Original Sourceware bug
 # description: 'C++ (and objc): Internal error on unqualified name
 # re-set', PR 11657] (RH BZ 1186476).
 #=fedoratest
-Patch037: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch
+Patch036: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch
 
 # Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan
 # Kratochvil, RH BZ 1084404).
 #=fedoratest
-Patch038: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
+Patch037: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
 
 # Force libncursesw over libncurses to match the includes (RH BZ 1270534).
 #=push+jan
-Patch039: gdb-fedora-libncursesw.patch
+Patch038: gdb-fedora-libncursesw.patch
 
 # [aarch64] Fix hardware watchpoints (RH BZ 1261564).
 #=fedoratest
-Patch040: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
+Patch039: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
 
 # Add messages suggesting more recent RHEL gdbserver (RH BZ 1321114).
 #=fedora
-Patch041: gdb-container-rh-pkg.patch
+Patch040: gdb-container-rh-pkg.patch
 
 # [dts+el7] [x86*] Bundle linux_perf.h for libipt (RH BZ 1256513).
 #=fedora
-Patch042: gdb-linux_perf-bundle.patch
+Patch041: gdb-linux_perf-bundle.patch
 
 # Update gdb-add-index.sh such that, when the GDB environment
 # variable is not set, the script is smarter than just looking for
@@ -188,26 +184,26 @@ Patch042: gdb-linux_perf-bundle.patch
 #   https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot
 #
 #=fedora
-Patch043: gdb-add-index.patch
+Patch042: gdb-add-index.patch
 
 # [s390x] Backport arch12 instructions decoding (RH BZ 1553104).
 # =fedoratest
-Patch044: gdb-rhbz1553104-s390x-arch12-test.patch
+Patch043: gdb-rhbz1553104-s390x-arch12-test.patch
 
 # Backport "Fix a potential illegal memory access in the BFD library..."
 # (Nick Clifton, binutils/29988)
-Patch045: gdb-binutils29988-read_indexed_address.patch
+Patch044: gdb-binutils29988-read_indexed_address.patch
 
 # Backport upstream patch fixing a "dangling pointer" build problem
 # first seen when building with GCC 13.1.1 20230426 (Red Hat ;; 13.1.1-1).
-Patch046: gdb-rhbz2192105-ftbs-dangling-pointer
+Patch045: gdb-rhbz2192105-ftbs-dangling-pointer
 
 # Backport two commits, 0ad504dd464 and ea70f941f9b, from Lancelot SIX
 # which prevent repeated warnings from being printed while loading a
 # core file. (RH BZ 2160211)
-Patch047: gdb-rhbz2160211-excessive-core-file-warnings.patch
+Patch046: gdb-rhbz2160211-excessive-core-file-warnings.patch
 
 # Backport upstream commit f3eee5861743d635 to fix a crash triggered
 # when debuginfod makes use of particular openssl settings.
-Patch048: gdb-bz2196395-debuginfod-legacy-openssl-crash.patch
+Patch047: gdb-bz2196395-debuginfod-legacy-openssl-crash.patch
 

diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include
index ef55dd0..8258dc9 100644
--- a/_gdb.spec.patch.include
+++ b/_gdb.spec.patch.include
@@ -45,4 +45,3 @@
 %patch -p1 -P045
 %patch -p1 -P046
 %patch -p1 -P047
-%patch -p1 -P048

diff --git a/_patch_order b/_patch_order
index 143a63e..ef3567d 100644
--- a/_patch_order
+++ b/_patch_order
@@ -13,7 +13,6 @@ gdb-6.6-buildid-locate.patch
 gdb-6.6-buildid-locate-solib-missing-ids.patch
 gdb-6.6-buildid-locate-rpm.patch
 gdb-6.7-ppc-clobbered-registers-O2-test.patch
-gdb-6.7-testsuite-stable-results.patch
 gdb-6.5-ia64-libunwind-leak-test.patch
 gdb-6.5-missed-trap-on-step-test.patch
 gdb-6.5-gcore-buffer-limit-test.patch

diff --git a/gdb-6.7-testsuite-stable-results.patch b/gdb-6.7-testsuite-stable-results.patch
deleted file mode 100644
index fcb007c..0000000
--- a/gdb-6.7-testsuite-stable-results.patch
+++ /dev/null
@@ -1,104 +0,0 @@
-From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
-From: Jan Kratochvil <jan.kratochvil@redhat.com>
-Date: Fri, 27 Oct 2017 21:07:50 +0200
-Subject: gdb-6.7-testsuite-stable-results.patch
-
-;; Testsuite fixes for more stable/comparable results.
-;;=fedoratest
-
-gdb/testsuite/gdb.base/fileio.c:
-gdb/testsuite/gdb.base/fileio.exp:
-2007-12-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
-
-	* gdb.base/fileio.c (ROOTSUBDIR): New macro.
-	(main): CHDIR into ROOTSUBDIR.  CHOWN ROOTSUBDIR and CHDIR into
-	ROOTSUBDIR if we are being run as root.
-	* gdb.base/fileio.exp: Change the startup and finish cleanup.
-	Change the test file reference to be into the `fileio.dir' directory.
-
-sources/gdb/testsuite/gdb.base/dump.exp:
-Found on RHEL-5.s390x.
-
-gdb-6.8.50.20090209/gdb/testsuite/gdb.base/auxv.exp:
-random FAIL: gdb.base/auxv.exp: matching auxv data from live and gcore
-
-gdb-6.8.50.20090209/gdb/testsuite/gdb.base/annota1.exp:
-frames-invalid can happen asynchronously.
-
-diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
---- a/gdb/testsuite/gdb.base/fileio.c
-+++ b/gdb/testsuite/gdb.base/fileio.c
-@@ -559,6 +559,28 @@ strerrno (int err)
- int
- main ()
- {
-+  /* These tests
-+       Open for write but no write permission returns EACCES
-+       Unlinking a file in a directory w/o write access returns EACCES
-+     fail if we are being run as root - drop the privileges here.  */
-+
-+  if (geteuid () == 0)
-+    {
-+      uid_t uid = 99;
-+
-+      if (chown (OUTDIR, uid, uid) != 0)
-+	{
-+	  printf ("chown %d.%d %s: %s\n", (int) uid, (int) uid,
-+		  OUTDIR, strerror (errno));
-+	  exit (1);
-+	}
-+      if (setuid (uid) || geteuid () == 0)
-+	{
-+	  printf ("setuid %d: %s\n", (int) uid, strerror (errno));
-+	  exit (1);
-+	}
-+    }
-+
-   /* Don't change the order of the calls.  They partly depend on each other */
-   test_open ();
-   test_write ();
-diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
---- a/gdb/testsuite/gdb.base/fileio.exp
-+++ b/gdb/testsuite/gdb.base/fileio.exp
-@@ -24,9 +24,9 @@ if [target_info exists gdb,nofileio] {
- standard_testfile
- 
- if {[is_remote host]} {
--    set outdir .
-+    set outdir "fileio.dir"
- } else {
--    set outdir [standard_output_file {}]
-+    set outdir [standard_output_file "fileio.dir"]
- }
- 
- if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
-@@ -40,7 +40,8 @@ set dir2 [standard_output_file dir2.fileio.test]
- if {[file exists $dir2] && ![file writable $dir2]} {
-     system "chmod +w $dir2"
- }
--system "rm -rf [standard_output_file *.fileio.test]"
-+system "rm -rf [standard_output_file fileio.dir]"
-+system "mkdir -m777 [standard_output_file fileio.dir]"
- 
- set oldtimeout $timeout
- set timeout [expr "$timeout + 60"]
-@@ -81,7 +82,7 @@ gdb_test continue \
- 
- gdb_test "continue" ".*" ""
- 
--catch "system \"chmod -f -w [standard_output_file nowrt.fileio.test]\""
-+catch "system \"chmod -f -w [standard_output_file fileio.dir/nowrt.fileio.test]\""
- 
- gdb_test continue \
- "Continuing\\..*open 5:.*EACCES$stop_msg" \
-@@ -268,9 +269,7 @@ gdb_test continue \
- gdb_exit
- 
- # Make dir2 writable again so rm -rf of a build tree Just Works.
--if {[file exists $dir2] && ![file writable $dir2]} {
--    system "chmod +w $dir2"
--}
-+system "chmod -R +w $outdir"
- 
- set timeout $oldtimeout
- return 0

diff --git a/gdb.spec b/gdb.spec
index f2e896f..75190c7 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -1252,6 +1252,10 @@ fi
 %endif
 
 %changelog
+* Wed Aug  9 2023 Guinevere Larsen <blarsen@redhat.com>
+- Remove gdb-6.7-testsuite-stable-results.patch, it only made the test
+  fail more.
+
 * Mon Aug  7 2023 Kevin Buettner <kevinb@redhat.com> - 13.2-7
 - Bump release.