[rpms/gdb] gdb-17.2-rebase-f44: Fix regression accessing errno from a core file (RH BZ 1166549).

[rpms/gdb] gdb-17.2-rebase-f44: Fix regression accessing errno from a core file (RH BZ 1166549).

[Jan Kratochvil]

A new commit has been pushed.

Repo   : rpms/gdb
Branch : gdb-17.2-rebase-f44
Commit : a79edc166a9ed3ddaa11341da6f324f41dbe1a6f
Author : Jan Kratochvil <jan.kratochvil@redhat.com>
Date   : 2014-11-21T19:29:14+01:00
Stats  : +129/-10 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/gdb/c/a79edc166a9ed3ddaa11341da6f324f41dbe1a6f?branch=gdb-17.2-rebase-f44

Log:
Fix regression accessing errno from a core file (RH BZ 1166549).

---
diff --git a/gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch b/gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch
index 1c8f99b..2bb277a 100644
--- a/gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch
+++ b/gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch
@@ -22,6 +22,8 @@ for the most common under-ggdb3 compiled programs.
 Original patch hooked into target_translate_tls_address.  But its inferior
 call invalidates `struct frame *' in the callers - RH BZ 690908.
 
+https://bugzilla.redhat.com/show_bug.cgi?id=1166549
+
 
 2007-11-03  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
@@ -32,23 +34,23 @@ glibc-debuginfo-2.7-2.x86_64: /usr/lib/debug/lib64/libc.so.6.debug:
   <81a2>     DW_AT_name        : (indirect string, offset: 0x280e): __errno_location
   <81a8>     DW_AT_MIPS_linkage_name: (indirect string, offset: 0x2808): *__GI___errno_location
 
-Index: gdb-7.6.50.20130731-cvs/gdb/printcmd.c
+Index: gdb-7.8.1/gdb/printcmd.c
 ===================================================================
---- gdb-7.6.50.20130731-cvs.orig/gdb/printcmd.c	2013-08-02 16:21:13.665758324 +0200
-+++ gdb-7.6.50.20130731-cvs/gdb/printcmd.c	2013-08-02 16:22:24.367853322 +0200
-@@ -982,6 +982,8 @@ print_command_1 (const char *exp, int vo
+--- gdb-7.8.1.orig/gdb/printcmd.c	2014-11-21 19:05:44.699959209 +0100
++++ gdb-7.8.1/gdb/printcmd.c	2014-11-21 19:05:44.868959291 +0100
+@@ -980,6 +980,8 @@ print_command_1 (const char *exp, int vo
  
    if (exp && *exp)
      {
-+      if (strcmp (exp, "errno") == 0)
++      if (target_has_execution && strcmp (exp, "errno") == 0)
 +	exp = "*((int *(*) (void)) __errno_location) ()";
        expr = parse_expression (exp);
        make_cleanup (free_current_contents, &expr);
        val = evaluate_expression (expr);
-Index: gdb-7.6.50.20130731-cvs/gdb/testsuite/gdb.dwarf2/dw2-errno.c
+Index: gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno.c
 ===================================================================
 --- /dev/null	1970-01-01 00:00:00.000000000 +0000
-+++ gdb-7.6.50.20130731-cvs/gdb/testsuite/gdb.dwarf2/dw2-errno.c	2013-08-02 16:21:13.665758324 +0200
++++ gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno.c	2014-11-21 19:05:44.869959291 +0100
 @@ -0,0 +1,28 @@
 +/* This testcase is part of GDB, the GNU debugger.
 +
@@ -78,10 +80,10 @@ Index: gdb-7.6.50.20130731-cvs/gdb/testsuite/gdb.dwarf2/dw2-errno.c
 +
 +  return 0;	/* breakpoint */
 +}
-Index: gdb-7.6.50.20130731-cvs/gdb/testsuite/gdb.dwarf2/dw2-errno.exp
+Index: gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno.exp
 ===================================================================
 --- /dev/null	1970-01-01 00:00:00.000000000 +0000
-+++ gdb-7.6.50.20130731-cvs/gdb/testsuite/gdb.dwarf2/dw2-errno.exp	2013-08-02 16:21:13.665758324 +0200
++++ gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno.exp	2014-11-21 19:05:44.869959291 +0100
 @@ -0,0 +1,60 @@
 +# Copyright 2007 Free Software Foundation, Inc.
 +
@@ -143,3 +145,117 @@ Index: gdb-7.6.50.20130731-cvs/gdb/testsuite/gdb.dwarf2/dw2-errno.exp
 +
 +# TODO: Test the error on resolving ERRNO with only libc loaded.
 +# Just how to find the current libc filename?
+Index: gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno2.c
+===================================================================
+--- /dev/null	1970-01-01 00:00:00.000000000 +0000
++++ gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno2.c	2014-11-21 19:05:44.869959291 +0100
+@@ -0,0 +1,28 @@
++/* This testcase is part of GDB, the GNU debugger.
++
++   Copyright 2005, 2007 Free Software Foundation, Inc.
++
++   This program is free software; you can redistribute it and/or modify
++   it under the terms of the GNU General Public License as published by
++   the Free Software Foundation; either version 3 of the License, or
++   (at your option) any later version.
++
++   This program is distributed in the hope that it will be useful,
++   but WITHOUT ANY WARRANTY; without even the implied warranty of
++   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++   GNU General Public License for more details.
++
++   You should have received a copy of the GNU General Public License
++   along with this program.  If not, see <http://www.gnu.org/licenses/>.
++
++   Please email any bugs, comments, and/or additions to this file to:
++   bug-gdb@prep.ai.mit.edu  */
++
++#include <errno.h>
++
++int main()
++{
++  errno = 42;
++
++  return 0;	/* breakpoint */
++}
+Index: gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno2.exp
+===================================================================
+--- /dev/null	1970-01-01 00:00:00.000000000 +0000
++++ gdb-7.8.1/gdb/testsuite/gdb.dwarf2/dw2-errno2.exp	2014-11-21 19:13:01.553171326 +0100
+@@ -0,0 +1,76 @@
++# Copyright 2007 Free Software Foundation, Inc.
++
++# This program is free software; you can redistribute it and/or modify
++# it under the terms of the GNU General Public License as published by
++# the Free Software Foundation; either version 3 of the License, or
++# (at your option) any later version.
++#
++# This program is distributed in the hope that it will be useful,
++# but WITHOUT ANY WARRANTY; without even the implied warranty of
++# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++# GNU General Public License for more details.
++#
++# You should have received a copy of the GNU General Public License
++# along with this program.  If not, see <http://www.gnu.org/licenses/>.
++
++set testfile dw2-errno2
++set srcfile ${testfile}.c
++set binfile ${objdir}/${subdir}/${testfile}
++
++proc prep { message {do_xfail 0} } { with_test_prefix $message {
++    global srcdir subdir binfile variant
++    gdb_exit
++    gdb_start
++    gdb_reinitialize_dir $srcdir/$subdir
++    gdb_load ${binfile}${variant}
++
++    runto_main
++
++    gdb_breakpoint [gdb_get_line_number "breakpoint"]
++    gdb_continue_to_breakpoint "breakpoint"
++
++    gdb_test "gcore ${binfile}${variant}.core" "\r\nSaved corefile .*" "gcore $variant"
++
++    gdb_test "print errno" ".* = 42"
++
++    gdb_test "kill" ".*" "kill" {Kill the program being debugged\? \(y or n\) } "y"
++    gdb_test "core-file ${binfile}${variant}.core" "\r\nCore was generated by .*" "core-file"
++    if $do_xfail {
++	setup_xfail "*-*-*"
++    }
++    gdb_test "print errno" ".* = 42" "print errno for core"
++}}
++
++set variant g2thrN
++if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}${variant}" executable "additional_flags=-g2"] != "" } {
++    untested "Couldn't compile test program"
++    return -1
++}
++prep "macros=N threads=N" 1
++
++set variant g3thrN
++if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}${variant}" executable "additional_flags=-g3"] != "" } {
++    untested "Couldn't compile test program"
++    return -1
++}
++prep "macros=Y threads=N" 1
++
++set variant g2thrY
++if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}${variant}" executable "additional_flags=-g2"] != "" } {
++    return -1
++}
++# FIXME: Why?
++set do_xfail 0
++if { [istarget x86_64-*-* ] && ![is_lp64_target] } {
++    set do_xfail 1
++}
++prep "macros=N threads=Y" $do_xfail
++
++set variant g3thrY
++if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}${variant}" executable "additional_flags=-g3"] != "" } {
++    return -1
++}
++prep "macros=Y threads=Y" 1
++
++# TODO: Test the error on resolving ERRNO with only libc loaded.
++# Just how to find the current libc filename?

diff --git a/gdb.spec b/gdb.spec
index 7698657..a258f6b 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -26,7 +26,7 @@ Version: 7.8.1
 
 # The release always contains a leading reserved number, start it at 1.
 # `upstream' is not a part of `name' to stay fully rpm dependencies compatible for the testing.
-Release: 32%{?dist}
+Release: 33%{?dist}
 
 License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ and GPLv2+ with exceptions and GPL+ and LGPLv2+ and BSD and Public Domain and GFDL
 Group: Development/Debuggers
@@ -1334,6 +1334,9 @@ then
 fi
 
 %changelog
+* Fri Nov 21 2014 Jan Kratochvil <jan.kratochvil@redhat.com> - 7.8.1-33.fc21
+- Fix regression accessing errno from a core file (RH BZ 1166549).
+
 * Thu Nov 20 2014 Sergio Durigan Junior <sergiodj@redhat.com> - 7.8.1-32.fc21
 - Fix 'Unowned dir /usr/include/gdb/' (RH BZ 1164991).