public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/globus-gram-job-manager-lsf] rawhide: Fix compiler warnings
@ 2026-06-14 8:47 Mattias Ellert
0 siblings, 0 replies; only message in thread
From: Mattias Ellert @ 2026-06-14 8:47 UTC (permalink / raw)
To: git-commits
A new commit has been pushed.
Repo : rpms/globus-gram-job-manager-lsf
Branch : rawhide
Commit : 25910128f46deb21322ff437103f2413710f7465
Author : Mattias Ellert <mattias.ellert@physics.uu.se>
Date : 2026-06-14T10:39:13+02:00
Stats : +151/-1 in 3 file(s)
URL : https://src.fedoraproject.org/rpms/globus-gram-job-manager-lsf/c/25910128f46deb21322ff437103f2413710f7465?branch=rawhide
Log:
Fix compiler warnings
---
diff --git a/0001-Untabify-and-remove-trailing-white-space.patch b/0001-Untabify-and-remove-trailing-white-space.patch
new file mode 100644
index 0000000..f352d69
--- /dev/null
+++ b/0001-Untabify-and-remove-trailing-white-space.patch
@@ -0,0 +1,76 @@
+From 3ccdaa0236230bbcbcbf339e7dfdfaf23c10bd6f Mon Sep 17 00:00:00 2001
+From: Mattias Ellert <mattias.ellert@physics.uu.se>
+Date: Wed, 20 May 2026 00:15:37 +0200
+Subject: [PATCH 1/2] Untabify and remove trailing white-space
+
+---
+ .../lrms/lsf/source/seg/seg_lsf_module.c | 16 ++++++++--------
+ 1 file changed, 8 insertions(+), 8 deletions(-)
+
+diff --git a/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c b/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c
+index 0c0d6a01a..a1f1575fc 100644
+--- a/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c
++++ b/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c
+@@ -122,7 +122,7 @@ enum
+ /**
+ * State of the LSF log file parser.
+ */
+-typedef struct
++typedef struct
+ {
+ /**
+ * Path to the LSF logdir
+@@ -333,9 +333,9 @@ globus_l_lsf_module_activate(void)
+ if (result != GLOBUS_SUCCESS)
+ {
+ SEGLsfDebug(SEG_LSF_DEBUG_ERROR,
+- ("Error retrieving log_path attribute from "
++ ("Error retrieving log_path attribute from "
+ "${sysconfdir}/globus/globus-lsf.conf\n"));
+-
++
+ goto free_config_path_error;
+ }
+ free(config_path);
+@@ -439,7 +439,7 @@ globus_l_lsf_module_deactivate(void)
+ * read_cb:
+ * check to see if lsb.events.index file changed---if so, we must relocate
+ * our position in the appropriate log file.
+- *
++ *
+ * if we're ok---parse events buffer
+ *
+ * if (!eof)
+@@ -519,7 +519,7 @@ globus_l_lsf_read_callback(
+
+ rc = fread(state->buffer + state->buffer_point + state->buffer_valid,
+ 1, max_to_read, state->fp);
+-
++
+ SEGLsfDebug(SEG_LSF_DEBUG_TRACE,
+ ("read %d bytes\n", rc));
+
+@@ -605,9 +605,9 @@ error:
+ /* globus_l_lsf_read_callback() */
+
+ /**
+- * Determine the next available LSF log file name from the
++ * Determine the next available LSF log file name from the
+ * timestamp stored in the logfile state structure.
+- *
++ *
+ * @param state
+ * LSF log state structure. The path field of the structure may be
+ * modified by this function.
+@@ -721,7 +721,7 @@ error:
+ /* globus_l_lsf_find_logfile() */
+
+ /**
+- * Move any data in the state buffer to the beginning, to enable reusing
++ * Move any data in the state buffer to the beginning, to enable reusing
+ * buffer space which has already been parsed.
+ */
+ static
+--
+2.54.0
+
diff --git a/0002-Fix-compiler-and-doxygen-warnings.patch b/0002-Fix-compiler-and-doxygen-warnings.patch
new file mode 100644
index 0000000..b8b3b23
--- /dev/null
+++ b/0002-Fix-compiler-and-doxygen-warnings.patch
@@ -0,0 +1,67 @@
+From 4ee08d13e2963309e2063dc45dedd067337d3b76 Mon Sep 17 00:00:00 2001
+From: Mattias Ellert <mattias.ellert@physics.uu.se>
+Date: Wed, 20 May 2026 00:15:37 +0200
+Subject: [PATCH 2/2] Fix compiler and doxygen warnings
+
+---
+ gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c | 11 +++++------
+ 1 file changed, 5 insertions(+), 6 deletions(-)
+
+diff --git a/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c b/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c
+index a1f1575fc..9356df5c3 100644
+--- a/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c
++++ b/gram/jobmanager/lrms/lsf/source/seg/seg_lsf_module.c
+@@ -810,7 +810,6 @@ globus_l_lsf_parse_events(
+ long long tmp_timestamp;
+ char event_type_buffer[64];
+ char job_id_buffer[32];
+- int rc;
+ int job_status;
+ int exit_status;
+ long offset;
+@@ -871,7 +870,7 @@ globus_l_lsf_parse_events(
+ {
+ if (event_timestamp >= state->start_timestamp)
+ {
+- rc = globus_scheduler_event_pending(event_timestamp,
++ globus_scheduler_event_pending(event_timestamp,
+ job_id_buffer);
+ state->start_timestamp = event_timestamp;
+ }
+@@ -880,7 +879,7 @@ globus_l_lsf_parse_events(
+ {
+ if (event_timestamp >= state->start_timestamp)
+ {
+- rc = globus_scheduler_event_active(event_timestamp,
++ globus_scheduler_event_active(event_timestamp,
+ job_id_buffer);
+
+ state->start_timestamp = event_timestamp;
+@@ -975,13 +974,13 @@ globus_l_lsf_parse_events(
+ {
+ sscanf(tmp, " %d", &exit_status);
+ exit_status = (exit_status & 0xff00) >> 8;
+- rc = globus_scheduler_event_done(event_timestamp,
++ globus_scheduler_event_done(event_timestamp,
+ job_id_buffer,
+ exit_status);
+ }
+ else
+ {
+- rc = globus_scheduler_event_failed(event_timestamp,
++ globus_scheduler_event_failed(event_timestamp,
+ job_id_buffer,
+ exit_status);
+ }
+@@ -994,7 +993,7 @@ globus_l_lsf_parse_events(
+ */
+ if (event_timestamp >= state->start_timestamp)
+ {
+- rc = globus_scheduler_event_done(event_timestamp,
++ globus_scheduler_event_done(event_timestamp,
+ job_id_buffer,
+ 0);
+ state->start_timestamp = event_timestamp;
+--
+2.54.0
+
diff --git a/globus-gram-job-manager-lsf.spec b/globus-gram-job-manager-lsf.spec
index d34400e..dc6e7bb 100644
--- a/globus-gram-job-manager-lsf.spec
+++ b/globus-gram-job-manager-lsf.spec
@@ -1,13 +1,15 @@
Name: globus-gram-job-manager-lsf
%global _name %(tr - _ <<< %{name})
Version: 3.1
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: Grid Community Toolkit - LSF Job Manager Support
License: Apache-2.0
URL: https://github.com/gridcf/gct/
Source: https://repo.gridcf.org/gct6/sources/%{_name}-%{version}.tar.gz
Source8: README
+Patch0: 0001-Untabify-and-remove-trailing-white-space.patch
+Patch1: 0002-Fix-compiler-and-doxygen-warnings.patch
BuildRequires: make
BuildRequires: gcc
@@ -75,6 +77,8 @@ state
%prep
%setup -q -n %{_name}-%{version}
+%patch -P0 -p6
+%patch -P1 -p6
%build
# Reduce overlinking
@@ -157,6 +161,9 @@ fi
%config(noreplace) %{_sysconfdir}/globus/scheduler-event-generator/available/lsf
%changelog
+* Sun Jun 14 2026 Mattias Ellert <mattias.ellert@physics.uu.se> - 3.1-3
+- Fix compiler warnings
+
* Fri Jan 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 3.1-2
- Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-14 8:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-14 8:47 [rpms/globus-gram-job-manager-lsf] rawhide: Fix compiler warnings Mattias Ellert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox