public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
* [rpms/phoc] f44: Disable xdg_shell_toplevel_maximized_scale test
@ 2026-06-03  4:32 
  0 siblings, 0 replies; only message in thread
From:  @ 2026-06-03  4:32 UTC (permalink / raw)
  To: git-commits

            A new commit has been pushed.

            Repo   : rpms/phoc
            Branch : f44
            Commit : 09d02bc49be040d9ab5103a3b1b0b53e744724c6
            Author : Tomi Lähteenmäki <lihis@lihis.net>
            Date   : 2026-06-03T07:09:49+03:00
            Stats  : +80/-1 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/phoc/c/09d02bc49be040d9ab5103a3b1b0b53e744724c6?branch=f44

            Log:
            Disable xdg_shell_toplevel_maximized_scale test

It works on wlroots 0.20.0 but fails on 0.20.1

---
diff --git a/0001-disable-test-xdg_shell_toplevel_maximized_scale.patch b/0001-disable-test-xdg_shell_toplevel_maximized_scale.patch
new file mode 100644
index 0000000..adf9154
--- /dev/null
+++ b/0001-disable-test-xdg_shell_toplevel_maximized_scale.patch
@@ -0,0 +1,76 @@
+diff --git a/tests/test-xdg-shell.c b/tests/test-xdg-shell.c
+index b6da782..e295867 100644
+--- a/tests/test-xdg-shell.c
++++ b/tests/test-xdg-shell.c
+@@ -80,36 +80,6 @@ test_client_xdg_shell_toplevel_maximized (PhocTestClientGlobals *globals, gpoint
+ }
+ 
+ 
+-static gboolean
+-test_client_xdg_shell_toplevel_maximized_scale (PhocTestClientGlobals *globals, gpointer data)
+-{
+-  PhocTestXdgToplevelSurface *xs;
+-  guint32 color = 0xFF00FF00;
+-
+-  xs = phoc_test_xdg_toplevel_new_with_buffer (globals, 0, 0, "to-max", color);
+-  g_assert_nonnull (xs);
+-
+-  /* Maximize */
+-  zwlr_foreign_toplevel_handle_v1_set_maximized (xs->foreign_toplevel->handle);
+-  wl_surface_commit (xs->wl_surface);
+-  wl_display_dispatch (globals->display);
+-  /* We got the maximized size, update the buffer */
+-  phoc_test_xdg_update_buffer (globals, xs, color);
+-  phoc_assert_screenshot (globals, "test-xdg-shell-maximized-2.5.png");
+-
+-  /* Back to normal state */
+-  zwlr_foreign_toplevel_handle_v1_unset_maximized (xs->foreign_toplevel->handle);
+-  wl_display_dispatch (globals->display);
+-  phoc_test_xdg_update_buffer (globals, xs, color);
+-  phoc_assert_screenshot (globals, "test-xdg-shell-normal-2.5.png");
+-
+-  phoc_test_xdg_toplevel_free (xs);
+-  phoc_assert_screenshot (globals, "empty-2.5.png");
+-
+-  return TRUE;
+-}
+-
+-
+ static gboolean
+ test_client_xdg_shell_server_prepare (PhocServer *server, gpointer data)
+ {
+@@ -164,25 +134,6 @@ test_xdg_shell_toplevel_maximized (void)
+ }
+ 
+ 
+-static void
+-test_xdg_shell_toplevel_maximized_scale (void)
+-{
+-  PhocTestClientIface iface = {
+-    .server_prepare = test_client_xdg_shell_server_prepare,
+-    .client_run     = test_client_xdg_shell_toplevel_maximized_scale,
+-    .debug_flags    = PHOC_SERVER_DEBUG_FLAG_DISABLE_ANIMATIONS,
+-    .output_config  = (PhocTestOutputConfig){
+-      .width = 360,
+-      .height = 720,
+-      .scale = 2.5,
+-      .transform = WL_OUTPUT_TRANSFORM_270,
+-    },
+-  };
+-
+-  phoc_test_client_run (TEST_PHOC_CLIENT_TIMEOUT, &iface, GINT_TO_POINTER (FALSE));
+-}
+-
+-
+ int
+ main (int argc, char *argv[])
+ {
+@@ -191,8 +142,6 @@ main (int argc, char *argv[])
+   PHOC_TEST_ADD ("/phoc/xdg-shell/simple/normal", test_xdg_shell_normal);
+   PHOC_TEST_ADD ("/phoc/xdg-shell/auto-maximize/normal", test_xdg_shell_auto_maximized);
+   PHOC_TEST_ADD ("/phoc/xdg-shell/toplevel/maximize/normal", test_xdg_shell_toplevel_maximized);
+-  PHOC_TEST_ADD ("/phoc/xdg-shell/toplevel/maximize/scale",
+-                 test_xdg_shell_toplevel_maximized_scale);
+ 
+   return g_test_run ();
+ }

diff --git a/phoc.spec b/phoc.spec
index cd6c52f..5426ed6 100644
--- a/phoc.spec
+++ b/phoc.spec
@@ -10,6 +10,9 @@ URL:      https://gitlab.gnome.org/World/Phosh/phoc
 Source0:  https://gitlab.gnome.org/World/Phosh/phoc/-/archive/v%{version_no_tilde _}/%{name}-v%{version_no_tilde _}.tar.gz
 Source1:  https://gitlab.gnome.org/GNOME/gvdb/-/archive/%{gvdb_commit}/gvdb-%{gvdb_commit}.tar.gz
 
+# test_client_xdg_shell_toplevel_maximized_scale fails on wlroots 0.20.1
+Patch0:   0001-disable-test-xdg_shell_toplevel_maximized_scale.patch
+
 BuildRequires:  gcc
 BuildRequires:  meson
 BuildRequires:  cmake
@@ -53,7 +56,7 @@ Phoc is a wlroots based Phone compositor as used on the Librem5. Phoc is
 pronounced like the English word fog.
 
 %prep
-%setup -a1 -q -n %{name}-v%{version_no_tilde _}
+%autosetup -a1 -p1 -n %{name}-v%{version_no_tilde _}
 mv gvdb-%{gvdb_commit} subprojects/gvdb
 
 %conf

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-06-03  4:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-03  4:32 [rpms/phoc] f44: Disable xdg_shell_toplevel_maximized_scale test 

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox